From 1d9b322e3e5a30c50d9901d11f83e00666c3bb23 Mon Sep 17 00:00:00 2001 From: mlangkabel Date: Fri, 13 Oct 2017 12:03:36 +0200 Subject: [PATCH] ui: fixes in update checker ui * init updatecheck ui with "checking for update..." to counter the effect of the timer start delay * removed message box telling the user "everything is ok" after manual (forced) update check --- src/lib_gui/qt/element/QtUpdateCheckerWidget.cpp | 2 ++ src/lib_gui/qt/network/QtUpdateChecker.cpp | 10 ---------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/lib_gui/qt/element/QtUpdateCheckerWidget.cpp b/src/lib_gui/qt/element/QtUpdateCheckerWidget.cpp index 9d1e58d3..24b74b05 100644 --- a/src/lib_gui/qt/element/QtUpdateCheckerWidget.cpp +++ b/src/lib_gui/qt/element/QtUpdateCheckerWidget.cpp @@ -28,6 +28,8 @@ QtUpdateCheckerWidget::QtUpdateCheckerWidget(QWidget* parent) { if (QtUpdateChecker::needsAutomaticCheck()) { + m_button->setText("checking for update..."); + m_button->setEnabled(false); QTimer::singleShot(250, [this]() { diff --git a/src/lib_gui/qt/network/QtUpdateChecker.cpp b/src/lib_gui/qt/network/QtUpdateChecker.cpp index 3d8f5c51..c0a0a003 100644 --- a/src/lib_gui/qt/network/QtUpdateChecker.cpp +++ b/src/lib_gui/qt/network/QtUpdateChecker.cpp @@ -156,16 +156,6 @@ void QtUpdateChecker::check(bool force, std::function callback) QDesktopServices::openUrl(QUrl(url, QUrl::TolerantMode)); } } - else if (force) - { - QMessageBox msgBox; - msgBox.setText("Update Check"); - msgBox.setInformativeText( - ("Sourcetrial " + Version::getApplicationVersion().toDisplayString() + " is still up-to-date.").c_str()); - msgBox.setStandardButtons(QMessageBox::Ok); - msgBox.setDefaultButton(QMessageBox::Ok); - msgBox.exec(); - } } while (false);