logic: ship clang compiler header within Sourcetrail package on Windows

* added clang system headers to data folder of Sourcetrail repo
* added clang system header search directory to detected directories on windows
* updated migration to add clang system header search directory on windows
* updated windows installer and portable package to include compiler headers
* updated linux package
* cleaned code of path detectors
* unrelated removal of unnecessary code in LicenseChecker and UpdateChecker

src/lib/LicenseChecker.cpp

@@ -24,10 +24,6 @@ std::shared_ptr<LicenseChecker> LicenseChecker::getInstance()
 	return s_instance;
 }
 
-LicenseChecker::~LicenseChecker()
-{
-}
-
 std::string LicenseChecker::getCurrentLicenseString() const
 {
 	License license;

src/lib/LicenseChecker.h

@@ -21,7 +21,7 @@ public:
 	static void createInstance();
 	static std::shared_ptr<LicenseChecker> getInstance();
 
-	~LicenseChecker();
+	~LicenseChecker() = default;
 
 	std::string getCurrentLicenseString() const;
 	void saveCurrentLicenseString(const std::string& licenseString) const;

src/lib/UpdateChecker.h

@@ -4,8 +4,7 @@
 class UpdateChecker
 {
 public:
-	virtual ~UpdateChecker() {}
-
+	virtual ~UpdateChecker() = default;
 	virtual void checkUpdate() = 0;
 };
 

src/lib/utility/utilityCxx.cpp

@@ -7,18 +7,20 @@ namespace utility
 {
 	std::vector<FilePath> replaceOrAddCxxCompilerHeaderPath(const std::vector<FilePath>& headerSearchPaths)
 	{
-		if (utility::getOsType() == OS_WINDOWS)
-		{
-			return headerSearchPaths;
-		}
-
 		std::vector<FilePath> newHeaderSearchPaths;
 
-		for (const FilePath& path : headerSearchPaths)
+		if (utility::getOsType() == OS_WINDOWS)
 		{
-			if (!path.getConcatenated(L"/stdarg.h").exists())
+			newHeaderSearchPaths = headerSearchPaths;
+		}
+		else
+		{
+			for (const FilePath& path : headerSearchPaths)
 			{
-				newHeaderSearchPaths.push_back(path);
+				if (!path.getConcatenated(L"/stdarg.h").exists())
+				{
+					newHeaderSearchPaths.push_back(path);
+				}
 			}
 		}