ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix more clazy qstring-allocation warnings and pass parameters by reference (#910)

Browse Source 
* Fix some more clazy-qstring-allocation warnings

* Fix missing refs on large types in lib_gui

* Fix trivially copyable types being passed by ref in lib_gui
This commit is contained in:
Waqar Ahmed
2020-02-12 22:13:36 +01:00
committed by GitHub
parent 71ef2f31a1
commit 222e3d578a
103 changed files with 522 additions and 414 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/component/view/CodeView.h
+6 -6
View File
@@ -55,16 +55,16 @@ public:
virtual void clear() = 0;
virtual void showSnippets(
const std::vector<CodeFileParams> files,
const CodeParams params,
const CodeScrollParams scrollParams) = 0;
const std::vector<CodeFileParams>& files,
const CodeParams& params,
const CodeScrollParams& scrollParams) = 0;
virtual void showSingleFile(
const CodeFileParams file, const CodeParams params, const CodeScrollParams scrollParams) = 0;
const CodeFileParams& file, const CodeParams& params, const CodeScrollParams& scrollParams) = 0;
virtual void updateSourceLocations(const std::vector<CodeFileParams> files) = 0;
virtual void updateSourceLocations(const std::vector<CodeFileParams>& files) = 0;
virtual void scrollTo(const CodeScrollParams params, bool animated) = 0;
virtual void scrollTo(const CodeScrollParams& params, bool animated) = 0;
virtual bool showsErrors() const = 0;
src/lib/component/view/TabsView.h
+2 -2
View File
@@ -17,11 +17,11 @@ public:
virtual void clear() = 0;
virtual void openTab(bool showTab, SearchMatch match) = 0;
virtual void openTab(bool showTab, const SearchMatch& match) = 0;
virtual void closeTab() = 0;
virtual void destroyTab(Id tabId) = 0;
virtual void selectTab(bool next) = 0;
virtual void updateTab(Id tabId, std::vector<SearchMatch> matches) = 0;
virtual void updateTab(Id tabId, const std::vector<SearchMatch>& matches) = 0;
};
#endif // TABS_VIEW_H
src/lib/component/view/TooltipView.h
+1 -1
View File
@@ -17,7 +17,7 @@ public:
// View implementation
virtual std::string getName() const;
virtual void showTooltip(TooltipInfo info, const View* parent) = 0;
virtual void showTooltip(const TooltipInfo& info, const View* parent) = 0;
virtual void hideTooltip(bool force) = 0;
virtual bool tooltipVisible() const = 0;