ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix more clazy qstring-allocation warnings and pass parameters by reference (#910)

Browse Source 
* Fix some more clazy-qstring-allocation warnings

* Fix missing refs on large types in lib_gui

* Fix trivially copyable types being passed by ref in lib_gui
This commit is contained in:
Waqar Ahmed
2020-02-12 22:13:36 +01:00
committed by GitHub
parent 71ef2f31a1
commit 222e3d578a
103 changed files with 522 additions and 414 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_gui/qt/element/code/QtCodeFileTitleBar.cpp
+8 -3
View File
@@ -32,7 +32,10 @@ QtCodeFileTitleBar::QtCodeFileTitleBar(QWidget* parent, bool isHovering, bool is
FilePath imageDir = ResourcePaths::getGuiPath().concatenate(L"code_view/images/");
m_expandButton = new QtSelfRefreshIconButton(
QLatin1String(""), imageDir.getConcatenated(L"snippet_arrow_right.png"), "code/file/title", this);
QLatin1String(""),
imageDir.getConcatenated(L"snippet_arrow_right.png"),
"code/file/title",
this);
m_collapseButton = new QtSelfRefreshIconButton(
QLatin1String(""), imageDir.getConcatenated(L"snippet_arrow_down.png"), "code/file/title", this);
@@ -74,7 +77,8 @@ QtCodeFileTitleBar::QtCodeFileTitleBar(QWidget* parent, bool isHovering, bool is
m_showErrorsButton = new QPushButton(QStringLiteral("show errors"));
m_showErrorsButton->setObjectName(QStringLiteral("screen_button"));
m_showErrorsButton->setToolTip(QStringLiteral("Show all errors causing this file to be incomplete"));
m_showErrorsButton->setToolTip(
QStringLiteral("Show all errors causing this file to be incomplete"));
m_showErrorsButton->setAttribute(Qt::WA_LayoutUsesWidgetRect); // fixes layouting on Mac
m_showErrorsButton->hide();
titleLayout->addWidget(m_showErrorsButton);
@@ -168,7 +172,8 @@ void QtCodeFileTitleBar::updateRefCount(int refCount, bool hasErrors, size_t fat
if (fatalErrorCount > 0)
{
label += QStringLiteral(" (") + QString::number(fatalErrorCount) + QStringLiteral(" fatal)");
label += QStringLiteral(" (") + QString::number(fatalErrorCount) +
QStringLiteral(" fatal)");
}
QString text = QString::number(refCount) + QChar(' ') + label;