perf: Fix more clazy qstring-allocation warnings and pass parameters by reference (#910)

* Fix some more clazy-qstring-allocation warnings

* Fix missing refs on large types in lib_gui

* Fix trivially copyable types being passed by ref in lib_gui
This commit is contained in:
Waqar Ahmed
2020-02-12 22:13:36 +01:00
committed by GitHub
parent 71ef2f31a1
commit 222e3d578a
103 changed files with 522 additions and 414 deletions
@@ -78,8 +78,10 @@ QtCodeNavigator::QtCodeNavigator(QWidget* parent)
m_nextLocalReferenceButton = new QtSearchBarButton(
ResourcePaths::getGuiPath().concatenate(L"code_view/images/arrow_down.png"), true);
m_prevLocalReferenceButton->setObjectName(QStringLiteral("local_reference_button_previous"));
m_nextLocalReferenceButton->setObjectName(QStringLiteral("local_reference_button_next"));
m_prevLocalReferenceButton->setObjectName(
QStringLiteral("local_reference_button_previous"));
m_nextLocalReferenceButton->setObjectName(
QStringLiteral("local_reference_button_next"));
m_prevLocalReferenceButton->setToolTip(QStringLiteral("previous local reference"));
m_nextLocalReferenceButton->setToolTip(QStringLiteral("next local reference"));