ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix more clazy qstring-allocation warnings and pass parameters by reference (#910)

Browse Source 
* Fix some more clazy-qstring-allocation warnings

* Fix missing refs on large types in lib_gui

* Fix trivially copyable types being passed by ref in lib_gui
This commit is contained in:
Waqar Ahmed
2020-02-12 22:13:36 +01:00
committed by GitHub
parent 71ef2f31a1
commit 222e3d578a
103 changed files with 522 additions and 414 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_gui/qt/graphics/graph/QtGraphNode.cpp
+3 -3
View File
@@ -143,7 +143,7 @@ QSize QtGraphNode::size() const
return QSize(m_size.x, m_size.y);
}
void QtGraphNode::setSize(const QSize& size)
void QtGraphNode::setSize(QSize size)
{
setSize(Vec2i(size.width(), size.height()));
}
@@ -607,8 +607,8 @@ void QtGraphNode::setStyle(const GraphViewStyle::NodeStyle& style)
m_matchText->setPos(
style.iconOffset.x + style.iconSize + style.textOffset.x, style.textOffset.y);
float charWidth = QFontMetrics(font).width(
QStringLiteral("QtGraphNode::QtGraphNode::QtGraphNode")) / 37.0f;
float charWidth =
QFontMetrics(font).width(QStringLiteral("QtGraphNode::QtGraphNode::QtGraphNode")) / 37.0f;
float charHeight = QFontMetrics(font).height();
m_matchRect->setRect(
style.iconOffset.x + style.iconSize + style.textOffset.x + m_matchPos * charWidth,