Removed multiple dialog steps in Source Group setup (issue #723) (#913)

* removed QtSourceGroupWizard, QtSourceGroupWizardPage and context types
* removed isInForm flag of QtProjectWizardContent
* added check of empty source paths
* set project window as parent for message boxes, so they don't get hidden behind main window
* fixed issues when removing and duplicating source groups
* updated project setup tests to no steps
This commit is contained in:
Eberhard Gräther
2020-02-10 20:00:36 +01:00
committed by GitHub
parent 7f9f098c70
commit 260f1227bc
51 changed files with 485 additions and 1010 deletions
@@ -9,7 +9,6 @@
QtProjectWizardContent::QtProjectWizardContent(QtProjectWizardWindow* window)
: QWidget(window)
, m_window(window)
, m_isInForm(false)
, m_showFilesFunctor(
std::bind(&QtProjectWizardContent::showFilesDialog, this, std::placeholders::_1))
{
@@ -28,11 +27,6 @@ bool QtProjectWizardContent::check()
return true;
}
bool QtProjectWizardContent::isScrollAble() const
{
return false;
}
std::vector<FilePath> QtProjectWizardContent::getFilePaths() const
{
return {};
@@ -48,16 +42,6 @@ QString QtProjectWizardContent::getFileNamesDescription() const
return QStringLiteral("files");
}
bool QtProjectWizardContent::isInForm() const
{
return m_isInForm;
}
void QtProjectWizardContent::setIsInForm(bool isInForm)
{
m_isInForm = isInForm;
}
QLabel* QtProjectWizardContent::createFormLabel(QString name) const
{
QLabel* label = new QLabel(name);
@@ -91,6 +75,7 @@ QtHelpButton* QtProjectWizardContent::addHelpButton(
const QString& helpTitle, const QString& helpText, QGridLayout* layout, int row) const
{
QtHelpButton* button = new QtHelpButton(QtHelpButtonInfo(helpTitle, helpText));
button->setMessageBoxParent(m_window);
layout->addWidget(button, row, QtProjectWizardWindow::HELP_COL, Qt::AlignTop);
return button;
}
@@ -126,7 +111,6 @@ QFrame* QtProjectWizardContent::addSeparator(QGridLayout* layout, int row) const
void QtProjectWizardContent::filesButtonClicked()
{
m_window->saveContent();
m_window->loadContent();
std::thread([&]() {
const std::vector<FilePath> filePaths = getFilePaths();