ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

logic: changed Java type_argument edges to originate in the generic type or method

Browse Source 
* added tests for java type argument recording
* implemented recording type arguments for java ExpressionMethodReferences
* changed type_argument edge to originate in generic type
* added type_usage edge for type_arguments that originates in context (e.g. calling method)
This commit is contained in:
mlangkabel
2018-08-20 16:27:53 +02:00
parent 14a8d024b9
commit 36a9d552da
104 changed files with 2136 additions and 893 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java_indexer/src/main/java/com/sourcetrail/AstVisitor.java
+104 -12
View File
@@ -41,6 +41,7 @@ import org.eclipse.jdt.core.dom.Name;
import org.eclipse.jdt.core.dom.NameQualifiedType;
import org.eclipse.jdt.core.dom.NormalAnnotation;
import org.eclipse.jdt.core.dom.PackageDeclaration;
import org.eclipse.jdt.core.dom.ParameterizedType;
import org.eclipse.jdt.core.dom.PrimitiveType;
import org.eclipse.jdt.core.dom.QualifiedName;
import org.eclipse.jdt.core.dom.QualifiedType;
@@ -53,6 +54,7 @@ import org.eclipse.jdt.core.dom.SuperMethodInvocation;
import org.eclipse.jdt.core.dom.SuperMethodReference;
import org.eclipse.jdt.core.dom.SwitchStatement;
import org.eclipse.jdt.core.dom.ThisExpression;
import org.eclipse.jdt.core.dom.Type;
import org.eclipse.jdt.core.dom.TypeDeclaration;
import org.eclipse.jdt.core.dom.TypeMethodReference;
import org.eclipse.jdt.core.dom.TypeParameter;
@@ -121,7 +123,6 @@ public abstract class AstVisitor extends ASTVisitor
DefinitionKind.EXPLICIT);
}
return true;
}
@@ -296,7 +297,6 @@ public abstract class AstVisitor extends ASTVisitor
DeclName symbolName = DeclNameResolver.getQualifiedDeclName(node, m_filePath, m_compilationUnit);
Range signatureRange = getRange(node);
if (!node.thrownExceptionTypes().isEmpty())
{
@@ -652,6 +652,32 @@ public abstract class AstVisitor extends ASTVisitor
}
return true;
}
@Override
public boolean visit(ParameterizedType node)
{
ITypeBinding binding = node.resolveBinding();
if (binding != null)
{
binding = binding.getTypeDeclaration();
}
for (Object o : node.typeArguments())
{
if (o instanceof Type)
{
Type type = (Type)o;
ITypeBinding typeBinding = type.resolveBinding();
m_client.recordReference(
ReferenceKind.TYPE_ARGUMENT,
BindingNameResolver.getQualifiedName(typeBinding, m_filePath, m_compilationUnit).orElse(TypeName.unsolved()).toDeclName().toNameHierarchy(),
BindingNameResolver.getQualifiedName(binding, m_filePath, m_compilationUnit).orElse(TypeName.unsolved()).toDeclName().toNameHierarchy(),
getRange(type));
}
}
return true;
}
@Override
public boolean visit(QualifiedName node)
@@ -688,7 +714,15 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(MethodInvocation node)
{
recordReferenceToMethodDeclaration(node.resolveMethodBinding(), getRange(node.getName()), ReferenceKind.CALL, m_contextStack.peek());
IMethodBinding methodBinding = node.resolveMethodBinding();
recordReferenceToMethodDeclaration(
methodBinding,
getRange(node.getName()),
ReferenceKind.CALL,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node, m_fileContent);
@@ -698,7 +732,15 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(SuperMethodInvocation node)
{
recordReferenceToMethodDeclaration(node.resolveMethodBinding(), getRange(node.getName()), ReferenceKind.CALL, m_contextStack.peek());
IMethodBinding methodBinding = node.resolveMethodBinding();
recordReferenceToMethodDeclaration(
methodBinding,
getRange(node.getName()),
ReferenceKind.CALL,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node, m_fileContent);
@@ -708,35 +750,47 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(ConstructorInvocation node)
{
IMethodBinding methodBinding = node.resolveConstructorBinding();
recordReferenceToMethodDeclaration(
node.resolveConstructorBinding(),
methodBinding,
m_fileContent.findRange("this", getRange(node).begin),
ReferenceKind.CALL,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
return true;
}
@Override
public boolean visit(SuperConstructorInvocation node)
{
IMethodBinding methodBinding = node.resolveConstructorBinding();
recordReferenceToMethodDeclaration(
node.resolveConstructorBinding(),
methodBinding,
m_fileContent.findRange("super", getRange(node).begin),
ReferenceKind.CALL,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
return true;
}
@Override
public boolean visit(CreationReference node)
{
IMethodBinding methodBinding = node.resolveMethodBinding();
recordReferenceToMethodDeclaration(
node.resolveMethodBinding(),
methodBinding,
m_fileContent.findRange("new", getRange(node).begin),
ReferenceKind.USAGE,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node);
@@ -746,11 +800,15 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(ExpressionMethodReference node)
{
IMethodBinding methodBinding = node.resolveMethodBinding();
recordReferenceToMethodDeclaration(
node.resolveMethodBinding(),
methodBinding,
getRange(node.getName()),
ReferenceKind.USAGE,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node, m_fileContent);
@@ -760,11 +818,15 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(SuperMethodReference node)
{
IMethodBinding methodBinding = node.resolveMethodBinding();
recordReferenceToMethodDeclaration(
node.resolveMethodBinding(),
methodBinding,
getRange(node.getName()),
ReferenceKind.USAGE,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node, m_fileContent);
@@ -774,18 +836,20 @@ public abstract class AstVisitor extends ASTVisitor
@Override
public boolean visit(TypeMethodReference node)
{
IMethodBinding binding = node.resolveMethodBinding();
if (binding == null && node.getType() != null && node.getType().isArrayType())
IMethodBinding methodBinding = node.resolveMethodBinding();
if (methodBinding == null && node.getType() != null && node.getType().isArrayType())
{
// Do nothing. We ignore the case of unsolved symbols on array type
}
else
{
recordReferenceToMethodDeclaration(
binding,
methodBinding,
getRange(node.getName()),
ReferenceKind.USAGE,
m_contextStack.peek());
recordReferenceToTypeArguments(methodBinding, node.typeArguments());
new QualifierVisitor(m_client, m_filePath, m_compilationUnit, false).recordQualifierOfNode(node);
}
@@ -840,6 +904,8 @@ public abstract class AstVisitor extends ASTVisitor
context.toNameHierarchy(),
getRange(node.getType()));
}
recordReferenceToTypeArguments(constructorBinding, node.typeArguments());
}
return true;
@@ -926,6 +992,32 @@ public abstract class AstVisitor extends ASTVisitor
}
}
private void recordReferenceToTypeArguments(IMethodBinding methodBinding, List typeArguments)
{
if (!typeArguments.isEmpty())
{
if (methodBinding != null)
{
// replacing type arguments of invocation with type variables of declaration
methodBinding = methodBinding.getMethodDeclaration();
}
for (Object o : typeArguments)
{
if (o instanceof Type)
{
Type type = (Type)o;
ITypeBinding typeBinding = type.resolveBinding();
m_client.recordReference(
ReferenceKind.TYPE_ARGUMENT,
BindingNameResolver.getQualifiedName(typeBinding, m_filePath, m_compilationUnit).orElse(TypeName.unsolved()).toDeclName().toNameHierarchy(),
BindingNameResolver.getQualifiedName(methodBinding, m_filePath, m_compilationUnit).orElse(DeclName.unsolved()).toNameHierarchy(),
getRange(type));
}
}
}
}
private void recordScope(Range range)
{
NameHierarchy nameHierarchy = DeclName.scope(m_filePath, range.begin).toNameHierarchy();
java_indexer/src/main/java/com/sourcetrail/ContextAwareAstVisitor.java
+26 -45
View File
@@ -11,6 +11,7 @@ import org.eclipse.jdt.core.dom.ConstructorInvocation;
import org.eclipse.jdt.core.dom.CreationReference;
import org.eclipse.jdt.core.dom.EnumConstantDeclaration;
import org.eclipse.jdt.core.dom.EnumDeclaration;
import org.eclipse.jdt.core.dom.ExpressionMethodReference;
import org.eclipse.jdt.core.dom.FieldDeclaration;
import org.eclipse.jdt.core.dom.ImportDeclaration;
import org.eclipse.jdt.core.dom.Javadoc;
@@ -133,11 +134,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
acceptChild(node.getType());
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
}
return false;
@@ -181,11 +178,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
acceptChild(node.getExpression());
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChild(node.getName());
acceptChildren(node.arguments());
}
@@ -201,11 +194,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChild(node.getName());
acceptChildren(node.arguments());
}
@@ -220,11 +209,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChildren(node.arguments());
}
@@ -239,11 +224,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
acceptChild(node.getExpression());
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChildren(node.arguments());
}
@@ -258,11 +239,23 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
}
return false;
}
@Override
public boolean visit(ExpressionMethodReference node)
{
// We don't want to visit qualifiers right now.
boolean visitChildren = super.visit(node);
if (visitChildren)
{
acceptChild(node.getExpression());
acceptChildren(node.typeArguments());
acceptChild(node.getName());
}
return false;
@@ -276,11 +269,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChild(node.getName());
}
@@ -295,11 +284,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
acceptChild(node.getName());
}
@@ -314,11 +299,7 @@ public class ContextAwareAstVisitor extends AstVisitor
if (visitChildren)
{
acceptChild(node.getExpression());
{
m_typeRefKind.push(ReferenceKind.TYPE_ARGUMENT);
acceptChildren(node.typeArguments());
m_typeRefKind.pop();
}
acceptChildren(node.typeArguments());
if (node.getAnonymousClassDeclaration() != null)
{