ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

src: clazy compiler warnings

Browse Source 
get rid of most clazy warnings (https://github.com/KDE/clazy)
* range loop use refs
* qcolor ctor with ints
* missing Q_OBJECT macro
* use .constfirst instead of .first

enabled ccache for unix systems for fasterr recompiling
* if ccache is in path we use it now
This commit is contained in:
Andreas Stallinger
2017-08-10 09:45:55 +02:00
parent bb5c1d49b6
commit 37ead804bf
97 changed files with 339 additions and 344 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/component/controller/helper/BucketLayouter.cpp
+6 -6
View File
@@ -31,7 +31,7 @@ int Bucket::getHeight() const
bool Bucket::hasNode(std::shared_ptr<DummyNode> node) const
{
for (std::shared_ptr<DummyNode> n : m_nodes)
for (const std::shared_ptr<DummyNode>& n : m_nodes)
{
if (node == n)
{
@@ -66,7 +66,7 @@ void Bucket::preLayout(Vec2i viewSize)
m_height = 0;
for (std::shared_ptr<DummyNode> node : m_nodes)
for (const std::shared_ptr<DummyNode>& node : m_nodes)
{
node->position.x = x;
node->position.y = y;
@@ -93,7 +93,7 @@ void Bucket::layout(int x, int y, int width, int height)
int cx = GraphViewStyle::toGridOffset(x + (width - m_width) / 2);
int cy = GraphViewStyle::toGridOffset(y + (height - m_height) / 2);
for (std::shared_ptr<DummyNode> node : m_nodes)
for (const std::shared_ptr<DummyNode>& node : m_nodes)
{
node->position.x = node->position.x + cx;
node->position.y = node->position.y + cy;
@@ -120,7 +120,7 @@ void BucketLayouter::createBuckets(
}
bool activeNodeAdded = false;
for (std::shared_ptr<DummyNode> node : nodes)
for (const std::shared_ptr<DummyNode>& node : nodes)
{
if (node->hasActiveSubNode() || !edges.size())
{
@@ -140,7 +140,7 @@ void BucketLayouter::createBuckets(
}
std::vector<const DummyEdge*> remainingEdges;
for (std::shared_ptr<DummyEdge> edge : edges)
for (const std::shared_ptr<DummyEdge>& edge : edges)
{
remainingEdges.push_back(edge.get());
}
@@ -264,7 +264,7 @@ std::vector<std::shared_ptr<DummyNode>> BucketLayouter::getSortedNodes()
std::shared_ptr<DummyNode> BucketLayouter::findTopMostDummyNodeRecursive(
std::vector<std::shared_ptr<DummyNode>>& nodes, Id tokenId, std::shared_ptr<DummyNode> top
){
for (std::shared_ptr<DummyNode> node : nodes)
for (const std::shared_ptr<DummyNode>& node : nodes)
{
std::shared_ptr<DummyNode> t = (top ? top : node);