ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

src: clazy compiler warnings

Browse Source 
get rid of most clazy warnings (https://github.com/KDE/clazy)
* range loop use refs
* qcolor ctor with ints
* missing Q_OBJECT macro
* use .constfirst instead of .first

enabled ccache for unix systems for fasterr recompiling
* if ccache is in path we use it now
This commit is contained in:
Andreas Stallinger
2017-08-10 09:45:55 +02:00
parent bb5c1d49b6
commit 37ead804bf
97 changed files with 339 additions and 344 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_cxx/data/parser/cxx/ASTActionFactory.cpp
+1 -4
View File
@@ -26,8 +26,5 @@ clang::FrontendAction* ASTActionFactory::create()
{
return new ASTAction<clang::PreprocessOnlyAction>(m_client, m_fileRegister, m_canonicalFilePathCache);
}
else
{
return new ASTAction<clang::ASTFrontendAction>(m_client, m_fileRegister, m_canonicalFilePathCache);
}
return new ASTAction<clang::ASTFrontendAction>(m_client, m_fileRegister, m_canonicalFilePathCache);
}
src/lib_cxx/data/parser/cxx/CxxAstVisitorComponentContext.cpp
+1 -4
View File
@@ -58,10 +58,7 @@ NameHierarchy CxxAstVisitorComponentContext::getContextName(const NameHierarchy&
{
return (*it)->getName();
}
else
{
skipped++;
}
skipped++;
}
}
return fallback;
src/lib_cxx/data/parser/cxx/name/CxxFunctionDeclName.cpp
+1 -1
View File
@@ -39,7 +39,7 @@ CxxFunctionDeclName::~CxxFunctionDeclName()
NameHierarchy CxxFunctionDeclName::toNameHierarchy() const
{
std::string signaturePrefix = "";
std::string signaturePrefix;
if (m_isStatic)
{
signaturePrefix += "static ";
src/lib_cxx/data/parser/cxx/name/CxxTypeName.cpp
+1 -1
View File
@@ -70,7 +70,7 @@ std::string CxxTypeName::toString() const
}
ret += toNameHierarchy().getQualifiedName();
for (Modifier modifier: m_modifiers)
for (const Modifier& modifier: m_modifiers)
{
ret += " " + modifier.symbol;
if (!modifier.qualifierFlags.empty())
src/lib_cxx/data/parser/cxx/name/CxxVariableDeclName.cpp
+2 -2
View File
@@ -31,14 +31,14 @@ CxxVariableDeclName::~CxxVariableDeclName()
NameHierarchy CxxVariableDeclName::toNameHierarchy() const
{
std::string signaturePrefix = "";
std::string signaturePrefix;
if (m_isStatic)
{
signaturePrefix += "static ";
}
signaturePrefix += CxxTypeName::makeUnsolvedIfNull(m_typeName)->toString();
const std::string signaturePostfix = "";
const std::string signaturePostfix;
NameHierarchy ret = CxxDeclName::toNameHierarchy();
std::shared_ptr<NameElement> nameElement = std::make_shared<NameElement>(
src/lib_cxx/data/parser/cxx/name_resolver/CxxDeclNameResolver.cpp
+7 -7
View File
@@ -123,7 +123,7 @@ std::shared_ptr<CxxDeclName> CxxDeclNameResolver::getDeclName(const clang::Named
// we skip this node because its child (the lambda call operator) has already been recorded.
return std::shared_ptr<CxxDeclName>();
}
else if (declNameString.size() == 0)
else if (declNameString.empty())
{
const clang::SourceManager& sourceManager = declaration->getASTContext().getSourceManager();
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(declaration->getLocStart());
@@ -285,7 +285,7 @@ std::shared_ptr<CxxDeclName> CxxDeclNameResolver::getDeclName(const clang::Named
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(declaration->getLocStart());
return std::make_shared<CxxDeclName>(getNameForAnonymousSymbol("namespace", presumedBegin), std::vector<std::string>());
}
else if (clang::isa<clang::EnumDecl>(declaration) && declNameString.size() == 0)
else if (clang::isa<clang::EnumDecl>(declaration) && declNameString.empty())
{
const clang::SourceManager& sourceManager = declaration->getASTContext().getSourceManager();
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(declaration->getLocStart());
@@ -296,13 +296,13 @@ std::shared_ptr<CxxDeclName> CxxDeclNameResolver::getDeclName(const clang::Named
clang::isa<clang::TemplateTypeParmDecl>(declaration) ||
clang::isa<clang::NonTypeTemplateParmDecl>(declaration) ||
clang::isa<clang::TemplateTemplateParmDecl>(declaration)
) && declNameString.size() == 0)
) && declNameString.empty())
{
const clang::SourceManager& sourceManager = declaration->getASTContext().getSourceManager();
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(declaration->getLocStart());
return std::make_shared<CxxDeclName>(getNameForAnonymousSymbol("template parameter", presumedBegin), std::vector<std::string>());
}
else if (clang::isa<clang::ParmVarDecl>(declaration) && declNameString.size() == 0)
else if (clang::isa<clang::ParmVarDecl>(declaration) && declNameString.empty())
{
const clang::SourceManager& sourceManager = declaration->getASTContext().getSourceManager();
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(declaration->getLocStart());
@@ -331,7 +331,7 @@ std::shared_ptr<CxxDeclName> CxxDeclNameResolver::getDeclName(const clang::Named
}
}
if (declNameString.size() > 0)
if (!declNameString.empty())
{
return std::make_shared<CxxDeclName>(declNameString, std::vector<std::string>(), std::shared_ptr<CxxName>());
}
@@ -355,7 +355,7 @@ std::string CxxDeclNameResolver::getNameForAnonymousSymbol(const std::string& sy
std::string CxxDeclNameResolver::getTemplateParameterString(const clang::NamedDecl* parameter)
{
std::string templateParameterTypeString = "";
std::string templateParameterTypeString;
if (parameter)
{
@@ -398,7 +398,7 @@ std::string CxxDeclNameResolver::getTemplateParameterTypeString(const clang::Non
typeNameResolver.ignoreContextDecl(m_currentDecl);
}
std::string typeString = "";
std::string typeString;
std::shared_ptr<CxxTypeName> typeName = CxxTypeName::makeUnsolvedIfNull(typeNameResolver.getName(parameter->getType()));
typeString = typeName->toString();