ui: fixed error help dialog not showing up during indexing (issue #740) (#904)

src/lib/component/controller/ErrorController.cpp

@@ -4,6 +4,7 @@
 #include "ApplicationSettings.h"
 #include "DialogView.h"
 #include "Project.h"
+#include "QtHelpButtonInfo.h"
 #include "StorageAccess.h"
 #include "TabId.h"
 
@@ -140,7 +141,7 @@ void ErrorController::handleMessage(MessageErrorsHelpMessage* message)
 	appSettings->setSeenErrorHelpMessage(true);
 	appSettings->save();
 
-	getView()->showErrorHelpMessage();
+	m_onQtThread([=]() { createErrorHelpButtonInfo().displayMessage(); });
 }
 
 void ErrorController::handleMessage(MessageIndexingFinished* message)

src/lib/component/controller/ErrorController.h

@@ -11,6 +11,7 @@
 #include "MessageIndexingStarted.h"
 #include "MessageListener.h"
 #include "MessageShowError.h"
+#include "QtThreadedFunctor.h"
 
 #include "Controller.h"
 #include "ErrorView.h"
@@ -62,6 +63,7 @@ private:
 	std::map<Id, bool> m_tabShowsErrors;
 	std::map<Id, FilePath> m_tabActiveFilePath;
 
+	QtThreadedLambdaFunctor m_onQtThread;
 	bool m_newErrorsAdded = false;
 };
 

src/lib/component/view/ErrorView.h

@@ -22,8 +22,6 @@ public:
 		const std::vector<ErrorInfo>& errors, const ErrorCountInfo& errorCount, bool scrollTo) = 0;
 	virtual void setErrorId(Id errorId) = 0;
 
-	virtual void showErrorHelpMessage() = 0;
-
 	virtual ErrorFilter getErrorFilter() const = 0;
 	virtual void setErrorFilter(const ErrorFilter& filter) = 0;
 };