ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

src: fixed some clang tidy warnings

Browse Source 
* implemented CxxDeclName constructors that just move the members
* removed empty destructors because they disable default move constructors
* removed some unnecessary code
* replaced ".size() == 0" with ".empty()" because it's more explicit
This commit is contained in:
mlangkabel
2017-12-27 18:46:56 +01:00
parent 8b21d57750
commit 4686ce7e91
42 changed files with 377 additions and 214 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_java/data/parser/java/JavaEnvironmentFactory.cpp
+1 -1
View File
@@ -34,7 +34,7 @@ void JavaEnvironmentFactory::createInstance(std::string classPath, std::string&
errorString
);
if (!createInstanceFunction && errorString.size() > 0)
if (!createInstanceFunction && !errorString.empty())
{
return;
}
src/lib_java/data/parser/java/JavaParser.cpp
+1 -1
View File
@@ -35,7 +35,7 @@ JavaParser::JavaParser(std::shared_ptr<ParserClient> client, std::shared_ptr<Fil
, m_id(s_nextParserId++)
{
const std::string errorString = utility::prepareJavaEnvironment();
if (errorString.size() > 0)
if (!errorString.empty())
{
LOG_ERROR(errorString);
}
src/lib_java/data/parser/java/JavaParser.h
+1 -1
View File
@@ -191,7 +191,7 @@ private:
jint jAccess, jint jDefinitionKind
);
void doRecordReference(jint jRefType, jstring jReferencedName, jstring jContextName, jint beginLine, jint beginColumn, jint endLine, jint endColumn);
void doRecordReference(jint jReferenceKind, jstring jReferencedName, jstring jContextName, jint beginLine, jint beginColumn, jint endLine, jint endColumn);
void doRecordQualifierLocation(jstring jQualifierName, jint beginLine, jint beginColumn, jint endLine, jint endColumn);
void doRecordLocalSymbol(jstring jSymbolName, jint beginLine, jint beginColumn, jint endLine, jint endColumn);
void doRecordComment(jint beginLine, jint beginColumn, jint endLine, jint endColumn);