build: Fixed enum forward declarations and filepath checks in SonarGraphProjectTestSuite

src/lib/project/SourceGroup.h

@@ -5,12 +5,13 @@
 #include <set>
 #include <vector>
 
+#include "settings/LanguageType.h"
+#include "settings/SourceGroupStatusType.h"
+#include "settings/SourceGroupType.h"
+
 class IndexerCommand;
 class FilePath;
 class SourceGroupSettings;
-enum LanguageType;
-enum SourceGroupStatusType;
-enum SourceGroupType;
 
 class SourceGroup
 {

src/lib/utility/sonargraph/SonargraphProject.h

@@ -5,6 +5,8 @@
 #include <memory>
 #include <vector>
 
+#include "settings/LanguageType.h"
+
 // xsdCppModule
 //	xsdCppManualModule -> basePathForIncludes(0, n), sourceFileExtensions(0, n), moduleCompilerOptions(0, n)
 //	xsdCmakeJsonModule -> rootPathWithFiles(0, n)
@@ -17,7 +19,6 @@ class FilePath;
 class IndexerCommand;
 class SourceGroupSettings;
 class TextAccess;
-enum LanguageType;
 
 namespace Sonargraph
 {
@@ -37,7 +38,7 @@ namespace Sonargraph
 		std::set<FilePath> filterToContainedFilePaths(const std::set<FilePath>& filePaths) const;
 
 		std::vector<std::shared_ptr<IndexerCommand>> getIndexerCommands(
-			std::shared_ptr<const SourceGroupSettings> sourceGroupSettings, 
+			std::shared_ptr<const SourceGroupSettings> sourceGroupSettings,
 			std::shared_ptr<const ApplicationSettings> appSettings) const;
 
 	private:

src/lib/utility/sonargraph/SonargraphSoftwareSystem.h

@@ -12,7 +12,6 @@ class ApplicationSettings;
 class IndexerCommand;
 class SourceGroupSettings;
 class TiXmlElement;
-enum LanguageType;
 
 namespace Sonargraph
 {

src/lib/utility/sonargraph/SonargraphXsdAbstractModule.h

@@ -5,13 +5,13 @@
 #include <string>
 #include <vector>
 
+#include "settings/LanguageType.h"
 #include "utility/file/FilePathFilter.h"
 
 class ApplicationSettings;
 class IndexerCommand;
 class SourceGroupSettings;
 class TiXmlElement;
-enum LanguageType;
 
 namespace Sonargraph
 {

src/lib/utility/utilityXml.cpp

@@ -15,9 +15,8 @@ namespace utility
 	{
 		std::vector<const TiXmlElement*> elements;
 
-		const TiXmlElement* child = parentElement->FirstChildElement(elementName.c_str());
-
-		for (child; child; child = child->NextSiblingElement(elementName.c_str()))
+		for (const TiXmlElement* child = parentElement->FirstChildElement(elementName.c_str());
+				child; child = child->NextSiblingElement(elementName.c_str()))
 		{
 			elements.push_back(child);
 		}
@@ -29,9 +28,8 @@ namespace utility
 	{
 		std::vector<const TiXmlElement*> elements;
 
-		const TiXmlElement* child = parentElement->FirstChildElement();
-	
-		for (child; child; child = child->NextSiblingElement())
+		for (const TiXmlElement* child = parentElement->FirstChildElement();
+				child; child = child->NextSiblingElement())
 		{
 			const char* value = child->Attribute(attributeName.c_str());
 			if (value != nullptr && value == attributeValue)