logic: removed FilterUndefinedNodesFromGraph setting

because it is confusing and not necessary anymore since we have bundled nodes.

bin/app/data/ApplicationSettings_template.xml

@@ -9,8 +9,6 @@
 <config>
 	<StartupProject><!-- STRING: path to project settings xml file --></StartupProject>
 
-	<FilterUndefinedNodesFromGraph><!-- BOOL: filter out undefined nodes in graph --></FilterUndefinedNodesFromGraph>
-
 	<source>
 		<CompilerFlags>
 			<CompilerFlag><!-- STRING: compiler flag, including the dash e.g. -v --></CompilerFlag>

src/lib/data/Storage.cpp

@@ -867,32 +867,6 @@ std::shared_ptr<Graph> Storage::getGraphForActiveTokenIds(const std::vector<Id>&
 		}
 	}
 
-	if (ApplicationSettings::getInstance()->filterUndefinedNodesFromGraph())
-	{
-		bool allUndefined = true;
-		Node::NodeTypeMask undefinedMask =
-			Node::NODE_UNDEFINED | Node::NODE_UNDEFINED_TYPE |
-			Node::NODE_UNDEFINED_VARIABLE | Node::NODE_UNDEFINED_FUNCTION;
-		for (Id tokenId : tokenIds)
-		{
-			Token* token = m_graph.getTokenById(tokenId);
-			if (token && token->isNode() && !dynamic_cast<Node*>(token)->isType(undefinedMask))
-			{
-				allUndefined = false;
-				break;
-			}
-		}
-
-		if (!allUndefined)
-		{
-			QueryTree tree("!'undefined'");
-			std::shared_ptr<Graph> outGraph = std::make_shared<Graph>();
-
-			GraphFilterConductor().filter(&tree, graph.get(), outGraph.get());
-			return outGraph;
-		}
-	}
-
 	return graph;
 }
 

src/lib/settings/ApplicationSettings.cpp

@@ -21,11 +21,6 @@ std::string ApplicationSettings::getStartupProjectFilePath() const
 	return getValue<std::string>("StartupProject", "");
 }
 
-bool ApplicationSettings::filterUndefinedNodesFromGraph() const
-{
-	return getValue<bool>("FilterUndefinedNodesFromGraph", false);
-}
-
 std::string ApplicationSettings::getFontName() const
 {
 	return getValue<std::string>("application/font_name", "Source Code Pro");

src/lib/settings/ApplicationSettings.h

@@ -13,7 +13,6 @@ public:
 	~ApplicationSettings();
 
 	std::string getStartupProjectFilePath() const;
-	bool filterUndefinedNodesFromGraph() const;
 
 	// application
 	std::string getFontName() const;