From 872d24bf6a18a8ece7aaf855075b5df60b5bb049 Mon Sep 17 00:00:00 2001 From: Eberhard Graether Date: Fri, 27 Apr 2018 13:22:40 +0200 Subject: [PATCH] ui: Fixed single code view is scrollalbe below last line and scroll request show the wrong line --- src/lib_gui/qt/element/QtCodeFileSingle.cpp | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/lib_gui/qt/element/QtCodeFileSingle.cpp b/src/lib_gui/qt/element/QtCodeFileSingle.cpp index 89e0fcfb..8a2e1816 100644 --- a/src/lib_gui/qt/element/QtCodeFileSingle.cpp +++ b/src/lib_gui/qt/element/QtCodeFileSingle.cpp @@ -195,20 +195,6 @@ bool QtCodeFileSingle::requestScroll( double percentA = double(lineNumber - 1) / m_area->getEndLineNumber(); double percentB = endLineNumber ? double(endLineNumber - 1) / m_area->getEndLineNumber() : 0.0f; - - // fix percentages wrong when code area is scrollable beyond last line due to some unknown bug - { - int totalHeight = m_area->sizeHint().height(); - int totalLineHeight = m_area->totalLineHeight(); - - if (std::abs(totalHeight - totalLineHeight) > 100) - { - double factor = totalLineHeight / double(totalHeight); - percentA *= factor; - percentB *= factor; - } - } - ensurePercentVisibleAnimated(percentA, percentB, animated, target); m_scrollRequested = true; @@ -344,6 +330,9 @@ void QtCodeFileSingle::setFileData(const FileData& file) titleButton->show(); m_area->show(); + // Resizes the area to fix a bug where the area could be scrolled below the last line. + m_area->updateGeometry(); + m_scrollRequested = false; } else