build: clang warning cleanup

* unused member in undoredocontroller
* int - size_t comparion
* virtual destructor ASTVisitor added
* braces when && and || in same if
* 1 warning left: isNamedDeclUnnamed in ASTVisitor is unused
This commit is contained in:
Andreas Stallinger
2016-03-03 20:16:20 +01:00
parent 8b4b4bb027
commit 8f1326e02a
6 changed files with 8 additions and 10 deletions
@@ -115,8 +115,8 @@ void FeatureController::handleMessage(MessageZoom* message)
int maxSize = settings->getFontSizeMax();
int minSize = settings->getFontSizeMin();
if (fontSize >= maxSize && zoomIn
|| fontSize <= minSize && !zoomIn)
if ((fontSize >= maxSize && zoomIn)
|| (fontSize <= minSize && !zoomIn))
{
return;
}
@@ -9,7 +9,6 @@
UndoRedoController::UndoRedoController(StorageAccess* storageAccess)
: m_activationTranslator(storageAccess)
, m_storageAccess(storageAccess)
, m_lastCommand(nullptr, 0)
{
}
@@ -93,7 +93,6 @@ private:
bool checkCommandCausesTokenActivation(const Command& command) const;
ActivationTranslator m_activationTranslator;
StorageAccess* m_storageAccess;
Command m_lastCommand;