From c93d5aa9f08e7e2d088113fd39136ac8376b4539 Mon Sep 17 00:00:00 2001 From: malte_langkabel Date: Fri, 5 May 2017 11:37:25 +0200 Subject: [PATCH] ui: add dialog to warn about active "verbose indexer logging" on refresh * also featuring: remove unnecessary call in ParserClientImpl --- src/lib/data/parser/ParserClientImpl.cpp | 1 - src/lib/project/Project.cpp | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/lib/data/parser/ParserClientImpl.cpp b/src/lib/data/parser/ParserClientImpl.cpp index 154558f8..2417563f 100644 --- a/src/lib/data/parser/ParserClientImpl.cpp +++ b/src/lib/data/parser/ParserClientImpl.cpp @@ -90,7 +90,6 @@ void ParserClientImpl::onFileParsed(const FileInfo& fileInfo) void ParserClientImpl::onCommentParsed(const ParseLocation& location) { - addNodeHierarchy(NameHierarchy(location.filePath.str()), Node::NODE_FILE); addCommentLocation(location); } diff --git a/src/lib/project/Project.cpp b/src/lib/project/Project.cpp index 8d950112..366a9233 100644 --- a/src/lib/project/Project.cpp +++ b/src/lib/project/Project.cpp @@ -104,6 +104,28 @@ bool Project::refresh(bool forceRefresh) std::shared_ptr dialogView = Application::getInstance()->getDialogView(); + if ( + ApplicationSettings::getInstance()->getLoggingEnabled() && + ApplicationSettings::getInstance()->getVerboseIndexerLoggingEnabled() && + Application::getInstance()->hasGUI() + ) + { + std::vector options; + options.push_back("Yes"); + options.push_back("No"); + int result = dialogView->confirm( + "Warning: You are about to index your project with the \"verbose indexer logging\" setting " + "enabled. This will cause a significant slowdown in indexing performance. Do you want to proceed?", + options + ); + + if (result == 1) + { + return false; + } + } + + if (!forceRefresh && needsFullRefresh && question.size() && Application::getInstance()->hasGUI()) { std::vector options;