src: Reviewed old files touched by bookmarks commit

* Removed some unused changes
* Disabled "No IDE connected" message in status bar
* Use threaded functor in status bar view

src/lib/data/IntermediateStorage.cpp

@@ -167,13 +167,6 @@ void IntermediateStorage::addError(const std::string& message, const FilePath& f
 	));
 }
 
-Id IntermediateStorage::addBookmark(const Bookmark& bookmark)
-{
-	m_bookmarks.push_back(bookmark);
-
-	return -1;
-}
-
 void IntermediateStorage::forEachNode(std::function<void(const Id /*id*/, const StorageNode& /*data*/)> callback) const
 {
 	for (std::map<Id, std::shared_ptr<StorageNode>>::const_iterator it = m_nodeIdsToData.begin(); it != m_nodeIdsToData.end(); it++)

src/lib/data/IntermediateStorage.h

@@ -27,7 +27,6 @@ public:
 	virtual void addComponentAccess(Id nodeId , int type);
 	virtual void addCommentLocation(Id fileNodeId, uint startLine, uint startCol, uint endLine, uint endCol);
 	virtual void addError(const std::string& message, const FilePath& filePath, uint startLine, uint startCol, bool fatal, bool indexed);
-	virtual Id addBookmark(const Bookmark& bookmark);
 
 	virtual void forEachNode(std::function<void(const Id /*id*/, const StorageNode& /*data*/)> callback) const;
 	virtual void forEachFile(std::function<void(const StorageFile& /*data*/)> callback) const;
@@ -66,7 +65,6 @@ private:
 	std::vector<StorageComponentAccess> m_componentAccesses;
 	std::vector<StorageCommentLocation> m_commentLocations;
 	std::vector<StorageError> m_errors;
-	std::vector<Bookmark> m_bookmarks;
 
 	Id m_nextId;
 };

src/lib/data/Storage.h

@@ -5,7 +5,6 @@
 #include <mutex>
 #include <string>
 
-#include "data/bookmark/Bookmark.h"
 #include "data/name/NameHierarchy.h"
 #include "data/StorageTypes.h"
 #include "utility/types.h"