ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix all clazy qstring-allocation warnings (#903)

Browse Source
This commit is contained in:
Waqar Ahmed
2020-01-29 19:48:35 +01:00
committed by GitHub
parent 9d26104d2f
commit ecaf25ead6
85 changed files with 853 additions and 840 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_gui/qt/element/code/QtCodeField.cpp
+5 -5
View File
@@ -40,7 +40,7 @@ QtCodeField::QtCodeField(
{
TRACE();
setObjectName("code_area");
setObjectName(QStringLiteral("code_area"));
setReadOnly(true);
setFrameStyle(QFrame::NoFrame);
setLineWrapMode(QPlainTextEdit::NoWrap);
@@ -96,9 +96,9 @@ QtCodeField::QtCodeField(
setFont(font);
setTabStopWidth(appSettings->getCodeTabWidth() * fontMetrics().width('9'));
m_openInTabAction = new QAction("Open in New Tab", this);
m_openInTabAction->setStatusTip("Opens the node in a new tab");
m_openInTabAction->setToolTip("Opens the node in a new tab");
m_openInTabAction = new QAction(QStringLiteral("Open in New Tab"), this);
m_openInTabAction->setStatusTip(QStringLiteral("Opens the node in a new tab"));
m_openInTabAction->setToolTip(QStringLiteral("Opens the node in a new tab"));
m_openInTabAction->setEnabled(false);
connect(m_openInTabAction, &QAction::triggered, this, &QtCodeField::openInTab);
}
@@ -771,7 +771,7 @@ void QtCodeField::createMultibyteCharacterLocationCache(const QString& code)
QTextCodec* codec = QTextCodec::codecForName(
ApplicationSettings::getInstance()->getTextEncoding().c_str());
for (const QString& line: code.split("\n"))
for (const QString& line: code.split(QStringLiteral("\n")))
{
std::vector<std::pair<int, int>> columnsToOffsets;
for (int i = 0; i < line.size(); i++)