ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix all clazy qstring-allocation warnings (#903)

Browse Source
This commit is contained in:
Waqar Ahmed
2020-01-29 19:48:35 +01:00
committed by GitHub
parent 9d26104d2f
commit ecaf25ead6
85 changed files with 853 additions and 840 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib_gui/qt/window/QtKeyboardShortcuts.cpp
+68 -68
View File
@@ -38,8 +38,8 @@ void QtKeyboardShortcuts::populateWindow(QWidget* widget)
QVBoxLayout* layout = new QVBoxLayout(widget);
QLabel* generelLabel = new QLabel(this);
generelLabel->setObjectName("general_label");
generelLabel->setText("General Shortcuts");
generelLabel->setObjectName(QStringLiteral("general_label"));
generelLabel->setText(QStringLiteral("General Shortcuts"));
layout->addWidget(generelLabel);
layout->addWidget(createGenerelShortcutsTable());
@@ -47,8 +47,8 @@ void QtKeyboardShortcuts::populateWindow(QWidget* widget)
layout->addSpacing(20);
QLabel* codeLabel = new QLabel(this);
codeLabel->setObjectName("code_label");
codeLabel->setText("Code View Shortcuts");
codeLabel->setObjectName(QStringLiteral("code_label"));
codeLabel->setText(QStringLiteral("Code View Shortcuts"));
layout->addWidget(codeLabel);
layout->addWidget(createCodeViewShortcutsTable());
@@ -56,8 +56,8 @@ void QtKeyboardShortcuts::populateWindow(QWidget* widget)
layout->addSpacing(20);
QLabel* graphLabel = new QLabel(this);
graphLabel->setObjectName("graph_label");
graphLabel->setText("Graph View Shortcuts");
graphLabel->setObjectName(QStringLiteral("graph_label"));
graphLabel->setText(QStringLiteral("Graph View Shortcuts"));
layout->addWidget(graphLabel);
layout->addWidget(createGraphViewShortcutsTable());
@@ -71,8 +71,8 @@ void QtKeyboardShortcuts::populateWindow(QWidget* widget)
void QtKeyboardShortcuts::windowReady()
{
updateTitle("Keyboard Shortcuts");
updateCloseButton("Close");
updateTitle(QStringLiteral("Keyboard Shortcuts"));
updateCloseButton(QStringLiteral("Close"));
setNextVisible(false);
setPreviousVisible(false);
@@ -98,8 +98,8 @@ QtShortcutTable* QtKeyboardShortcuts::createTableWidget(const std::string& objec
table->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
table->setColumnCount(2);
table->setHorizontalHeaderItem(0, new QTableWidgetItem("Command"));
table->setHorizontalHeaderItem(1, new QTableWidgetItem("Shortcut"));
table->setHorizontalHeaderItem(0, new QTableWidgetItem(QStringLiteral("Command")));
table->setHorizontalHeaderItem(1, new QTableWidgetItem(QStringLiteral("Shortcut")));
return table;
}
@@ -110,24 +110,24 @@ QTableWidget* QtKeyboardShortcuts::createGenerelShortcutsTable()
table->setRowCount(17);
table->setItem(0, 0, new QTableWidgetItem("Larger Font"));
table->setItem(1, 0, new QTableWidgetItem("Smaller Font"));
table->setItem(2, 0, new QTableWidgetItem("Reset Font Size"));
table->setItem(3, 0, new QTableWidgetItem("Back"));
table->setItem(4, 0, new QTableWidgetItem("Forward"));
table->setItem(5, 0, new QTableWidgetItem("Refresh"));
table->setItem(6, 0, new QTableWidgetItem("Full Refresh"));
table->setItem(7, 0, new QTableWidgetItem("Find Symbol"));
table->setItem(8, 0, new QTableWidgetItem("Find Text"));
table->setItem(9, 0, new QTableWidgetItem("Find On-Screen"));
table->setItem(10, 0, new QTableWidgetItem("New Project"));
table->setItem(11, 0, new QTableWidgetItem("Open Project"));
table->setItem(12, 0, new QTableWidgetItem("Close Window"));
table->setItem(13, 0, new QTableWidgetItem("Hide Window"));
table->setItem(14, 0, new QTableWidgetItem("To Overview"));
table->setItem(15, 0, new QTableWidgetItem("Preferences"));
table->setItem(16, 0, new QTableWidgetItem("Bookmark Active Symbol"));
table->setItem(17, 0, new QTableWidgetItem("Bookmark Manager"));
table->setItem(0, 0, new QTableWidgetItem(QStringLiteral("Larger Font")));
table->setItem(1, 0, new QTableWidgetItem(QStringLiteral("Smaller Font")));
table->setItem(2, 0, new QTableWidgetItem(QStringLiteral("Reset Font Size")));
table->setItem(3, 0, new QTableWidgetItem(QStringLiteral("Back")));
table->setItem(4, 0, new QTableWidgetItem(QStringLiteral("Forward")));
table->setItem(5, 0, new QTableWidgetItem(QStringLiteral("Refresh")));
table->setItem(6, 0, new QTableWidgetItem(QStringLiteral("Full Refresh")));
table->setItem(7, 0, new QTableWidgetItem(QStringLiteral("Find Symbol")));
table->setItem(8, 0, new QTableWidgetItem(QStringLiteral("Find Text")));
table->setItem(9, 0, new QTableWidgetItem(QStringLiteral("Find On-Screen")));
table->setItem(10, 0, new QTableWidgetItem(QStringLiteral("New Project")));
table->setItem(11, 0, new QTableWidgetItem(QStringLiteral("Open Project")));
table->setItem(12, 0, new QTableWidgetItem(QStringLiteral("Close Window")));
table->setItem(13, 0, new QTableWidgetItem(QStringLiteral("Hide Window")));
table->setItem(14, 0, new QTableWidgetItem(QStringLiteral("To Overview")));
table->setItem(15, 0, new QTableWidgetItem(QStringLiteral("Preferences")));
table->setItem(16, 0, new QTableWidgetItem(QStringLiteral("Bookmark Active Symbol")));
table->setItem(17, 0, new QTableWidgetItem(QStringLiteral("Bookmark Manager")));
#if defined(Q_OS_MAC)
table->setItem(0, 1, new QTableWidgetItem("Cmd + +"));
@@ -149,28 +149,28 @@ QTableWidget* QtKeyboardShortcuts::createGenerelShortcutsTable()
table->setItem(16, 1, new QTableWidgetItem("Cmd + S"));
table->setItem(17, 1, new QTableWidgetItem("Cmd + B"));
#else
table->setItem(0, 1, new QTableWidgetItem("Ctrl + +"));
table->setItem(1, 1, new QTableWidgetItem("Ctrl + -"));
table->setItem(2, 1, new QTableWidgetItem("Ctrl + 0"));
table->setItem(3, 1, new QTableWidgetItem("Ctrl + Z | Backspace"));
table->setItem(4, 1, new QTableWidgetItem("Ctrl + Shift + Z"));
table->setItem(5, 1, new QTableWidgetItem("F5"));
table->setItem(6, 1, new QTableWidgetItem("Shift + F5"));
table->setItem(7, 1, new QTableWidgetItem("Ctrl + F"));
table->setItem(8, 1, new QTableWidgetItem("Ctrl + Shift + F"));
table->setItem(9, 1, new QTableWidgetItem("Ctrl + D | /"));
table->setItem(10, 1, new QTableWidgetItem("Ctrl + N"));
table->setItem(11, 1, new QTableWidgetItem("Ctrl + O"));
table->setItem(0, 1, new QTableWidgetItem(QStringLiteral("Ctrl + +")));
table->setItem(1, 1, new QTableWidgetItem(QStringLiteral("Ctrl + -")));
table->setItem(2, 1, new QTableWidgetItem(QStringLiteral("Ctrl + 0")));
table->setItem(3, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Z | Backspace")));
table->setItem(4, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Shift + Z")));
table->setItem(5, 1, new QTableWidgetItem(QStringLiteral("F5")));
table->setItem(6, 1, new QTableWidgetItem(QStringLiteral("Shift + F5")));
table->setItem(7, 1, new QTableWidgetItem(QStringLiteral("Ctrl + F")));
table->setItem(8, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Shift + F")));
table->setItem(9, 1, new QTableWidgetItem(QStringLiteral("Ctrl + D | /")));
table->setItem(10, 1, new QTableWidgetItem(QStringLiteral("Ctrl + N")));
table->setItem(11, 1, new QTableWidgetItem(QStringLiteral("Ctrl + O")));
# if defined(Q_OS_WIN32)
table->setItem(12, 1, new QTableWidgetItem("Alt + F4"));
# else
table->setItem(12, 1, new QTableWidgetItem("Ctrl + W"));
table->setItem(12, 1, new QTableWidgetItem(QStringLiteral("Ctrl + W")));
# endif
table->setItem(13, 1, new QTableWidgetItem(""));
table->setItem(14, 1, new QTableWidgetItem("Ctrl + Home"));
table->setItem(15, 1, new QTableWidgetItem("Ctrl + ,"));
table->setItem(16, 1, new QTableWidgetItem("Ctrl + S"));
table->setItem(17, 1, new QTableWidgetItem("Ctrl + B"));
table->setItem(13, 1, new QTableWidgetItem(QLatin1String("")));
table->setItem(14, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Home")));
table->setItem(15, 1, new QTableWidgetItem(QStringLiteral("Ctrl + ,")));
table->setItem(16, 1, new QTableWidgetItem(QStringLiteral("Ctrl + S")));
table->setItem(17, 1, new QTableWidgetItem(QStringLiteral("Ctrl + B")));
#endif
table->updateSize();
@@ -183,10 +183,10 @@ QTableWidget* QtKeyboardShortcuts::createCodeViewShortcutsTable()
QtShortcutTable* table = createTableWidget("table_code");
table->setRowCount(4);
table->setItem(0, 0, new QTableWidgetItem("Next Reference"));
table->setItem(1, 0, new QTableWidgetItem("Previous Reference"));
table->setItem(2, 0, new QTableWidgetItem("Next Local Reference"));
table->setItem(3, 0, new QTableWidgetItem("Previous Local Reference"));
table->setItem(0, 0, new QTableWidgetItem(QStringLiteral("Next Reference")));
table->setItem(1, 0, new QTableWidgetItem(QStringLiteral("Previous Reference")));
table->setItem(2, 0, new QTableWidgetItem(QStringLiteral("Next Local Reference")));
table->setItem(3, 0, new QTableWidgetItem(QStringLiteral("Previous Local Reference")));
#if defined(Q_OS_MAC)
table->setItem(0, 1, new QTableWidgetItem("Cmd + G"));
@@ -194,10 +194,10 @@ QTableWidget* QtKeyboardShortcuts::createCodeViewShortcutsTable()
table->setItem(2, 1, new QTableWidgetItem("Cmd + T"));
table->setItem(3, 1, new QTableWidgetItem("Cmd + Shift + T"));
#else
table->setItem(0, 1, new QTableWidgetItem("Ctrl + G"));
table->setItem(1, 1, new QTableWidgetItem("Ctrl + Shift + G"));
table->setItem(2, 1, new QTableWidgetItem("Ctrl + T"));
table->setItem(3, 1, new QTableWidgetItem("Ctrl + Shift + T"));
table->setItem(0, 1, new QTableWidgetItem(QStringLiteral("Ctrl + G")));
table->setItem(1, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Shift + G")));
table->setItem(2, 1, new QTableWidgetItem(QStringLiteral("Ctrl + T")));
table->setItem(3, 1, new QTableWidgetItem(QStringLiteral("Ctrl + Shift + T")));
#endif
table->updateSize();
@@ -210,26 +210,26 @@ QTableWidget* QtKeyboardShortcuts::createGraphViewShortcutsTable()
QtShortcutTable* table = createTableWidget("table_graph");
table->setRowCount(7);
table->setItem(0, 0, new QTableWidgetItem("Pan left"));
table->setItem(1, 0, new QTableWidgetItem("Pan right"));
table->setItem(2, 0, new QTableWidgetItem("Pan up"));
table->setItem(3, 0, new QTableWidgetItem("Pan down"));
table->setItem(4, 0, new QTableWidgetItem("Zoom in"));
table->setItem(5, 0, new QTableWidgetItem("Zoom out"));
table->setItem(6, 0, new QTableWidgetItem("Reset Zoom"));
table->setItem(0, 0, new QTableWidgetItem(QStringLiteral("Pan left")));
table->setItem(1, 0, new QTableWidgetItem(QStringLiteral("Pan right")));
table->setItem(2, 0, new QTableWidgetItem(QStringLiteral("Pan up")));
table->setItem(3, 0, new QTableWidgetItem(QStringLiteral("Pan down")));
table->setItem(4, 0, new QTableWidgetItem(QStringLiteral("Zoom in")));
table->setItem(5, 0, new QTableWidgetItem(QStringLiteral("Zoom out")));
table->setItem(6, 0, new QTableWidgetItem(QStringLiteral("Reset Zoom")));
table->setItem(0, 1, new QTableWidgetItem("A"));
table->setItem(1, 1, new QTableWidgetItem("D"));
table->setItem(2, 1, new QTableWidgetItem("W"));
table->setItem(3, 1, new QTableWidgetItem("S"));
table->setItem(0, 1, new QTableWidgetItem(QStringLiteral("A")));
table->setItem(1, 1, new QTableWidgetItem(QStringLiteral("D")));
table->setItem(2, 1, new QTableWidgetItem(QStringLiteral("W")));
table->setItem(3, 1, new QTableWidgetItem(QStringLiteral("S")));
#if defined(Q_OS_MAC)
table->setItem(4, 1, new QTableWidgetItem("Shift + W | Cmd + Mousewheel up"));
table->setItem(5, 1, new QTableWidgetItem("Shift + S | Cmd + Mousewheel down"));
#else
table->setItem(4, 1, new QTableWidgetItem("Shift + W | Ctrl + Mousewheel up"));
table->setItem(5, 1, new QTableWidgetItem("Shift + S | Ctrl + Mousewheel down"));
table->setItem(4, 1, new QTableWidgetItem(QStringLiteral("Shift + W | Ctrl + Mousewheel up")));
table->setItem(5, 1, new QTableWidgetItem(QStringLiteral("Shift + S | Ctrl + Mousewheel down")));
#endif
table->setItem(6, 1, new QTableWidgetItem("0"));
table->setItem(6, 1, new QTableWidgetItem(QStringLiteral("0")));
table->updateSize();