ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

build: fix compiler and cmake warnings

Browse Source 
added missing virtual destructor
fixed a warning in token.h: expression with side effects will be evaluated despite being used as an operand to 'typeid'
CMP00043 Cmake warning
added missing override keyword
This commit is contained in:
Andreas Stallinger
2015-08-18 14:43:32 +02:00
parent d8489c0b04
commit fb877e1304
11 changed files with 36 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/data/graph/Token.h
+4 -2
View File
@@ -56,7 +56,8 @@ ComponentType* Token::getComponent() const
{
for (std::shared_ptr<TokenComponent> component: m_components)
{
if (typeid(ComponentType) == typeid(*(component.get())))
TokenComponent* componentPtr = component.get();
if (typeid(ComponentType) == typeid(*componentPtr))
{
return dynamic_cast<ComponentType*>(component.get());
}
@@ -70,7 +71,8 @@ std::shared_ptr<ComponentType> Token::removeComponent()
for (size_t i = 0; i < m_components.size(); i++)
{
std::shared_ptr<TokenComponent> component = m_components[i];
if (typeid(ComponentType) == typeid(*(component.get())))
TokenComponent* componentPtr = component.get();
if (typeid(ComponentType) == typeid(*componentPtr))
{
m_components.erase(m_components.begin() + i);
return std::dynamic_pointer_cast<ComponentType>(component);