ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-08 22:13:26 +09:00
Code Issues Projects Releases Wiki Activity

test(e2e): fix race in pdf file render test (#38380) (#38381)

Browse Source 
Backport #38380 by @silverwind

`data-render-name` is set before the plugin's async render runs, so
measuring the container height right after the attribute appears can
observe the pre-render 48px height when the `pdfobject` chunk loads
slowly (flaked in CI). Poll for the height instead, like the asciicast
test in the same file does.

Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
Giteabot
2026-07-09 13:57:50 +00:00
committed by GitHub
co-authored by silverwind
parent fc4eac390a
commit 04a26f40a0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/file-view-render.test.ts
+1 -1
View File
@@ -35,7 +35,7 @@ test('pdf file', async ({page, request}) => {
await page.goto(`/${owner}/${repoName}/src/branch/main/test.pdf`); await page.goto(`/${owner}/${repoName}/src/branch/main/test.pdf`);
const container = page.locator('.file-view-render-container'); const container = page.locator('.file-view-render-container');
await expect(container).toHaveAttribute('data-render-name', 'pdf-viewer'); await expect(container).toHaveAttribute('data-render-name', 'pdf-viewer');
expect((await container.boundingBox())!.height).toBeGreaterThan(300); await expect.poll(async () => (await container.boundingBox())!.height).toBeGreaterThan(300);
await assertFlushWithParent(container, page.locator('.file-view')); await assertFlushWithParent(container, page.locator('.file-view'));
}); });