chore: fix system users (#39299)

services/auth/reverseproxy.go

@@ -173,7 +173,7 @@ func (r *ReverseProxy) newUser(req *http.Request) *user_model.User {
 		return nil
 	}
 
-	audit.RecordAs(req.Context(), user_model.NewAuthenticationSourceUser(), audit_model.UserCreate, user)
+	audit.RecordAs(req.Context(), user_model.NewAuthSourceUser(), audit_model.UserCreate, user)
 
 	return user
 }

services/auth/source/ldap/source_authenticate.go

@@ -23,7 +23,7 @@ import (
 // Authenticate queries if login/password is valid against the LDAP directory pool,
 // and create a local user if success when enabled.
 func (source *Source) Authenticate(ctx context.Context, user *user_model.User, userName, password string) (*user_model.User, error) {
-	ctx = audit.WithDoer(ctx, user_model.NewAuthenticationSourceUser())
+	ctx = audit.WithDoer(ctx, user_model.NewAuthSourceUser())
 
 	loginName := userName
 	if user != nil {

services/auth/source/ldap/source_sync.go

@@ -28,7 +28,7 @@ func (source *Source) Sync(ctx context.Context, updateExisting bool) error {
 
 	// everything this sync changes is attributed to the authentication source,
 	// not to a signed-in user
-	ctx = audit.WithDoer(ctx, user_model.NewAuthenticationSourceUser())
+	ctx = audit.WithDoer(ctx, user_model.NewAuthSourceUser())
 
 	isAttributeSSHPublicKeySet := strings.TrimSpace(source.AttributeSSHPublicKey) != ""
 	var sshKeysNeedUpdate bool

services/auth/source/pam/source_authenticate.go

@@ -68,7 +68,7 @@ func (source *Source) Authenticate(ctx context.Context, user *user_model.User, u
 		return user, err
 	}
 
-	audit.RecordAs(ctx, user_model.NewAuthenticationSourceUser(), audit_model.UserCreate, user)
+	audit.RecordAs(ctx, user_model.NewAuthSourceUser(), audit_model.UserCreate, user)
 
 	return user, nil
 }

services/auth/source/smtp/source_authenticate.go

@@ -85,7 +85,7 @@ func (source *Source) Authenticate(ctx context.Context, user *user_model.User, u
 		return user, err
 	}
 
-	audit.RecordAs(ctx, user_model.NewAuthenticationSourceUser(), audit_model.UserCreate, user)
+	audit.RecordAs(ctx, user_model.NewAuthSourceUser(), audit_model.UserCreate, user)
 
 	return user, nil
 }

services/auth/source/source_group_sync.go

@@ -33,7 +33,7 @@ func SyncGroupsToTeams(ctx context.Context, user *user_model.User, sourceUserGro
 // SyncGroupsToTeamsCached maps authentication source groups to organization and team memberships
 func SyncGroupsToTeamsCached(ctx context.Context, user *user_model.User, sourceUserGroups container.Set[string], sourceGroupTeamMapping map[string]map[string][]string, performRemoval bool, orgCache map[string]*organization.Organization, teamCache map[string]*organization.Team) error {
 	// team membership changes here come from the authentication source mapping
-	ctx = audit.WithDoer(ctx, user_model.NewAuthenticationSourceUser())
+	ctx = audit.WithDoer(ctx, user_model.NewAuthSourceUser())
 
 	membershipsToAdd, membershipsToRemove := resolveMappedMemberships(sourceUserGroups, sourceGroupTeamMapping)
 

services/auth/sspi.go

@@ -173,7 +173,7 @@ func (s *SSPI) newUser(ctx context.Context, username string, cfg *sspi.Source) (
 		return nil, err
 	}
 
-	audit.RecordAs(ctx, user_model.NewAuthenticationSourceUser(), audit_model.UserCreate, user)
+	audit.RecordAs(ctx, user_model.NewAuthSourceUser(), audit_model.UserCreate, user)
 
 	return user, nil
 }

services/lfs/server.go

@@ -598,7 +598,7 @@ func handleLFSToken(ctx stdCtx.Context, tokenSHA string, target *repo_model.Repo
 		return nil, errors.New("invalid token claim")
 	}
 
-	u, err := user_model.GetDoerUser(ctx, claims.UserID, claims.UserExtDoerData)
+	u, err := user_model.GetDoerPermissionUser(ctx, claims.UserID, claims.UserExtDoerData)
 	if err != nil {
 		log.Error("Unable to GetDoerUser[%d]: Error: %v", claims.UserID, err)
 		return nil, err