mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-16 01:43:24 +09:00
fix(packages): restrict/limited/token-scope access (#39041, #39043, #39044, #39047, #39046) (#39058)
This commit is contained in:
@@ -91,6 +91,14 @@ func (org *Organization) IsOwnedBy(ctx context.Context, uid int64) (bool, error)
|
|||||||
return IsOrganizationOwner(ctx, org.ID, uid)
|
return IsOrganizationOwner(ctx, org.ID, uid)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// CanChangeRepoTeamAccess reports whether a repository administrator can change team access.
|
||||||
|
func (org *Organization) CanChangeRepoTeamAccess(ctx context.Context, doer *user_model.User) (bool, error) {
|
||||||
|
if org.RepoAdminChangeTeamAccess || doer.IsAdmin {
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
return org.IsOwnedBy(ctx, doer.ID)
|
||||||
|
}
|
||||||
|
|
||||||
// IsOrgAdmin returns true if given user is in the owner team or an admin team.
|
// IsOrgAdmin returns true if given user is in the owner team or an admin team.
|
||||||
func (org *Organization) IsOrgAdmin(ctx context.Context, uid int64) (bool, error) {
|
func (org *Organization) IsOrgAdmin(ctx context.Context, uid int64) (bool, error) {
|
||||||
return IsOrganizationAdmin(ctx, org.ID, uid)
|
return IsOrganizationAdmin(ctx, org.ID, uid)
|
||||||
|
|||||||
@@ -89,6 +89,9 @@ func DoerViewOtherVisibility(doer, other *user_model.User) structs.VisibleType {
|
|||||||
if doer.IsAdmin || doer.ID == other.ID {
|
if doer.IsAdmin || doer.ID == other.ID {
|
||||||
return structs.VisibleTypePrivate
|
return structs.VisibleTypePrivate
|
||||||
}
|
}
|
||||||
|
if doer.IsRestricted {
|
||||||
|
return structs.VisibleTypePublic
|
||||||
|
}
|
||||||
return structs.VisibleTypeLimited
|
return structs.VisibleTypeLimited
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -77,8 +77,14 @@ func testLoadOrgListTeams(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func testDoerViewOtherVisibility(t *testing.T) {
|
func testDoerViewOtherVisibility(t *testing.T) {
|
||||||
|
viewer := &user_model.User{ID: 1}
|
||||||
|
other := &user_model.User{ID: 2}
|
||||||
|
restrictedViewer := &user_model.User{ID: 3, IsRestricted: true}
|
||||||
|
|
||||||
assert.Equal(t, structs.VisibleTypePublic, organization.DoerViewOtherVisibility(nil, nil))
|
assert.Equal(t, structs.VisibleTypePublic, organization.DoerViewOtherVisibility(nil, nil))
|
||||||
assert.Equal(t, structs.VisibleTypeLimited, organization.DoerViewOtherVisibility(&user_model.User{ID: 1}, &user_model.User{ID: 2}))
|
assert.Equal(t, structs.VisibleTypeLimited, organization.DoerViewOtherVisibility(viewer, other))
|
||||||
assert.Equal(t, structs.VisibleTypePrivate, organization.DoerViewOtherVisibility(&user_model.User{ID: 1}, &user_model.User{ID: 1}))
|
assert.Equal(t, structs.VisibleTypePublic, organization.DoerViewOtherVisibility(restrictedViewer, other))
|
||||||
assert.Equal(t, structs.VisibleTypePrivate, organization.DoerViewOtherVisibility(&user_model.User{ID: 1, IsAdmin: true}, &user_model.User{ID: 2}))
|
assert.Equal(t, structs.VisibleTypePrivate, organization.DoerViewOtherVisibility(viewer, viewer))
|
||||||
|
assert.Equal(t, structs.VisibleTypePrivate, organization.DoerViewOtherVisibility(restrictedViewer, restrictedViewer))
|
||||||
|
assert.Equal(t, structs.VisibleTypePrivate, organization.DoerViewOtherVisibility(&user_model.User{ID: 4, IsAdmin: true, IsRestricted: true}, other))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -126,6 +126,10 @@ func IsBlobAccessibleForUser(ctx context.Context, blobID int64, user *user_model
|
|||||||
if user.IsAdmin {
|
if user.IsAdmin {
|
||||||
return true, nil
|
return true, nil
|
||||||
}
|
}
|
||||||
|
ownerVisibilities := []structs.VisibleType{structs.VisibleTypePublic}
|
||||||
|
if !user.IsRestricted {
|
||||||
|
ownerVisibilities = append(ownerVisibilities, structs.VisibleTypeLimited)
|
||||||
|
}
|
||||||
|
|
||||||
maxTeamAuthorize := builder.
|
maxTeamAuthorize := builder.
|
||||||
Select("max(team.authorize)").
|
Select("max(team.authorize)").
|
||||||
@@ -144,7 +148,7 @@ func IsBlobAccessibleForUser(ctx context.Context, blobID int64, user *user_model
|
|||||||
// owner = user
|
// owner = user
|
||||||
builder.Eq{"`user`.id": user.ID}.
|
builder.Eq{"`user`.id": user.ID}.
|
||||||
// user can see owner
|
// user can see owner
|
||||||
Or(builder.Eq{"`user`.visibility": structs.VisibleTypePublic}.Or(builder.Eq{"`user`.visibility": structs.VisibleTypeLimited})).
|
Or(builder.In("`user`.visibility", ownerVisibilities)).
|
||||||
// owner is an organization and user has access to it
|
// owner is an organization and user has access to it
|
||||||
Or(builder.Eq{"`user`.type": user_model.UserTypeOrganization}.
|
Or(builder.Eq{"`user`.type": user_model.UserTypeOrganization}.
|
||||||
And(builder.Lte{strconv.Itoa(int(perm.AccessModeRead)): maxTeamAuthorize}.Or(builder.Lte{strconv.Itoa(int(perm.AccessModeRead)): maxTeamUnitAccessMode}))),
|
And(builder.Lte{strconv.Itoa(int(perm.AccessModeRead)): maxTeamAuthorize}.Or(builder.Lte{strconv.Itoa(int(perm.AccessModeRead)): maxTeamUnitAccessMode}))),
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"gitea.dev/models/unittest"
|
"gitea.dev/models/unittest"
|
||||||
|
user_model "gitea.dev/models/user"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
@@ -49,3 +50,25 @@ func TestGetOrInsertBlobConcurrent(t *testing.T) {
|
|||||||
}
|
}
|
||||||
assert.Equal(t, numGoroutines-1, existedCount)
|
assert.Equal(t, numGoroutines-1, existedCount)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestIsBlobAccessibleForRestrictedUser(t *testing.T) {
|
||||||
|
require.NoError(t, unittest.PrepareTestDatabase())
|
||||||
|
|
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 33})
|
||||||
|
pkg, err := TryInsertPackage(t.Context(), &Package{OwnerID: owner.ID, Type: TypeContainer, Name: "limited", LowerName: "limited"})
|
||||||
|
require.NoError(t, err)
|
||||||
|
version, err := GetOrInsertVersion(t.Context(), &PackageVersion{PackageID: pkg.ID, Version: "1", LowerVersion: "1"})
|
||||||
|
require.NoError(t, err)
|
||||||
|
blob, _, err := GetOrInsertBlob(t.Context(), &PackageBlob{Size: 1, HashMD5: "md5", HashSHA1: "sha1", HashSHA256: "sha256", HashSHA512: "sha512"})
|
||||||
|
require.NoError(t, err)
|
||||||
|
_, err = TryInsertFile(t.Context(), &PackageFile{VersionID: version.ID, BlobID: blob.ID, Name: "blob", LowerName: "blob"})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
accessible, err := IsBlobAccessibleForUser(t.Context(), blob.ID, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}))
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.True(t, accessible)
|
||||||
|
|
||||||
|
accessible, err = IsBlobAccessibleForUser(t.Context(), blob.ID, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 29}))
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.False(t, accessible)
|
||||||
|
}
|
||||||
|
|||||||
@@ -1701,7 +1701,7 @@ func Routes() *web.Router {
|
|||||||
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
|
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
|
||||||
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser, auth_model.AccessTokenScopeCategoryOrganization), context.UserAssignmentAPI(), checkTokenPublicOnly(), individualPermsChecker)
|
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser, auth_model.AccessTokenScopeCategoryOrganization), context.UserAssignmentAPI(), checkTokenPublicOnly(), individualPermsChecker)
|
||||||
m.Post("/orgs", tokenRequiresScopes(auth_model.AccessTokenScopeCategoryOrganization), reqToken(), bind(api.CreateOrgOption{}), org.Create)
|
m.Post("/orgs", tokenRequiresScopes(auth_model.AccessTokenScopeCategoryOrganization), reqToken(), bind(api.CreateOrgOption{}), org.Create)
|
||||||
m.Get("/orgs", org.GetAll, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryOrganization))
|
m.Get("/orgs", tokenRequiresScopes(auth_model.AccessTokenScopeCategoryOrganization), org.GetAll)
|
||||||
m.Group("/orgs/{org}", func() {
|
m.Group("/orgs/{org}", func() {
|
||||||
m.Combo("").Get(org.Get).
|
m.Combo("").Get(org.Get).
|
||||||
Patch(reqToken(), reqOrgOwnership(), bind(api.EditOrgOption{}), org.Edit).
|
Patch(reqToken(), reqOrgOwnership(), bind(api.EditOrgOption{}), org.Edit).
|
||||||
|
|||||||
@@ -683,16 +683,13 @@ func getRepositoryByParams(ctx *context.APIContext) *repo_model.Repository {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func canChangeTeamRepository(ctx *context.APIContext) bool {
|
func canChangeTeamRepository(ctx *context.APIContext) bool {
|
||||||
if ctx.Org.Organization.RepoAdminChangeTeamAccess {
|
canChange, err := ctx.Org.Organization.CanChangeRepoTeamAccess(ctx, ctx.Doer)
|
||||||
return true
|
|
||||||
}
|
|
||||||
isOwner, err := ctx.Org.Organization.IsOwnedBy(ctx, ctx.Doer.ID)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
ctx.APIErrorInternal(err)
|
ctx.APIErrorInternal(err)
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
if !isOwner {
|
if !canChange {
|
||||||
ctx.APIError(http.StatusForbidden, "user is nor repo admin nor owner")
|
ctx.APIError(http.StatusForbidden, "Must be an organization owner")
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
return true
|
return true
|
||||||
|
|||||||
@@ -137,6 +137,8 @@ func AddTeam(ctx *context.APIContext) {
|
|||||||
// responses:
|
// responses:
|
||||||
// "204":
|
// "204":
|
||||||
// "$ref": "#/responses/empty"
|
// "$ref": "#/responses/empty"
|
||||||
|
// "403":
|
||||||
|
// "$ref": "#/responses/forbidden"
|
||||||
// "422":
|
// "422":
|
||||||
// "$ref": "#/responses/validationError"
|
// "$ref": "#/responses/validationError"
|
||||||
// "405":
|
// "405":
|
||||||
@@ -173,6 +175,8 @@ func DeleteTeam(ctx *context.APIContext) {
|
|||||||
// responses:
|
// responses:
|
||||||
// "204":
|
// "204":
|
||||||
// "$ref": "#/responses/empty"
|
// "$ref": "#/responses/empty"
|
||||||
|
// "403":
|
||||||
|
// "$ref": "#/responses/forbidden"
|
||||||
// "422":
|
// "422":
|
||||||
// "$ref": "#/responses/validationError"
|
// "$ref": "#/responses/validationError"
|
||||||
// "405":
|
// "405":
|
||||||
@@ -186,9 +190,9 @@ func DeleteTeam(ctx *context.APIContext) {
|
|||||||
func changeRepoTeam(ctx *context.APIContext, add bool) {
|
func changeRepoTeam(ctx *context.APIContext, add bool) {
|
||||||
if !ctx.Repo.Owner.IsOrganization() {
|
if !ctx.Repo.Owner.IsOrganization() {
|
||||||
ctx.APIError(http.StatusMethodNotAllowed, "repo is not owned by an organization")
|
ctx.APIError(http.StatusMethodNotAllowed, "repo is not owned by an organization")
|
||||||
|
return
|
||||||
}
|
}
|
||||||
if !ctx.Repo.Owner.RepoAdminChangeTeamAccess && !ctx.Repo.Permission.IsOwner() {
|
if !canChangeRepoTeam(ctx) {
|
||||||
ctx.APIError(http.StatusForbidden, "user is nor repo admin nor owner")
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -220,6 +224,19 @@ func changeRepoTeam(ctx *context.APIContext, add bool) {
|
|||||||
ctx.Status(http.StatusNoContent)
|
ctx.Status(http.StatusNoContent)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func canChangeRepoTeam(ctx *context.APIContext) bool {
|
||||||
|
canChange, err := organization.OrgFromUser(ctx.Repo.Owner).CanChangeRepoTeamAccess(ctx, ctx.Doer)
|
||||||
|
if err != nil {
|
||||||
|
ctx.APIErrorInternal(err)
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if !canChange {
|
||||||
|
ctx.APIError(http.StatusForbidden, "Must be an organization owner")
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
func getTeamByParam(ctx *context.APIContext) *organization.Team {
|
func getTeamByParam(ctx *context.APIContext) *organization.Team {
|
||||||
team, err := organization.GetTeam(ctx, ctx.Repo.Owner.ID, ctx.PathParam("team"))
|
team, err := organization.GetTeam(ctx, ctx.Repo.Owner.ID, ctx.PathParam("team"))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
actions_model "gitea.dev/models/actions"
|
actions_model "gitea.dev/models/actions"
|
||||||
|
auth_model "gitea.dev/models/auth"
|
||||||
"gitea.dev/modules/badge"
|
"gitea.dev/modules/badge"
|
||||||
"gitea.dev/modules/git"
|
"gitea.dev/modules/git"
|
||||||
"gitea.dev/modules/util"
|
"gitea.dev/modules/util"
|
||||||
@@ -17,6 +18,11 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
func GetWorkflowBadge(ctx *context.Context) {
|
func GetWorkflowBadge(ctx *context.Context) {
|
||||||
|
context.CheckRepoScopedToken(ctx, ctx.Repo.Repository, auth_model.Read)
|
||||||
|
if ctx.Written() {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
workflowFile := ctx.PathParam("workflow_name")
|
workflowFile := ctx.PathParam("workflow_name")
|
||||||
branch := ctx.FormString("branch", ctx.Repo.Repository.DefaultBranch)
|
branch := ctx.FormString("branch", ctx.Repo.Repository.DefaultBranch)
|
||||||
event := ctx.FormString("event")
|
event := ctx.FormString("event")
|
||||||
|
|||||||
@@ -43,6 +43,13 @@ func Collaboration(ctx *context.Context) {
|
|||||||
ctx.Data["OrgName"] = ctx.Repo.Repository.OwnerName
|
ctx.Data["OrgName"] = ctx.Repo.Repository.OwnerName
|
||||||
ctx.Data["Org"] = ctx.Repo.Repository.Owner
|
ctx.Data["Org"] = ctx.Repo.Repository.Owner
|
||||||
ctx.Data["Units"] = unit_model.Units
|
ctx.Data["Units"] = unit_model.Units
|
||||||
|
if ctx.Repo.Owner.IsOrganization() {
|
||||||
|
ctx.Data["CanChangeRepoTeamAccess"], err = organization.OrgFromUser(ctx.Repo.Owner).CanChangeRepoTeamAccess(ctx, ctx.Doer)
|
||||||
|
if err != nil {
|
||||||
|
ctx.ServerError("CanChangeRepoTeamAccess", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
ctx.HTML(http.StatusOK, tplCollaboration)
|
ctx.HTML(http.StatusOK, tplCollaboration)
|
||||||
}
|
}
|
||||||
@@ -155,9 +162,7 @@ func DeleteCollaboration(ctx *context.Context) {
|
|||||||
|
|
||||||
// AddTeamPost response for adding a team to a repository
|
// AddTeamPost response for adding a team to a repository
|
||||||
func AddTeamPost(ctx *context.Context) {
|
func AddTeamPost(ctx *context.Context) {
|
||||||
if !ctx.Repo.Owner.RepoAdminChangeTeamAccess && !ctx.Repo.Permission.IsOwner() {
|
if !canChangeRepoTeamAccess(ctx) {
|
||||||
ctx.Flash.Error(ctx.Tr("repo.settings.change_team_access_not_allowed"))
|
|
||||||
ctx.Redirect(ctx.Repo.RepoLink + "/settings/collaboration")
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -201,9 +206,7 @@ func AddTeamPost(ctx *context.Context) {
|
|||||||
|
|
||||||
// DeleteTeam response for deleting a team from a repository
|
// DeleteTeam response for deleting a team from a repository
|
||||||
func DeleteTeam(ctx *context.Context) {
|
func DeleteTeam(ctx *context.Context) {
|
||||||
if !ctx.Repo.Owner.RepoAdminChangeTeamAccess && !ctx.Repo.Permission.IsOwner() {
|
if !canChangeRepoTeamAccess(ctx) {
|
||||||
ctx.Flash.Error(ctx.Tr("repo.settings.change_team_access_not_allowed"))
|
|
||||||
ctx.Redirect(ctx.Repo.RepoLink + "/settings/collaboration")
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -221,3 +224,16 @@ func DeleteTeam(ctx *context.Context) {
|
|||||||
ctx.Flash.Success(ctx.Tr("repo.settings.remove_team_success"))
|
ctx.Flash.Success(ctx.Tr("repo.settings.remove_team_success"))
|
||||||
ctx.JSONRedirect(ctx.Repo.RepoLink + "/settings/collaboration")
|
ctx.JSONRedirect(ctx.Repo.RepoLink + "/settings/collaboration")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func canChangeRepoTeamAccess(ctx *context.Context) bool {
|
||||||
|
canChange, err := organization.OrgFromUser(ctx.Repo.Owner).CanChangeRepoTeamAccess(ctx, ctx.Doer)
|
||||||
|
if err != nil {
|
||||||
|
ctx.ServerError("CanChangeRepoTeamAccess", err)
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if !canChange {
|
||||||
|
ctx.Flash.Error(ctx.Tr("repo.settings.change_team_access_not_allowed"))
|
||||||
|
ctx.Redirect(ctx.Repo.RepoLink + "/settings/collaboration")
|
||||||
|
}
|
||||||
|
return canChange
|
||||||
|
}
|
||||||
|
|||||||
@@ -240,40 +240,27 @@ func TestAddTeamPost(t *testing.T) {
|
|||||||
|
|
||||||
func TestAddTeamPost_NotAllowed(t *testing.T) {
|
func TestAddTeamPost_NotAllowed(t *testing.T) {
|
||||||
unittest.PrepareTestEnv(t)
|
unittest.PrepareTestEnv(t)
|
||||||
ctx, _ := contexttest.MockContext(t, "org26/repo43")
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 32})
|
||||||
|
require.NoError(t, repo.LoadOwner(t.Context()))
|
||||||
|
adminTeam := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 12})
|
||||||
|
targetTeam := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 2})
|
||||||
|
require.NoError(t, repo_service.TeamAddRepository(t.Context(), adminTeam, repo))
|
||||||
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28})
|
||||||
|
repoContext := &context.Repository{Owner: repo.Owner, Repository: repo}
|
||||||
|
renderCtx, _ := contexttest.MockContext(t, repo.Link()+"/settings/collaboration")
|
||||||
|
renderCtx.Repo = repoContext
|
||||||
|
renderCtx.Doer = doer
|
||||||
|
Collaboration(renderCtx)
|
||||||
|
assert.Equal(t, false, renderCtx.Data["CanChangeRepoTeamAccess"])
|
||||||
|
|
||||||
ctx.Req.Form.Set("team", "team11")
|
ctx, _ := contexttest.MockContext(t, repo.Link()+"/settings/collaboration")
|
||||||
|
ctx.Req.Form.Set("team", targetTeam.Name)
|
||||||
org := &user_model.User{
|
ctx.Repo = repoContext
|
||||||
LowerName: "org26",
|
ctx.Doer = doer
|
||||||
Type: user_model.UserTypeOrganization,
|
|
||||||
}
|
|
||||||
|
|
||||||
team := &organization.Team{
|
|
||||||
ID: 11,
|
|
||||||
OrgID: 26,
|
|
||||||
}
|
|
||||||
|
|
||||||
re := &repo_model.Repository{
|
|
||||||
ID: 43,
|
|
||||||
Owner: org,
|
|
||||||
OwnerID: 26,
|
|
||||||
}
|
|
||||||
|
|
||||||
repo := &context.Repository{
|
|
||||||
Owner: &user_model.User{
|
|
||||||
ID: 26,
|
|
||||||
LowerName: "org26",
|
|
||||||
RepoAdminChangeTeamAccess: false,
|
|
||||||
},
|
|
||||||
Repository: re,
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx.Repo = repo
|
|
||||||
|
|
||||||
AddTeamPost(ctx)
|
AddTeamPost(ctx)
|
||||||
|
|
||||||
assert.False(t, repo_service.HasRepository(t.Context(), team, re.ID))
|
assert.False(t, repo_service.HasRepository(t.Context(), targetTeam, repo.ID))
|
||||||
assert.Equal(t, http.StatusSeeOther, ctx.Resp.WrittenStatus())
|
assert.Equal(t, http.StatusSeeOther, ctx.Resp.WrittenStatus())
|
||||||
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
assert.NotEmpty(t, ctx.Flash.ErrorMsg)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -14,7 +14,6 @@ import (
|
|||||||
"gitea.dev/models/unit"
|
"gitea.dev/models/unit"
|
||||||
user_model "gitea.dev/models/user"
|
user_model "gitea.dev/models/user"
|
||||||
"gitea.dev/modules/setting"
|
"gitea.dev/modules/setting"
|
||||||
"gitea.dev/modules/structs"
|
|
||||||
"gitea.dev/modules/templates"
|
"gitea.dev/modules/templates"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -155,10 +154,10 @@ func determineAccessMode(ctx *Base, pkgOwner, doer *user_model.User) (perm.Acces
|
|||||||
// 1. Check if user is package owner
|
// 1. Check if user is package owner
|
||||||
if doer.ID == pkgOwner.ID {
|
if doer.ID == pkgOwner.ID {
|
||||||
accessMode = perm.AccessModeOwner
|
accessMode = perm.AccessModeOwner
|
||||||
} else if pkgOwner.Visibility == structs.VisibleTypePublic || pkgOwner.Visibility == structs.VisibleTypeLimited { // 2. Check if package owner is public or limited
|
} else if pkgOwner.Visibility.IsPublic() || (pkgOwner.Visibility.IsLimited() && !doer.IsRestricted) { // 2. Check if package owner is visible to the doer
|
||||||
accessMode = perm.AccessModeRead
|
accessMode = perm.AccessModeRead
|
||||||
}
|
}
|
||||||
} else if pkgOwner.Visibility == structs.VisibleTypePublic { // 3. Check if package owner is public
|
} else if pkgOwner.Visibility.IsPublic() { // 3. Check if package owner is public
|
||||||
accessMode = perm.AccessModeRead
|
accessMode = perm.AccessModeRead
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,26 @@
|
|||||||
|
// Copyright 2026 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package context
|
||||||
|
|
||||||
|
import (
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"gitea.dev/models/perm"
|
||||||
|
"gitea.dev/models/user"
|
||||||
|
"gitea.dev/modules/structs"
|
||||||
|
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestDeterminePackageAccessModeForLimitedOwner(t *testing.T) {
|
||||||
|
owner := &user.User{ID: 1, Visibility: structs.VisibleTypeLimited}
|
||||||
|
|
||||||
|
accessMode, err := determineAccessMode(&Base{}, owner, &user.User{ID: 2, IsActive: true})
|
||||||
|
assert.NoError(t, err)
|
||||||
|
assert.Equal(t, perm.AccessModeRead, accessMode)
|
||||||
|
|
||||||
|
accessMode, err = determineAccessMode(&Base{}, owner, &user.User{ID: 3, IsActive: true, IsRestricted: true})
|
||||||
|
assert.NoError(t, err)
|
||||||
|
assert.Equal(t, perm.AccessModeNone, accessMode)
|
||||||
|
}
|
||||||
@@ -51,7 +51,7 @@
|
|||||||
<h4 class="ui top attached header">
|
<h4 class="ui top attached header">
|
||||||
{{ctx.Locale.Tr "repo.settings.teams"}}
|
{{ctx.Locale.Tr "repo.settings.teams"}}
|
||||||
</h4>
|
</h4>
|
||||||
{{$allowedToChangeTeams := (or (.Org.RepoAdminChangeTeamAccess) (.Permission.IsOwner))}}
|
{{$allowedToChangeTeams := .CanChangeRepoTeamAccess}}
|
||||||
{{if .Teams}}
|
{{if .Teams}}
|
||||||
<div class="ui attached segment">
|
<div class="ui attached segment">
|
||||||
<div class="flex-divided-list items-with-main">
|
<div class="flex-divided-list items-with-main">
|
||||||
|
|||||||
Generated
+6
@@ -17781,6 +17781,9 @@
|
|||||||
"204": {
|
"204": {
|
||||||
"$ref": "#/responses/empty"
|
"$ref": "#/responses/empty"
|
||||||
},
|
},
|
||||||
|
"403": {
|
||||||
|
"$ref": "#/responses/forbidden"
|
||||||
|
},
|
||||||
"404": {
|
"404": {
|
||||||
"$ref": "#/responses/notFound"
|
"$ref": "#/responses/notFound"
|
||||||
},
|
},
|
||||||
@@ -17828,6 +17831,9 @@
|
|||||||
"204": {
|
"204": {
|
||||||
"$ref": "#/responses/empty"
|
"$ref": "#/responses/empty"
|
||||||
},
|
},
|
||||||
|
"403": {
|
||||||
|
"$ref": "#/responses/forbidden"
|
||||||
|
},
|
||||||
"404": {
|
"404": {
|
||||||
"$ref": "#/responses/notFound"
|
"$ref": "#/responses/notFound"
|
||||||
},
|
},
|
||||||
|
|||||||
Generated
+6
@@ -29943,6 +29943,9 @@
|
|||||||
"204": {
|
"204": {
|
||||||
"$ref": "#/components/responses/empty"
|
"$ref": "#/components/responses/empty"
|
||||||
},
|
},
|
||||||
|
"403": {
|
||||||
|
"$ref": "#/components/responses/forbidden"
|
||||||
|
},
|
||||||
"404": {
|
"404": {
|
||||||
"$ref": "#/components/responses/notFound"
|
"$ref": "#/components/responses/notFound"
|
||||||
},
|
},
|
||||||
@@ -30040,6 +30043,9 @@
|
|||||||
"204": {
|
"204": {
|
||||||
"$ref": "#/components/responses/empty"
|
"$ref": "#/components/responses/empty"
|
||||||
},
|
},
|
||||||
|
"403": {
|
||||||
|
"$ref": "#/components/responses/forbidden"
|
||||||
|
},
|
||||||
"404": {
|
"404": {
|
||||||
"$ref": "#/components/responses/notFound"
|
"$ref": "#/components/responses/notFound"
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -121,6 +121,9 @@ func testAPIOrgGeneral(t *testing.T) {
|
|||||||
user1Token := getTokenForLoggedInUser(t, user1Session, auth_model.AccessTokenScopeWriteOrganization)
|
user1Token := getTokenForLoggedInUser(t, user1Session, auth_model.AccessTokenScopeWriteOrganization)
|
||||||
|
|
||||||
t.Run("OrgGetAll", func(t *testing.T) {
|
t.Run("OrgGetAll", func(t *testing.T) {
|
||||||
|
miscToken := getTokenForLoggedInUser(t, user1Session, auth_model.AccessTokenScopeReadMisc)
|
||||||
|
MakeRequest(t, NewRequest(t, "GET", "/api/v1/orgs").AddTokenAuth(miscToken), http.StatusForbidden)
|
||||||
|
|
||||||
// accessing with a token will return all orgs
|
// accessing with a token will return all orgs
|
||||||
req := NewRequest(t, "GET", "/api/v1/orgs").AddTokenAuth(user1Token)
|
req := NewRequest(t, "GET", "/api/v1/orgs").AddTokenAuth(user1Token)
|
||||||
resp := MakeRequest(t, req, http.StatusOK)
|
resp := MakeRequest(t, req, http.StatusOK)
|
||||||
@@ -130,6 +133,14 @@ func testAPIOrgGeneral(t *testing.T) {
|
|||||||
assert.Equal(t, "Limited Org 36", apiOrgList[1].FullName)
|
assert.Equal(t, "Limited Org 36", apiOrgList[1].FullName)
|
||||||
assert.Equal(t, api.UserVisibilityLimited, apiOrgList[1].Visibility)
|
assert.Equal(t, api.UserVisibilityLimited, apiOrgList[1].Visibility)
|
||||||
|
|
||||||
|
publicOnlyToken := getTokenForLoggedInUser(t, user1Session, auth_model.AccessTokenScopeReadOrganization, auth_model.AccessTokenScopePublicOnly)
|
||||||
|
resp = MakeRequest(t, NewRequest(t, "GET", "/api/v1/orgs").AddTokenAuth(publicOnlyToken), http.StatusOK)
|
||||||
|
apiOrgList = DecodeJSON(t, resp, []*api.Organization{})
|
||||||
|
assert.Len(t, apiOrgList, 9)
|
||||||
|
for _, org := range apiOrgList {
|
||||||
|
assert.Equal(t, api.UserVisibilityPublic, org.Visibility)
|
||||||
|
}
|
||||||
|
|
||||||
// accessing without a token will return only public orgs
|
// accessing without a token will return only public orgs
|
||||||
req = NewRequest(t, "GET", "/api/v1/orgs")
|
req = NewRequest(t, "GET", "/api/v1/orgs")
|
||||||
resp = MakeRequest(t, req, http.StatusOK)
|
resp = MakeRequest(t, req, http.StatusOK)
|
||||||
|
|||||||
@@ -9,12 +9,14 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
auth_model "gitea.dev/models/auth"
|
auth_model "gitea.dev/models/auth"
|
||||||
|
"gitea.dev/models/organization"
|
||||||
repo_model "gitea.dev/models/repo"
|
repo_model "gitea.dev/models/repo"
|
||||||
"gitea.dev/models/unit"
|
"gitea.dev/models/unit"
|
||||||
"gitea.dev/models/unittest"
|
"gitea.dev/models/unittest"
|
||||||
user_model "gitea.dev/models/user"
|
user_model "gitea.dev/models/user"
|
||||||
api "gitea.dev/modules/structs"
|
api "gitea.dev/modules/structs"
|
||||||
"gitea.dev/modules/util"
|
"gitea.dev/modules/util"
|
||||||
|
repo_service "gitea.dev/services/repository"
|
||||||
"gitea.dev/tests"
|
"gitea.dev/tests"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
@@ -63,6 +65,19 @@ func TestAPIRepoTeams(t *testing.T) {
|
|||||||
AddTokenAuth(token)
|
AddTokenAuth(token)
|
||||||
MakeRequest(t, req, http.StatusForbidden)
|
MakeRequest(t, req, http.StatusForbidden)
|
||||||
|
|
||||||
|
adminTeam := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 12})
|
||||||
|
targetTeam := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 2})
|
||||||
|
existingTeam := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 7})
|
||||||
|
assert.NoError(t, repo_service.TeamAddRepository(t.Context(), adminTeam, publicOrgRepo))
|
||||||
|
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28})
|
||||||
|
token = getUserToken(t, user.Name, auth_model.AccessTokenScopeWriteRepository)
|
||||||
|
req = NewRequest(t, "PUT", fmt.Sprintf("/api/v1/repos/%s/teams/%s", publicOrgRepo.FullName(), targetTeam.Name)).AddTokenAuth(token)
|
||||||
|
MakeRequest(t, req, http.StatusForbidden)
|
||||||
|
assert.False(t, repo_service.HasRepository(t.Context(), targetTeam, publicOrgRepo.ID))
|
||||||
|
req = NewRequest(t, "DELETE", fmt.Sprintf("/api/v1/repos/%s/teams/%s", publicOrgRepo.FullName(), existingTeam.Name)).AddTokenAuth(token)
|
||||||
|
MakeRequest(t, req, http.StatusForbidden)
|
||||||
|
assert.True(t, repo_service.HasRepository(t.Context(), existingTeam, publicOrgRepo.ID))
|
||||||
|
|
||||||
// AddTeam with user2
|
// AddTeam with user2
|
||||||
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
||||||
session = loginUser(t, user.Name)
|
session = loginUser(t, user.Name)
|
||||||
|
|||||||
@@ -329,6 +329,15 @@ func TestAPIAddRemoveTeamRepositoryRequiresOrgOwnerOrSetting(t *testing.T) {
|
|||||||
req = NewRequest(t, "DELETE", url).AddTokenAuth(token)
|
req = NewRequest(t, "DELETE", url).AddTokenAuth(token)
|
||||||
MakeRequest(t, req, http.StatusForbidden)
|
MakeRequest(t, req, http.StatusForbidden)
|
||||||
unittest.AssertExistsAndLoadBean(t, &organization.TeamRepo{TeamID: team.ID, RepoID: targetRepo.ID})
|
unittest.AssertExistsAndLoadBean(t, &organization.TeamRepo{TeamID: team.ID, RepoID: targetRepo.ID})
|
||||||
|
|
||||||
|
siteAdmin := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
||||||
|
token = getUserToken(t, siteAdmin.Name, auth_model.AccessTokenScopeWriteOrganization)
|
||||||
|
req = NewRequest(t, "DELETE", url).AddTokenAuth(token)
|
||||||
|
MakeRequest(t, req, http.StatusNoContent)
|
||||||
|
unittest.AssertNotExistsBean(t, &organization.TeamRepo{TeamID: team.ID, RepoID: targetRepo.ID})
|
||||||
|
req = NewRequest(t, "PUT", url).AddTokenAuth(token)
|
||||||
|
MakeRequest(t, req, http.StatusNoContent)
|
||||||
|
unittest.AssertExistsAndLoadBean(t, &organization.TeamRepo{TeamID: team.ID, RepoID: targetRepo.ID})
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestAPITeamVisibilityAccess(t *testing.T) {
|
func TestAPITeamVisibilityAccess(t *testing.T) {
|
||||||
|
|||||||
@@ -77,6 +77,9 @@ func TestUserOrgs(t *testing.T) {
|
|||||||
orgs = getUserOrgs(t, unrelatedUsername, privateMemberUsername)
|
orgs = getUserOrgs(t, unrelatedUsername, privateMemberUsername)
|
||||||
assert.Empty(t, orgs)
|
assert.Empty(t, orgs)
|
||||||
|
|
||||||
|
orgs = getUserOrgs(t, "user29", adminUsername)
|
||||||
|
assert.Empty(t, orgs)
|
||||||
|
|
||||||
// not authenticated call should not be allowed
|
// not authenticated call should not be allowed
|
||||||
testUserOrgsUnauthenticated(t, privateMemberUsername)
|
testUserOrgsUnauthenticated(t, privateMemberUsername)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -11,30 +11,33 @@ import (
|
|||||||
"gitea.dev/tests"
|
"gitea.dev/tests"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TestRepoHomeContentTokenScopes ensures the web repository home page enforces the
|
func TestRepoWebTokenScopes(t *testing.T) {
|
||||||
// repository read scope (and public-only confinement) of an API token used via basic
|
|
||||||
// auth, so a wrongly-scoped token cannot read private repository content.
|
|
||||||
func TestRepoHomeContentTokenScopes(t *testing.T) {
|
|
||||||
defer tests.PrepareTestEnv(t)()
|
defer tests.PrepareTestEnv(t)()
|
||||||
|
|
||||||
// user2/repo2 is a private repository owned by user2
|
|
||||||
const url = "/user2/repo2"
|
|
||||||
|
|
||||||
// a token without repository scope must be denied
|
|
||||||
miscToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadMisc)
|
miscToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadMisc)
|
||||||
reqDenied := NewRequest(t, "GET", url)
|
|
||||||
reqDenied.SetBasicAuth("user2", miscToken)
|
|
||||||
MakeRequest(t, reqDenied, http.StatusForbidden)
|
|
||||||
|
|
||||||
// a public-only token must be denied on a private repo
|
|
||||||
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadRepository, auth_model.AccessTokenScopePublicOnly)
|
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadRepository, auth_model.AccessTokenScopePublicOnly)
|
||||||
reqPublicOnly := NewRequest(t, "GET", url)
|
readToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadRepository)
|
||||||
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
|
||||||
MakeRequest(t, reqPublicOnly, http.StatusForbidden)
|
|
||||||
|
|
||||||
// a token with repository read scope is allowed
|
for _, test := range []struct {
|
||||||
ownerReadToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadRepository)
|
name string
|
||||||
reqAllowed := NewRequest(t, "GET", url)
|
url string
|
||||||
reqAllowed.SetBasicAuth("user2", ownerReadToken)
|
}{
|
||||||
MakeRequest(t, reqAllowed, http.StatusOK)
|
{"repository home", "/user2/repo2"},
|
||||||
|
{"workflow badge", "/org3/repo3/actions/workflows/test.yml/badge.svg"},
|
||||||
|
} {
|
||||||
|
t.Run(test.name, func(t *testing.T) {
|
||||||
|
assertBasicAuthStatus(t, test.url, miscToken, http.StatusForbidden)
|
||||||
|
assertBasicAuthStatus(t, test.url, publicOnlyToken, http.StatusForbidden)
|
||||||
|
assertBasicAuthStatus(t, test.url, readToken, http.StatusOK)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
assertBasicAuthStatus(t, "/user2/repo1/actions/workflows/test.yml/badge.svg", publicOnlyToken, http.StatusOK)
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertBasicAuthStatus(t *testing.T, url, token string, status int) {
|
||||||
|
t.Helper()
|
||||||
|
req := NewRequest(t, http.MethodGet, url)
|
||||||
|
req.SetBasicAuth("user2", token)
|
||||||
|
MakeRequest(t, req, status)
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user