ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-06 03:11:48 +09:00
Code Issues Projects Releases Wiki Activity

fix(git): return no submodule web link when the URL cannot be parsed (#39274) (#39592)

Browse Source 
Backport #39274

Co-authored-by: KBS <youdie006@naver.com>
This commit is contained in:
Giteabot
2026-10-04 14:00:15 +00:00
committed by GitHub
co-authored by KBS
parent 02fd18970b
commit 219b0e7c17
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/git/commit_submodule_file.go
+2 -2
View File
@@ -46,11 +46,11 @@ func (sf *CommitSubmoduleFile) getWebLinkInTargetRepo(ctx context.Context, moreL
return &SubmoduleWebLink{RepoWebLink: targetLink, CommitWebLink: targetLink + moreLinkPath}
}
if !sf.parsed {
sf.parsed = true
parsedURL, err := giturl.ParseRepositoryURL(ctx, sf.refURL)
if err != nil {
return nil
return nil // do not mark as parsed, otherwise later calls would return a link with an empty target
}
sf.parsed = true
sf.parsedTargetLink = giturl.MakeRepositoryWebLink(parsedURL)
}
return &SubmoduleWebLink{RepoWebLink: sf.parsedTargetLink, CommitWebLink: sf.parsedTargetLink + moreLinkPath}