ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-05 19:01:47 +09:00
Code Issues Projects Releases Wiki Activity

fix(git): return no submodule web link when the URL cannot be parsed (#39274) (#39592)

Browse Source 
Backport #39274

Co-authored-by: KBS <youdie006@naver.com>
This commit is contained in:
Giteabot
2026-10-04 14:00:15 +00:00
committed by GitHub
co-authored by KBS
parent 02fd18970b
commit 219b0e7c17
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/git/commit_submodule_file_test.go
+7
View File
@@ -37,4 +37,11 @@ func TestCommitSubmoduleLink(t *testing.T) {
assert.Equal(t, "/subpath/user/repo", wl.RepoWebLink)
assert.Equal(t, "/subpath/user/repo/compare/1111...2222", wl.CommitWebLink)
})
t.Run("UnparsableURL", func(t *testing.T) {
// both calls share one instance on purpose: the second one used to see the cached parse result
sf := NewCommitSubmoduleFile("/any/repo-link", "full-path", "git@github.com:", "aaaa")
assert.Nil(t, sf.SubmoduleWebLinkTree(t.Context()))
assert.Nil(t, sf.SubmoduleWebLinkCompare(t.Context(), "1111", "2222"))
})
}