chore: enable forcetypeassert linter, fix issues (#38804)

Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert)
linter to prevent unchecked type assertions. ~650 issues fixed, most
fixes were clean, some use `setting.PanicInDevOrTesting`.

The only behaviour changes are where code would previously send a 500 error
or panic, a 4xx error is now emitted.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-08-09 10:25:06 +00:00
committed by GitHub
co-authored by wxiaoguang
parent fac8bf2eca
commit 76a81b24f9
248 changed files with 1110 additions and 995 deletions
+4 -4
View File
@@ -183,7 +183,7 @@ func CreateIssueDependency(ctx *context.APIContext) {
}
// and <Form> represents the dependency
form := web.GetForm(ctx).(*api.IssueMeta)
form := web.GetForm[*api.IssueMeta](ctx)
dependency := getFormIssue(ctx, form)
if ctx.Written() {
return
@@ -244,7 +244,7 @@ func RemoveIssueDependency(ctx *context.APIContext) {
}
// and <Form> represents the dependency
form := web.GetForm(ctx).(*api.IssueMeta)
form := web.GetForm[*api.IssueMeta](ctx)
dependency := getFormIssue(ctx, form)
if ctx.Written() {
return
@@ -404,7 +404,7 @@ func CreateIssueBlocking(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.IssueMeta)
form := web.GetForm[*api.IssueMeta](ctx)
target := getFormIssue(ctx, form)
if ctx.Written() {
return
@@ -461,7 +461,7 @@ func RemoveIssueBlocking(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.IssueMeta)
form := web.GetForm[*api.IssueMeta](ctx)
target := getFormIssue(ctx, form)
if ctx.Written() {
return