chore: upgrade eslint plugins, remove eslint-plugin-github (#38046)

- Bump `eslint`, `typescript-eslint` and `eslint-plugin-unicorn` (to
v68), and configure the rules added in unicorn v66/v67/v68.
- Remove `eslint-plugin-github` and its workarounds (rules, type stub,
pnpm peer override, in-code `eslint-disable` comments); the rules worth
keeping are covered by `unicorn` equivalents.
- Apply the resulting fixes and autofixes across the JS codebase.

_Prepared with Claude (Opus 4.8)._

---------

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

web_src/js/features/admin/config.test.ts

@@ -30,9 +30,9 @@ test('ConfigFormValueMapper', () => {
   const formData = mapper.collectToFormData();
   const result: Record<string, string> = {};
   const keys: string[] = [], values: string[] = [];
-  for (const [key, value] of formData.entries()) {
+  for (const [key, value] of formData) {
     if (key === 'key') keys.push(value as string);
-    if (key === 'value') values.push(value as string);
+    else if (key === 'value') values.push(value as string);
   }
   for (let i = 0; i < keys.length; i++) {
     result[keys[i]] = values[i];

web_src/js/features/admin/config.ts

@@ -102,9 +102,7 @@ export class ConfigFormValueMapper {
     } else if (el.matches('[type="datetime-local"]')) {
       if (valType !== 'timestamp') requireExplicitValueType(el);
       if (val) el.value = toDatetimeLocalValue(val);
-    } else if (el.matches('textarea')) {
-      el.value = String(val ?? el.value);
-    } else if (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text') {
+    } else if (el.matches('textarea') || (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text')) {
       el.value = String(val ?? el.value);
     } else {
       unsupportedElement(el);
@@ -123,9 +121,7 @@ export class ConfigFormValueMapper {
     } else if (el.matches('[type="datetime-local"]')) {
       if (valType !== 'timestamp') requireExplicitValueType(el);
       val = Math.floor(new Date(el.value).getTime() / 1000) ?? 0; // NaN is fine to JSON.stringify, it becomes null.
-    } else if (el.matches('textarea')) {
-      val = el.value;
-    } else if (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text') {
+    } else if (el.matches('textarea') || (el.matches('input') && (el.getAttribute('type') ?? 'text') === 'text')) {
       val = el.value;
     } else {
       unsupportedElement(el);
@@ -178,7 +174,7 @@ export class ConfigFormValueMapper {
 
   collectToFormData(): FormData {
     const namedElems: Array<GeneralFormFieldElement | null> = [];
-    queryElems(this.form, '[name]', (el) => namedElems.push(el as GeneralFormFieldElement));
+    queryElems(this.form, '[name]', (el) => { namedElems.push(el as GeneralFormFieldElement) });
 
     // first, process the config options with sub values, for example:
     // merge "foo.bar.Enabled", "foo.bar.Message" to "foo.bar"

web_src/js/features/admin/users.ts

@@ -5,14 +5,14 @@ export function initAdminUserListSearchForm(): void {
   const form = document.querySelector<HTMLFormElement>('#user-list-search-form');
   if (!form) return;
 
-  for (const button of form.querySelectorAll(`button[name=sort][value="${searchForm.SortType}"]`)) {
+  for (const button of form.querySelectorAll(`button[name=sort][value="${CSS.escape(searchForm.SortType)}"]`)) {
     button.classList.add('active');
   }
 
   if (searchForm.StatusFilterMap) {
     for (const [k, v] of Object.entries(searchForm.StatusFilterMap)) {
       if (!v) continue;
-      for (const input of form.querySelectorAll<HTMLInputElement>(`input[name="status_filter[${k}]"][value="${v}"]`)) {
+      for (const input of form.querySelectorAll<HTMLInputElement>(`input[name="status_filter[${CSS.escape(k)}]"][value="${CSS.escape(v)}"]`)) {
         input.checked = true;
       }
     }