mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-16 01:43:24 +09:00
refactor: deploy key and private route handlers (#38999)
clean up legacy code, fix various bugs: * add missing "return"
This commit is contained in:
@@ -11,8 +11,6 @@ import (
|
||||
"runtime"
|
||||
"time"
|
||||
|
||||
"gitea.dev/modules/log"
|
||||
"gitea.dev/modules/private"
|
||||
process_module "gitea.dev/modules/process"
|
||||
"gitea.dev/services/context"
|
||||
)
|
||||
@@ -38,10 +36,7 @@ func Processes(ctx *context.PrivateContext) {
|
||||
if stacktraces {
|
||||
processes, processCount, goroutineCount, err = process_module.GetManager().ProcessStacktraces(flat, noSystem)
|
||||
if err != nil {
|
||||
log.Error("Unable to get stacktrace: %v", err)
|
||||
ctx.JSON(http.StatusInternalServerError, private.Response{
|
||||
Err: fmt.Sprintf("Failed to get stacktraces: %v", err),
|
||||
})
|
||||
ctx.PrivateInternalErrorf("Failed to get stacktraces: %v", err)
|
||||
return
|
||||
}
|
||||
} else {
|
||||
@@ -61,11 +56,8 @@ func Processes(ctx *context.PrivateContext) {
|
||||
ctx.Resp.WriteHeader(http.StatusOK)
|
||||
|
||||
if err := writeProcesses(ctx.Resp, processes, processCount, goroutineCount, "", flat); err != nil {
|
||||
log.Error("Unable to write out process stacktrace: %v", err)
|
||||
if !ctx.Written() {
|
||||
ctx.JSON(http.StatusInternalServerError, private.Response{
|
||||
Err: fmt.Sprintf("Failed to get stacktraces: %v", err),
|
||||
})
|
||||
ctx.PrivateInternalErrorf("Failed to get stacktraces: %v", err)
|
||||
}
|
||||
return
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user