ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-16 01:43:24 +09:00
Code Issues Projects Releases Wiki Activity

feat(actions): Add Actions API endpoints for workflow run management and logs (#35382)

Browse Source 
Implements the missing REST API endpoints for Actions workflow run
management:

1. `POST /actions/runs/{run}/cancel` cancels a run and its jobs, `409`
when it already finished
1. `POST /actions/runs/{run}/approve` approves a run awaiting approval,
idempotent, `409` when it never awaited one
1. `GET /actions/runs/{run}/logs` downloads the latest attempt's job
logs as a zip archive

`ActionWorkflowRun` gains `created_at`, `updated_at` and the `jobs_url`,
`logs_url`, `artifacts_url`, `cancel_url` and `rerun_url` fields, and
now always emits `conclusion` and `head_branch`.

Cancellation is shared with the web handler in `services/actions`.

Fixes https://github.com/go-gitea/gitea/issues/35176
Fixes https://github.com/go-gitea/gitea/issues/36554

---------

Co-authored-by: Claude Sonnet 4.6 <claude-sonnet-4-6@anthropic.com>
Co-authored-by: OpenCode Agent <opencode@rossgolder.com>
Co-authored-by: Nicolas <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Ross Golder
2026-08-02 12:22:07 +08:00
committed by GitHub
co-authored by Claude Sonnet 4.6 OpenCode Agent Nicolas silverwind wxiaoguang
parent c5b6e044d7
commit a65f422b89
27 changed files with 1230 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/actions/approve_test.go
+40 -12
View File
@@ -32,36 +32,64 @@ func TestApproveRuns(t *testing.T) {
require.NoError(t, db.Insert(t.Context(), run))
return run
}
insertJob := func(run *actions_model.ActionRun, status actions_model.Status) *actions_model.ActionRunJob {
insertJob := func(run *actions_model.ActionRun, status actions_model.Status, needs ...string) *actions_model.ActionRunJob {
job := &actions_model.ActionRunJob{
RunID: run.ID, RepoID: run.RepoID, OwnerID: run.OwnerID, CommitSHA: run.CommitSHA,
Name: "job1", Attempt: 1, JobID: "job1", Status: status,
RunsOn: []string{"ubuntu-latest"},
RunsOn: []string{"ubuntu-latest"}, Needs: needs,
}
require.NoError(t, db.Insert(t.Context(), job))
return job
}
t.Run("approve blocked run", func(t *testing.T) {
t.Run("approve unblocks a job with no dependencies", func(t *testing.T) {
run := insertRun(1001, actions_model.StatusBlocked, true, 0)
job := insertJob(run, actions_model.StatusBlocked)
require.NoError(t, ApproveRuns(t.Context(), repo, doer, []int64{run.ID}))
approved, err := ApproveRuns(t.Context(), repo, doer, []int64{run.ID})
require.NoError(t, err)
require.Len(t, approved, 1)
assert.False(t, approved[0].NeedApproval)
assert.Equal(t, doer.ID, approved[0].ApprovedBy)
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: run.ID})
assert.False(t, run.NeedApproval)
assert.Equal(t, doer.ID, run.ApprovedBy)
assert.Equal(t, actions_model.StatusWaiting, unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: job.ID}).Status)
})
t.Run("a job with unmet dependencies stays blocked", func(t *testing.T) {
run := insertRun(1002, actions_model.StatusBlocked, true, 0)
job := insertJob(run, actions_model.StatusBlocked, "some-other-job")
approved, err := ApproveRuns(t.Context(), repo, doer, []int64{run.ID})
require.NoError(t, err)
require.Len(t, approved, 1)
assert.False(t, approved[0].NeedApproval)
assert.Equal(t, actions_model.StatusBlocked, unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: job.ID}).Status)
})
t.Run("re-approving an approved run is a no-op", func(t *testing.T) {
run := insertRun(1002, actions_model.StatusRunning, false, 4)
run := insertRun(1005, actions_model.StatusRunning, false, 4)
job := insertJob(run, actions_model.StatusRunning)
require.NoError(t, ApproveRuns(t.Context(), repo, doer, []int64{run.ID}))
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{ID: run.ID})
assert.EqualValues(t, 4, run.ApprovedBy, "approver must not be overwritten")
approved, err := ApproveRuns(t.Context(), repo, doer, []int64{run.ID})
require.NoError(t, err)
require.Len(t, approved, 1)
assert.EqualValues(t, 4, approved[0].ApprovedBy, "approver must not be overwritten")
assert.Equal(t, actions_model.StatusRunning, unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunJob{ID: job.ID}).Status, "started job must not be reset to waiting")
})
t.Run("approving several runs returns them in the requested order", func(t *testing.T) {
run1 := insertRun(1003, actions_model.StatusBlocked, true, 0)
insertJob(run1, actions_model.StatusBlocked)
run2 := insertRun(1004, actions_model.StatusBlocked, true, 0)
insertJob(run2, actions_model.StatusBlocked)
approved, err := ApproveRuns(t.Context(), repo, doer, []int64{run2.ID, run1.ID})
require.NoError(t, err)
require.Len(t, approved, 2)
assert.Equal(t, run2.ID, approved[0].ID)
assert.Equal(t, run1.ID, approved[1].ID)
assert.False(t, approved[0].NeedApproval)
assert.False(t, approved[1].NeedApproval)
})
}