ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-23 05:03:39 +09:00
Code Issues Projects Releases Wiki Activity

refactor(modelmigration): thread context through migration functions (#38758)

Browse Source 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Copilot
2026-08-03 08:13:15 +00:00
committed by GitHub
co-authored by wxiaoguang
parent e23fe79e5e
commit ac49dbe1a2
304 changed files with 1070 additions and 449 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modelmigration/v1_17/v211.go
+6 -2
View File
@@ -3,8 +3,12 @@
package v1_17
import "gitea.dev/modelmigration/base"
import (
"context"
func CreateForeignReferenceTable(_ base.EngineMigration) error {
"gitea.dev/modelmigration/base"
)
func CreateForeignReferenceTable(_ context.Context, _ base.EngineMigration) error {
return nil // This table was dropped in v1_19/v237.go
}
modelmigration/v1_17/v212.go
+3 -1
View File
@@ -4,11 +4,13 @@
package v1_17
import (
"context"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/timeutil"
)
func AddPackageTables(x base.EngineMigration) error {
func AddPackageTables(_ context.Context, x base.EngineMigration) error {
type Package struct {
ID int64 `xorm:"pk autoincr"`
OwnerID int64 `xorm:"UNIQUE(s) INDEX NOT NULL"`
modelmigration/v1_17/v213.go
+6 -2
View File
@@ -3,9 +3,13 @@
package v1_17
import "gitea.dev/modelmigration/base"
import (
"context"
func AddAllowMaintainerEdit(x base.EngineMigration) error {
"gitea.dev/modelmigration/base"
)
func AddAllowMaintainerEdit(_ context.Context, x base.EngineMigration) error {
// PullRequest represents relation between pull request and repositories.
type PullRequest struct {
AllowMaintainerEdit bool `xorm:"NOT NULL DEFAULT false"`
modelmigration/v1_17/v214.go
+6 -2
View File
@@ -3,9 +3,13 @@
package v1_17
import "gitea.dev/modelmigration/base"
import (
"context"
func AddAutoMergeTable(x base.EngineMigration) error {
"gitea.dev/modelmigration/base"
)
func AddAutoMergeTable(_ context.Context, x base.EngineMigration) error {
type MergeStyle string
type PullAutoMerge struct {
ID int64 `xorm:"pk autoincr"`
modelmigration/v1_17/v215.go
+3 -1
View File
@@ -4,11 +4,13 @@
package v1_17
import (
"context"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/timeutil"
)
func AddReviewViewedFiles(x base.EngineMigration) error {
func AddReviewViewedFiles(_ context.Context, x base.EngineMigration) error {
type ReviewState struct {
ID int64 `xorm:"pk autoincr"`
UserID int64 `xorm:"NOT NULL UNIQUE(pull_commit_user)"`
modelmigration/v1_17/v217.go
+3 -1
View File
@@ -4,11 +4,13 @@
package v1_17
import (
"context"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/setting"
)
func AlterHookTaskTextFieldsToLongText(x base.EngineMigration) error {
func AlterHookTaskTextFieldsToLongText(_ context.Context, x base.EngineMigration) error {
sess := x.NewSession()
defer sess.Close()
if err := sess.Begin(); err != nil {
modelmigration/v1_17/v218.go
+3 -1
View File
@@ -4,6 +4,8 @@
package v1_17
import (
"context"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/setting"
"gitea.dev/modules/timeutil"
@@ -47,6 +49,6 @@ func (*improveActionTableIndicesAction) TableIndices() []*schemas.Index {
return indices
}
func ImproveActionTableIndices(x base.EngineMigration) error {
func ImproveActionTableIndices(_ context.Context, x base.EngineMigration) error {
return x.Sync(&improveActionTableIndicesAction{})
}
modelmigration/v1_17/v219.go
+2 -1
View File
@@ -4,13 +4,14 @@
package v1_17
import (
"context"
"time"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/timeutil"
)
func AddSyncOnCommitColForPushMirror(x base.EngineMigration) error {
func AddSyncOnCommitColForPushMirror(_ context.Context, x base.EngineMigration) error {
type PushMirror struct {
ID int64 `xorm:"pk autoincr"`
RepoID int64 `xorm:"INDEX"`
modelmigration/v1_17/v220.go
+3 -1
View File
@@ -4,6 +4,8 @@
package v1_17
import (
"context"
"gitea.dev/modelmigration/base"
packages_model "gitea.dev/models/packages" //nolint:depguard // only consts are used
container_module "gitea.dev/modules/packages/container"
@@ -11,7 +13,7 @@ import (
"xorm.io/xorm/schemas"
)
func AddContainerRepositoryProperty(x base.EngineMigration) (err error) {
func AddContainerRepositoryProperty(_ context.Context, x base.EngineMigration) (err error) {
switch x.Dialect().URI().DBType {
case schemas.SQLITE:
_, err = x.Exec("INSERT INTO package_property (ref_type, ref_id, name, value) SELECT ?, p.id, ?, u.lower_name || '/' || p.lower_name FROM package p JOIN `user` u ON p.owner_id = u.id WHERE p.type = ?",
modelmigration/v1_17/v221.go
+2 -1
View File
@@ -4,6 +4,7 @@
package v1_17
import (
"context"
"encoding/base32"
"fmt"
@@ -11,7 +12,7 @@ import (
"gitea.dev/modules/timeutil"
)
func StoreWebauthnCredentialIDAsBytes(x base.EngineMigration) error {
func StoreWebauthnCredentialIDAsBytes(_ context.Context, x base.EngineMigration) error {
// Create webauthnCredential table
type webauthnCredential struct {
ID int64 `xorm:"pk autoincr"`
modelmigration/v1_17/v221_test.go
+1 -1
View File
@@ -44,7 +44,7 @@ func Test_StoreWebauthnCredentialIDAsBytes(t *testing.T) {
return
}
if err := StoreWebauthnCredentialIDAsBytes(x); err != nil {
if err := StoreWebauthnCredentialIDAsBytes(t.Context(), x); err != nil {
assert.NoError(t, err)
return
}
modelmigration/v1_17/v222.go
+3 -3
View File
@@ -12,9 +12,9 @@ import (
"gitea.dev/modules/timeutil"
)
func DropOldCredentialIDColumn(x base.EngineMigration) error {
func DropOldCredentialIDColumn(ctx context.Context, x base.EngineMigration) error {
// This migration maybe rerun so that we should check if it has been run
credentialIDExist, err := x.Dialect().IsColumnExist(x.DB(), context.Background(), "webauthn_credential", "credential_id")
credentialIDExist, err := x.Dialect().IsColumnExist(x.DB(), ctx, "webauthn_credential", "credential_id")
if err != nil {
return err
}
@@ -22,7 +22,7 @@ func DropOldCredentialIDColumn(x base.EngineMigration) error {
// Column is already non-extant
return nil
}
credentialIDBytesExists, err := x.Dialect().IsColumnExist(x.DB(), context.Background(), "webauthn_credential", "credential_id_bytes")
credentialIDBytesExists, err := x.Dialect().IsColumnExist(x.DB(), ctx, "webauthn_credential", "credential_id_bytes")
if err != nil {
return err
}
modelmigration/v1_17/v223.go
+3 -3
View File
@@ -12,14 +12,14 @@ import (
"gitea.dev/modules/timeutil"
)
func RenameCredentialIDBytes(x base.EngineMigration) error {
func RenameCredentialIDBytes(ctx context.Context, x base.EngineMigration) error {
// This migration maybe rerun so that we should check if it has been run
credentialIDExist, err := x.Dialect().IsColumnExist(x.DB(), context.Background(), "webauthn_credential", "credential_id")
credentialIDExist, err := x.Dialect().IsColumnExist(x.DB(), ctx, "webauthn_credential", "credential_id")
if err != nil {
return err
}
if credentialIDExist {
credentialIDBytesExists, err := x.Dialect().IsColumnExist(x.DB(), context.Background(), "webauthn_credential", "credential_id_bytes")
credentialIDBytesExists, err := x.Dialect().IsColumnExist(x.DB(), ctx, "webauthn_credential", "credential_id_bytes")
if err != nil {
return err
}