ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-19 19:23:39 +09:00
Code Issues Projects Releases Wiki Activity

enhance: support ETag on streamed repository archives, support If-None-Match: * (#39289)

Browse Source 
Signed-off-by: silverwind <me@silverwind.io>
Co-authored-by: Claude (Opus 5) <noreply@anthropic.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-09-16 12:30:22 +02:00
committed by GitHub
co-authored by Claude wxiaoguang
parent 31b4d79a84
commit c04802b6b3
4 changed files with 65 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/repo_archive_test.go
+19 -1
View File
@@ -6,6 +6,7 @@ package integration
import (
"io"
"net/http"
"strings"
"testing"
"gitea.dev/modules/setting"
@@ -34,9 +35,26 @@ func TestRepoDownloadArchive(t *testing.T) {
assert.Len(t, bs, 320)
})
t.Run("Conditional", func(t *testing.T) {
defer test.MockVariableValue(&setting.Repository.StreamArchives, true)()
archiveURL := "/user2/glob/archive/master.tar.gz"
etag := MakeRequest(t, NewRequest(t, "GET", archiveURL), http.StatusOK).Header().Get("ETag")
assert.True(t, strings.HasPrefix(etag, `W/"`))
MakeRequest(t, NewRequest(t, "GET", archiveURL).SetHeader("If-None-Match", etag), http.StatusNotModified)
MakeRequest(t, NewRequest(t, "GET", archiveURL+"?path=aaa.doc").SetHeader("If-None-Match", etag), http.StatusOK)
assert.NotEqual(t, etag, MakeRequest(t, NewRequest(t, "GET", "/user2/repo1/archive/master.tar.gz"), http.StatusOK).Header().Get("ETag"))
restoreStreaming := test.MockVariableValue(&setting.Repository.StreamArchives, false)
MakeRequest(t, NewRequest(t, "GET", archiveURL).SetHeader("If-None-Match", etag), http.StatusOK)
restoreStreaming()
defer test.MockVariableValue(&setting.Repository.PrefixArchiveFiles, !setting.Repository.PrefixArchiveFiles)()
MakeRequest(t, NewRequest(t, "GET", archiveURL).SetHeader("If-None-Match", etag), http.StatusOK)
})
t.Run("SubPath", func(t *testing.T) {
// When using "archiving and caching" approach, archiving with paths will always use streaming and never be cached
defer test.MockVariableValue(&setting.Repository.StreamArchives, false) // this can be removed if there is always streaming mode
defer test.MockVariableValue(&setting.Repository.StreamArchives, false)() // this can be removed if there is always streaming mode
req := NewRequest(t, "GET", "/user2/glob/archive/master.tar.gz?path=aaa.doc&path=x/y")
resp := MakeRequest(t, req, http.StatusOK)
content, err := test.ReadAllTarGzContent(resp.Body)