ynkmr/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-20 11:43:40 +09:00
Code Issues Projects Releases Wiki Activity

fix: allow re-requesting uncounted review approvals (#38988)

Browse Source
This commit is contained in:
Harsh Sharma
2026-09-08 15:59:06 +00:00
committed by GitHub
parent c9193adb68
commit d93bd06d0c
9 changed files with 160 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/pull_review_test.go
+5
View File
@@ -161,6 +161,11 @@ func TestPullView_CodeOwner(t *testing.T) {
hasCodeownerReviews = issue_service.HasAllRequiredCodeownerReviews(t.Context(), &protectBranch, pr)
assert.True(t, hasCodeownerReviews)
_, err = issue_service.ReviewRequest(t.Context(), pr.Issue, user5, nil, user5, true)
assert.NoError(t, err)
hasCodeownerReviews = issue_service.HasAllRequiredCodeownerReviews(t.Context(), &protectBranch, pr)
assert.False(t, hasCodeownerReviews)
// a later requested-changes review from a required code owner must override
// that user's earlier approval and no longer satisfy the requirement
_, _, err = issues_model.SubmitReview(t.Context(), user5, pr.Issue, issues_model.ReviewTypeReject, "Needs changes", resp.Commit.SHA, false, make([]string, 0))