Use ID or Where to instead directly use Get when load object from database (#11925) (#11935)

Backport #11925

Use ID or Where to instead directly use Get when load object from database

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
6543
2020-06-17 20:54:26 +01:00
committed by GitHub
co-authored by Lunny Xiao
parent 313ace93d0
commit dbe9c11238
9 changed files with 25 additions and 29 deletions
+2 -5
View File
@@ -212,11 +212,8 @@ func getLabelInRepoByName(e Engine, repoID int64, labelName string) (*Label, err
return nil, ErrLabelNotExist{0, repoID}
}
l := &Label{
Name: labelName,
RepoID: repoID,
}
has, err := e.Get(l)
l := &Label{}
has, err := e.Where("name=? AND repo_id=?", labelName, repoID).Get(l)
if err != nil {
return nil, err
} else if !has {