feat: execute post run cleanup when workflow is cancelled (#37275)

mirror of https://github.com/go-gitea/gitea.git synced 2026-09-08 14:03:24 +09:00

## Fixes #36983

## Summary
1. Add transitional `Cancelling` status (between `Running` and
`Cancelled`); cancel flow marks active tasks `Cancelling`, runner
finalizes to `Cancelled` on terminal result.
2. Taskless jobs cancel directly (no runner to finalize).
3. Runner-protocol responses map `Cancelling` → `RESULT_CANCELLED`.
4. Run/job aggregation treats `Cancelling` as active.
5. Status mapping/aggregation tests + en-US locale added.

**Problem**
When a workflow was cancelled from the UI, jobs were marked cancelled
immediately, which could skip post-run cleanup behavior.

## Solution
Use a transitional status path:
Running → Cancelling → Cancelled
This allows runner finalization and cleanup path execution before final
terminal state.

**Testing**

> 1. go test -tags "sqlite sqlite_unlock_notify" ./models/actions -run
"TestAggregateJobStatus|TestStatusAsResult|TestStatusFromResult"
> 2. go run
github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.4 run
./models/actions/... ./routers/api/actions/runner/...

## Related
- act_runner: https://gitea.com/gitea/act_runner/pulls/825 —
independent; this PR's capability gate keeps legacy runners on the
immediate-cancel path. The new flow activates only for runners that
advertise the `cancelling` capability.

Co-authored-by: Nicolas <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>

This commit is contained in:

Kalash Thakare ☯︎

2026-05-17 08:41:39 +02:00

committed by

GitHub

co-authored by

Nicolas

silverwind

Claude

Zettat123

Giteabot

parent ae9b34897f

commit e7af84df72

31 changed files with 786 additions and 111 deletions

									
										models/migrations/migrations.go
									
		+1
		
												View File
												
				@@ -411,6 +411,7 @@ func prepareMigrationTasks() []*migration {

						newMigration(331, "Add ActionRunAttempt model and related action fields", v1_27.AddActionRunAttemptModel),

						newMigration(332, "Add last_sync_unix to mirror", v1_27.AddLastSyncUnixToMirror),

						newMigration(333, "Add bypass allowlist to branch protection", v1_27.AddBranchProtectionBypassAllowlist),

						newMigration(334, "Add cancelling support to action runners", v1_27.AddCancellingSupportToActionRunner),

					}

					return preparedMigrations

				}