refactor(templates): update djlint to 1.46.0 and resolve its new findings (#39231)

templates/repo/settings/actions_general.tmpl

@@ -17,7 +17,7 @@
 			{{if not $isActionsGlobalDisabled}}
 			<div class="divider"></div>
 				<div class="field">
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 			</div>
 			{{end}}
 		</form>
@@ -48,7 +48,7 @@
 			</div>
 
 			<div class="field">
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 			</div>
 		</form>
 	</div>
@@ -74,7 +74,7 @@
 					</div>
 				</div>
 				<div class="item-trailing">
-					<button class="ui red tiny button inline link-action"
+					<button type="button" class="ui red tiny button inline link-action"
 						data-url="{{$.Link}}/collaborative_owner/delete?id={{.ID}}"
 						data-modal-confirm-header="{{ctx.Locale.Tr "actions.general.remove_collaborative_owner"}}"
 						data-modal-confirm-content="{{ctx.Locale.Tr "actions.general.remove_collaborative_owner_desc"}}"
@@ -90,7 +90,7 @@
 			<div id="search-user-box" class="ui search input" data-include-orgs="true">
 				<input class="prompt" name="collaborative_owner" placeholder="{{ctx.Locale.Tr "search.user_kind"}}" autocomplete="off" autofocus required>
 			</div>
-			<button class="ui primary button">{{ctx.Locale.Tr "actions.general.add_collaborative_owner"}}</button>
+			<button type="submit" class="ui primary button">{{ctx.Locale.Tr "actions.general.add_collaborative_owner"}}</button>
 		</form>
 		<br>
 		{{ctx.Locale.Tr "actions.general.collaborative_owners_management_help"}}

templates/repo/settings/branches.tmpl

@@ -23,7 +23,7 @@
 								{{end}}
 							</div>
 						</div>
-						<button class="ui primary button"{{if .Repository.IsEmpty}} disabled{{end}}>{{ctx.Locale.Tr "repo.settings.branches.update_default_branch"}}</button>
+						<button type="submit" class="ui primary button"{{if .Repository.IsEmpty}} disabled{{end}}>{{ctx.Locale.Tr "repo.settings.branches.update_default_branch"}}</button>
 					</div>
 					<div class="help tw-mt-4 tw-p-0">{{ctx.Locale.Tr "repo.settings.default_target_branch_desc"}}</div>
 				</form>
@@ -50,7 +50,7 @@
 							</div>
 							<div class="item-trailing">
 								<a class="ui tiny button" href="{{$.Repository.Link}}/settings/branches/edit?rule_name={{.RuleName}}">{{ctx.Locale.Tr "repo.settings.edit_protected_branch"}}</a>
-								<button class="ui red tiny button link-action" data-modal-confirm="#repo-branch-protection-delete-modal" data-url="{{$.Repository.Link}}/settings/branches/{{.ID}}/delete?id={{.ID}}">
+								<button type="button" class="ui red tiny button link-action" data-modal-confirm="#repo-branch-protection-delete-modal" data-url="{{$.Repository.Link}}/settings/branches/{{.ID}}/delete?id={{.ID}}">
 									{{ctx.Locale.Tr "repo.settings.protected_branch.delete_rule"}}
 								</button>
 							</div>

templates/repo/settings/collaboration.tmpl

@@ -29,7 +29,7 @@
 									</div>
 								</div>
 							</div>
-							<button class="ui red tiny button link-action" data-modal-confirm="#repo-collaborator-delete-modal" data-url="{{$.Link}}/delete?id={{.ID}}">
+							<button type="button" class="ui red tiny button link-action" data-modal-confirm="#repo-collaborator-delete-modal" data-url="{{$.Link}}/delete?id={{.ID}}">
 								{{ctx.Locale.Tr "repo.settings.delete_collaborator"}}
 							</button>
 						</div>
@@ -43,7 +43,7 @@
 				<div id="search-user-box" class="ui search input">
 					<input class="prompt" name="collaborator" placeholder="{{ctx.Locale.Tr "search.user_kind"}}" autocomplete="off" autofocus required>
 				</div>
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_collaborator"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_collaborator"}}</button>
 			</form>
 		</div>
 
@@ -91,7 +91,7 @@
 							</div>
 							{{if $allowedToChangeTeams}}
 								<div class="item-trailing" {{if .IncludesAllRepositories}} data-tooltip-content="{{ctx.Locale.Tr "repo.settings.delete_team_tip"}}"{{end}}>
-									<button class="ui red tiny button link-action {{if .IncludesAllRepositories}}disabled{{end}}" data-modal-confirm="#repo-collaborator-delete-modal" data-url="{{$.Link}}/team/delete?id={{.ID}}">
+									<button type="button" class="ui red tiny button link-action {{if .IncludesAllRepositories}}disabled{{end}}" data-modal-confirm="#repo-collaborator-delete-modal" data-url="{{$.Link}}/team/delete?id={{.ID}}">
 											{{ctx.Locale.Tr "repo.settings.delete_collaborator"}}
 									</button>
 								</div>
@@ -107,7 +107,7 @@
 						<div id="search-team-box" class="ui search input" data-org-name="{{.OrgName}}">
 							<input class="prompt" name="team" placeholder="{{ctx.Locale.Tr "search.team_kind"}}" autocomplete="off" required>
 						</div>
-						<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_team"}}</button>
+						<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_team"}}</button>
 					</form>
 				{{else}}
 					<div class="item">

templates/repo/settings/deploy_key_list.tmpl

@@ -28,11 +28,11 @@
 				</div>
 				<div class="item-trailing">
 					{{if $key.IsKeyTypeToken}}
-						<button class="ui tiny button link-action" data-modal-confirm="#repo-deploy-token-regenerate-modal" data-url="{{ctx.RootData.Link}}/regenerate-token?id={{$key.ID}}">
+						<button type="button" class="ui tiny button link-action" data-modal-confirm="#repo-deploy-token-regenerate-modal" data-url="{{ctx.RootData.Link}}/regenerate-token?id={{$key.ID}}">
 							{{svg "octicon-sync"}} {{ctx.Locale.Tr "settings.regenerate_token"}}
 						</button>
 					{{end}}
-					<button class="ui red tiny button link-action" data-modal-confirm="#repo-deploy-key-delete-modal" data-url="{{ctx.RootData.Link}}/delete?id={{$key.ID}}">
+					<button type="button" class="ui red tiny button link-action" data-modal-confirm="#repo-deploy-key-delete-modal" data-url="{{ctx.RootData.Link}}/delete?id={{$key.ID}}">
 						{{ctx.Locale.Tr "settings.delete_key"}}
 					</button>
 				</div>

templates/repo/settings/deploy_keys.tmpl

@@ -4,11 +4,11 @@
 		{{ctx.Locale.Tr "repo.settings.deploy_keys"}}
 		<div class="ui right">
 			{{if not .DisableSSH}}
-			<button class="ui primary compact tiny button show-panel toggle" data-panel="#add-deploy-key-ssh-panel" data-panel-hide="#add-deploy-key-token-panel">{{ctx.Locale.Tr "repo.settings.add_deploy_key_ssh"}}</button>
+			<button type="button" class="ui primary compact tiny button show-panel toggle" data-panel="#add-deploy-key-ssh-panel" data-panel-hide="#add-deploy-key-token-panel">{{ctx.Locale.Tr "repo.settings.add_deploy_key_ssh"}}</button>
 			{{else}}
-			<button class="ui primary compact tiny button disabled">{{ctx.Locale.Tr "settings.ssh_disabled"}}</button>
+			<button type="button" class="ui primary compact tiny button disabled">{{ctx.Locale.Tr "settings.ssh_disabled"}}</button>
 			{{end}}
-			<button class="ui primary compact tiny button show-panel toggle" data-panel="#add-deploy-key-token-panel" data-panel-hide="#add-deploy-key-ssh-panel">{{ctx.Locale.Tr "repo.settings.generate_deploy_token"}}</button>
+			<button type="button" class="ui primary compact tiny button show-panel toggle" data-panel="#add-deploy-key-token-panel" data-panel-hide="#add-deploy-key-ssh-panel">{{ctx.Locale.Tr "repo.settings.generate_deploy_token"}}</button>
 		</div>
 	</h4>
 	<div class="ui attached segment">
@@ -30,8 +30,8 @@
 						<small class="tw-pl-[20px]">{{ctx.Locale.Tr "repo.settings.is_writable_info"}}</small>
 					</div>
 				</div>
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_deploy_key_ssh"}}</button>
-				<button class="ui hide-panel button" data-panel="#add-deploy-key-ssh-panel">{{ctx.Locale.Tr "cancel"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_deploy_key_ssh"}}</button>
+				<button type="button" class="ui hide-panel button" data-panel="#add-deploy-key-ssh-panel">{{ctx.Locale.Tr "cancel"}}</button>
 			</form>
 			<div class="divider"></div>
 		</div>
@@ -50,8 +50,8 @@
 						<small class="tw-pl-[20px]">{{ctx.Locale.Tr "repo.settings.is_writable_info"}}</small>
 					</div>
 				</div>
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.generate_deploy_token"}}</button>
-				<button class="ui hide-panel button" data-panel="#add-deploy-key-token-panel">{{ctx.Locale.Tr "cancel"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.generate_deploy_token"}}</button>
+				<button type="button" class="ui hide-panel button" data-panel="#add-deploy-key-token-panel">{{ctx.Locale.Tr "cancel"}}</button>
 			</form>
 			<div class="divider"></div>
 		</div>

templates/repo/settings/githook_edit.tmpl

@@ -19,7 +19,7 @@
 				{{end}}
 			</div>
 			<div class="ui attached segment">
-				<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_githook"}}</button>
+				<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_githook"}}</button>
 			</div>
 		</form>
 	</div>

templates/repo/settings/lfs.tmpl

@@ -20,7 +20,7 @@
 						<td>{{DateUtils.TimeSince .CreatedUnix}}</td>
 						<td class="tw-text-right">
 							<a class="ui primary button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{ctx.Locale.Tr "repo.settings.lfs_findcommits"}}</a>
-							<button class="ui basic show-modal icon button red" data-modal="#delete-{{.Oid}}">
+							<button type="button" class="ui basic show-modal icon button red" data-modal="#delete-{{.Oid}}">
 								<span class="btn-octicon btn-octicon-danger" data-tooltip-content="{{ctx.Locale.Tr "repo.editor.delete_this_file"}}">{{svg "octicon-trash"}}</span>
 							</button>
 						</td>

templates/repo/settings/lfs_locks.tmpl

@@ -8,7 +8,7 @@
 				<form class="ui form ignore-dirty" method="post">
 					<div class="ui fluid action input">
 						<input name="path" value="" placeholder="{{ctx.Locale.Tr "repo.settings.lfs_lock_path"}}" autofocus>
-						<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.lfs_lock"}}</button>
+						<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.lfs_lock"}}</button>
 					</div>
 				</form>
 			</div>
@@ -37,7 +37,7 @@
 							<td>{{DateUtils.TimeSince .Created}}</td>
 							<td class="tw-text-right">
 								<form action="{{$.LFSFilesLink}}/locks/{{$lock.ID}}/unlock" method="post">
-									<button class="ui primary button"><span class="btn-octicon">{{svg "octicon-lock"}}</span>{{ctx.Locale.Tr "repo.settings.lfs_force_unlock"}}</button>
+									<button type="submit" class="ui primary button"><span class="btn-octicon">{{svg "octicon-lock"}}</span>{{ctx.Locale.Tr "repo.settings.lfs_force_unlock"}}</button>
 								</form>
 							</td>
 						</tr>

templates/repo/settings/lfs_pointers.tmpl

@@ -10,7 +10,7 @@
 								<input type="hidden" name="oid" value="{{.Oid}} {{.Size}}">
 							{{end}}
 						{{end}}
-						<button class="ui primary tiny button">{{ctx.Locale.Tr "repo.settings.lfs_pointers.associateAccessible" $.NumAssociatable}}</button>
+						<button type="submit" class="ui primary tiny button">{{ctx.Locale.Tr "repo.settings.lfs_pointers.associateAccessible" $.NumAssociatable}}</button>
 					</form>
 				</div>
 			{{end}}

templates/repo/settings/options.tmpl

@@ -31,7 +31,7 @@
 					<input id="website" name="website" type="url" maxlength="1024" value="{{.Repository.Website}}">
 				</div>
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 				</div>
 			</form>
 
@@ -41,8 +41,8 @@
 					{{template "shared/avatar_upload_crop" dict "LabelText" (ctx.Locale.Tr "settings.choose_new_avatar")}}
 				</div>
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "settings.update_avatar"}}</button>
-					<button class="ui red button link-action" data-url="{{.Link}}/avatar/delete">{{ctx.Locale.Tr "settings.delete_current_avatar"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "settings.update_avatar"}}</button>
+					<button type="button" class="ui red button link-action" data-url="{{.Link}}/avatar/delete">{{ctx.Locale.Tr "settings.delete_current_avatar"}}</button>
 				</div>
 			</form>
 		</div>
@@ -69,25 +69,35 @@
 					</div>
 				{{else}}
 					{{if $newMirrorsEntirelyEnabled}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs"}}
-						<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pushing-to-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br><br>
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.pull_mirror_instructions"}}
-						<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_pull_section"}}</a><br>
+						<p>
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs"}}
+							<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pushing-to-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a>
+						</p>
+						<p>
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.pull_mirror_instructions"}}
+							<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_pull_section"}}</a>
+						</p>
 					{{else if $onlyNewPushMirrorsEnabled}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_pull_mirror.instructions"}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
-						<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br>
+						<p>
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_pull_mirror.instructions"}}
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
+							<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a>
+						</p>
 					{{else if $onlyNewPullMirrorsEnabled}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.instructions"}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.pull_mirror_warning"}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
-						<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a><br><br>
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.info"}}
-						{{if $existingPushMirror}}
-							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.can_still_use"}}
-						{{end}}
+						<p>
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.instructions"}}
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.pull_mirror_warning"}}
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.more_information_if_disabled"}}
+							<a target="_blank" href="https://docs.gitea.com/usage/repo-mirror#pulling-from-a-remote-repository">{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.doc_link_title"}}</a>
+						</p>
+						<p>
+							{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.disabled_push_mirror.info"}}
+							{{if $existingPushMirror}}
+								{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.can_still_use"}}
+							{{end}}
+						</p>
 					{{else}}
-						{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.no_new_mirrors"}} {{ctx.Locale.Tr "repo.settings.mirror_settings.docs.can_still_use"}}<br>
+						<p>{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.no_new_mirrors"}} {{ctx.Locale.Tr "repo.settings.mirror_settings.docs.can_still_use"}}</p>
 					{{end}}
 
 					{{if .Repository.IsMirror}}
@@ -118,7 +128,7 @@
 								<td class="tw-text-right">
 									<form method="post" class="tw-inline-block">
 										<input type="hidden" name="action" value="mirror-sync">
-										<button class="ui primary tiny button inline">{{ctx.Locale.Tr "repo.settings.sync_mirror"}}</button>
+										<button type="submit" class="ui primary tiny button inline">{{ctx.Locale.Tr "repo.settings.sync_mirror"}}</button>
 									</form>
 								</td>
 							</tr>
@@ -176,7 +186,7 @@
 										</div>
 										{{end}}
 										<div class="field">
-											<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_mirror_settings"}}</button>
+											<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_mirror_settings"}}</button>
 										</div>
 									</form>
 								</td>
@@ -212,6 +222,7 @@
 								</td>
 								<td class="tw-text-right">
 									<button
+										type="button"
 										class="ui tiny button show-modal"
 										data-modal="#push-mirror-edit-modal"
 										data-tooltip-content="{{ctx.Locale.Tr "repo.settings.mirror_settings.push_mirror.edit_sync_time"}}"
@@ -224,12 +235,12 @@
 									<form method="post" class="tw-inline-block">
 										<input type="hidden" name="action" value="push-mirror-sync">
 										<input type="hidden" name="push_mirror_id" value="{{.ID}}">
-										<button class="ui primary tiny button" data-tooltip-content="{{ctx.Locale.Tr "repo.settings.sync_mirror"}}">{{svg "octicon-sync" 14}}</button>
+										<button type="submit" class="ui primary tiny button" data-tooltip-content="{{ctx.Locale.Tr "repo.settings.sync_mirror"}}">{{svg "octicon-sync" 14}}</button>
 									</form>
 									<form method="post" class="tw-inline-block">
 										<input type="hidden" name="action" value="push-mirror-remove">
 										<input type="hidden" name="push_mirror_id" value="{{.ID}}">
-										<button class="ui basic red tiny button" data-tooltip-content="{{ctx.Locale.Tr "remove"}}">{{svg "octicon-trash" 14}}</button>
+										<button type="submit" class="ui basic red tiny button" data-tooltip-content="{{ctx.Locale.Tr "remove"}}">{{svg "octicon-trash" 14}}</button>
 									</form>
 								</td>
 							</tr>
@@ -275,7 +286,7 @@
 												<input id="push_mirror_interval" name="push_mirror_interval" value="{{if .push_mirror_interval}}{{.push_mirror_interval}}{{else}}{{.DefaultMirrorInterval}}{{end}}">
 											</div>
 											<div class="field">
-												<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.mirror_settings.push_mirror.add"}}</button>
+												<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.mirror_settings.push_mirror.add"}}</button>
 											</div>
 										</form>
 									</td>
@@ -668,7 +679,7 @@
 
 				<div class="divider"></div>
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 				</div>
 			</form>
 		</div>
@@ -713,7 +724,7 @@
 
 				<div class="divider"></div>
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 				</div>
 			</form>
 		</div>
@@ -733,7 +744,7 @@
 				</div>
 
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 				</div>
 			</form>
 
@@ -754,7 +765,7 @@
 							{{end}}
 						</span>
 						<div class="field">
-							<button class="ui primary button" name="request_reindex_type" value="code">{{ctx.Locale.Tr "repo.settings.reindex_button"}}</button>
+							<button type="submit" class="ui primary button" name="request_reindex_type" value="code">{{ctx.Locale.Tr "repo.settings.reindex_button"}}</button>
 						</div>
 					</div>
 				{{end}}
@@ -773,7 +784,7 @@
 						{{end}}
 					</span>
 					<div class="field">
-						<button class="ui primary button" name="request_reindex_type" value="stats">{{ctx.Locale.Tr "repo.settings.reindex_button"}}</button>
+						<button type="submit" class="ui primary button" name="request_reindex_type" value="stats">{{ctx.Locale.Tr "repo.settings.reindex_button"}}</button>
 					</div>
 				</div>
 			</form>
@@ -797,7 +808,7 @@
 							{{end}}
 						</div>
 						<div class="item-trailing">
-							<button class="ui basic red show-modal button" data-modal="#visibility-repo-modal">
+							<button type="button" class="ui basic red show-modal button" data-modal="#visibility-repo-modal">
 								{{if .Repository.IsPrivate}}
 									{{ctx.Locale.Tr "repo.settings.visibility.public.button"}}
 								{{else}}
@@ -814,7 +825,7 @@
 							<div class="item-body">{{ctx.Locale.Tr "repo.settings.convert_desc"}}</div>
 						</div>
 						<div class="item-trailing">
-							<button class="ui basic red show-modal button" data-modal="#convert-mirror-repo-modal">{{ctx.Locale.Tr "repo.settings.convert"}}</button>
+							<button type="button" class="ui basic red show-modal button" data-modal="#convert-mirror-repo-modal">{{ctx.Locale.Tr "repo.settings.convert"}}</button>
 						</div>
 					</div>
 				{{end}}
@@ -825,7 +836,7 @@
 							<div class="item-body">{{ctx.Locale.Tr "repo.settings.convert_fork_desc"}}</div>
 						</div>
 						<div class="item-trailing">
-							<button class="ui basic red show-modal button" data-modal="#convert-fork-repo-modal">{{ctx.Locale.Tr "repo.settings.convert_fork"}}</button>
+							<button type="button" class="ui basic red show-modal button" data-modal="#convert-fork-repo-modal">{{ctx.Locale.Tr "repo.settings.convert_fork"}}</button>
 						</div>
 					</div>
 				{{end}}
@@ -844,10 +855,10 @@
 						{{if .RepoTransfer}}
 							<form class="ui form" action="{{.Link}}" method="post">
 								<input type="hidden" name="action" value="cancel_transfer">
-								<button class="ui red button">{{ctx.Locale.Tr "repo.settings.transfer_abort"}}</button>
+								<button type="submit" class="ui red button">{{ctx.Locale.Tr "repo.settings.transfer_abort"}}</button>
 							</form>
 						{{else}}
-							<button class="ui basic red show-modal button" data-modal="#transfer-repo-modal">{{ctx.Locale.Tr "repo.settings.transfer"}}</button>
+							<button type="button" class="ui basic red show-modal button" data-modal="#transfer-repo-modal">{{ctx.Locale.Tr "repo.settings.transfer"}}</button>
 						{{end}}
 					</div>
 				</div>
@@ -858,7 +869,7 @@
 							<div class="item-body">{{ctx.Locale.Tr "repo.settings.wiki_delete_desc"}}</div>
 						</div>
 						<div class="item-trailing">
-							<button class="ui basic red show-modal button" data-modal="#delete-wiki-modal">{{ctx.Locale.Tr "repo.settings.wiki_delete"}}</button>
+							<button type="button" class="ui basic red show-modal button" data-modal="#delete-wiki-modal">{{ctx.Locale.Tr "repo.settings.wiki_delete"}}</button>
 						</div>
 					</div>
 				{{end}}
@@ -868,7 +879,7 @@
 						<div class="item-body">{{ctx.Locale.Tr "repo.settings.delete_desc"}}</div>
 					</div>
 					<div class="item-trailing">
-						<button class="ui basic red show-modal button" data-modal="#delete-repo-modal">{{ctx.Locale.Tr "repo.settings.delete"}}</button>
+						<button type="button" class="ui basic red show-modal button" data-modal="#delete-repo-modal">{{ctx.Locale.Tr "repo.settings.delete"}}</button>
 					</div>
 				</div>
 				{{if not .Repository.IsMirror}}
@@ -883,7 +894,7 @@
 							{{end}}
 						</div>
 						<div class="item-trailing">
-							<button class="ui basic red show-modal button" data-modal="#archive-repo-modal">
+							<button type="button" class="ui basic red show-modal button" data-modal="#archive-repo-modal">
 								{{if .Repository.IsArchived}}
 									{{ctx.Locale.Tr "repo.settings.unarchive.button"}}
 								{{else}}

templates/repo/settings/protected_branch.tmpl

@@ -386,7 +386,7 @@
 				<div class="divider"></div>
 
 				<div class="field">
-					<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.protected_branch.save_rule"}}</button>
+					<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.protected_branch.save_rule"}}</button>
 				</div>
 			</div>
 		</form>

templates/repo/settings/public_access.tmpl

@@ -46,7 +46,7 @@
 				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.everyone_read"}}</li>
 				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.everyone_write"}}</li>
 			</ul>
-			<button class="ui primary button {{if .GlobalForcePrivate}}disabled{{end}}">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
+			<button type="submit" class="ui primary button {{if .GlobalForcePrivate}}disabled{{end}}">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 		</form>
 	</div>
 </div>

templates/repo/settings/push_mirror_sync_modal.tmpl

@@ -14,11 +14,11 @@
 			<input id="push-mirror-edit-interval" name="push_mirror_interval" class="tw-w-auto">
 		</div>
 		<div class="actions">
-			<button class="ui small basic cancel button">
+			<button type="button" class="ui small basic cancel button">
 				{{svg "octicon-x"}}
 				{{ctx.Locale.Tr "cancel"}}
 			</button>
-			<button class="ui primary small approve button">
+			<button type="submit" class="ui primary small approve button">
 				{{svg "fontawesome-save"}}
 				{{ctx.Locale.Tr "save"}}
 			</button>

templates/repo/settings/tags.tmpl

@@ -56,14 +56,14 @@
 								{{end}}
 								<div class="field">
 									{{if .PageIsEditProtectedTag}}
-									<button class="ui primary button">
+									<button type="submit" class="ui primary button">
 										{{ctx.Locale.Tr "save"}}
 									</button>
 									<a class="ui primary button" href="{{$.RepoLink}}/settings/tags">
 										{{ctx.Locale.Tr "cancel"}}
 									</a>
 									{{else}}
-									<button class="ui primary button">
+									<button type="submit" class="ui primary button">
 										{{ctx.Locale.Tr "repo.settings.tags.protection.create"}}
 									</button>
 									{{end}}
@@ -107,7 +107,7 @@
 											<a class="ui tiny primary button" href="{{$.RepoLink}}/settings/tags/{{.ID}}">{{ctx.Locale.Tr "edit"}}</a>
 											<form class="tw-inline-block" action="{{$.RepoLink}}/settings/tags/delete" method="post">
 												<input type="hidden" name="id" value="{{.ID}}">
-												<button class="ui tiny red button">{{ctx.Locale.Tr "remove"}}</button>
+												<button type="submit" class="ui tiny red button">{{ctx.Locale.Tr "remove"}}</button>
 											</form>
 										</td>
 									</tr>

templates/repo/settings/webhook/history.tmpl

@@ -2,7 +2,7 @@
 	<h4 class="ui top attached header flex-left-right">
 		<span>{{ctx.Locale.Tr "repo.settings.recent_deliveries"}}</span>
 		{{if .Permission.IsAdmin}}
-			<button class="ui tiny button" id="test-delivery" data-link="{{.Link}}/test"
+			<button type="button" class="ui tiny button" id="test-delivery" data-link="{{.Link}}/test"
 				data-tooltip-content="{{ctx.Locale.Tr "repo.settings.webhook.test_delivery_desc"}}"
 			>
 				{{ctx.Locale.Tr "repo.settings.webhook.test_delivery"}}
@@ -22,7 +22,7 @@
 							{{else}}
 								<span class="tw-text-red">{{svg "octicon-alert"}}</span>
 							{{end}}
-							<button class="btn interact-bg tw-p-2 toggle show-panel" data-panel="#info-{{.ID}}">{{.UUID}}</button>
+							<button type="button" class="btn interact-bg tw-p-2 toggle show-panel" data-panel="#info-{{.ID}}">{{.UUID}}</button>
 						</div>
 						<span class="tw-text-text-light">
 							{{DateUtils.TimeSince .Delivered}}
@@ -49,7 +49,7 @@
 							<div class="right menu">
 								<form class="tw-py-2" action="{{$.Link}}/replay/{{.UUID}}" method="post">
 									<span data-tooltip-content="{{if $.Webhook.IsActive}}{{ctx.Locale.Tr "repo.settings.webhook.replay.description"}}{{else}}{{ctx.Locale.Tr "repo.settings.webhook.replay.description_disabled"}}{{end}}">
-										<button class="ui tiny button tw-mr-0{{if not $.Webhook.IsActive}} disabled{{end}}">{{svg "octicon-sync"}}</button>
+										<button type="submit" class="ui tiny button tw-mr-0{{if not $.Webhook.IsActive}} disabled{{end}}">{{svg "octicon-sync"}}</button>
 									</span>
 								</form>
 							</div>

templates/repo/settings/webhook/settings.tmpl

@@ -351,9 +351,9 @@
 
 <div class="field">
 	{{if $isNew}}
-		<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_webhook"}}</button>
+		<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_webhook"}}</button>
 	{{else}}
-		<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_webhook"}}</button>
+		<button type="submit" class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_webhook"}}</button>
 		<a class="ui red button link-action"
 			data-url="{{.BaseLink}}/delete?id={{.Webhook.ID}}"
 			data-modal-confirm="{{ctx.Locale.Tr "repo.settings.webhook_deletion_desc"}}"