mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-25 22:23:42 +09:00
Updates actionslib to https://gitea.com/gitea/actionslib/releases/tag/v1.2.1, moves workflow parsing into it and aligns behaviour with GitHub. 1. `uses:` supports `self:` (Gitea-only feature) and `$/` paths. 1. `strategy`, `matrix`, `max-parallel` and `fail-fast` accept expressions, including over `needs`. A job whose `name`, `runs-on` or `continue-on-error` reads `needs` is resolved once they finish. 1. A job `if:` may only read `github`, `needs`, `vars` and `inputs` and is decided before the matrix, as on github.com. 1. Matrix `fail-fast` cancels the other combinations, and `always()` jobs keep running when a run is cancelled. 1. Invalid workflow files, including a malformed `on:` and unknown or cyclic `needs`, show up on push as failed runs with the error. 1. A job whose `if:` or `concurrency:` fails to evaluate is skipped or failed with the error, instead of staying blocked. 1. Reusable workflows: a missing and an unreadable repository fail alike, public callers cannot use private workflows, nested jobs cannot exceed the caller's token permissions. 1. Runner labels match case-insensitively, and `runs-on` accepts an array from an expression. Runner PR: https://gitea.com/gitea/runner/pulls/1247 Docs PR: https://gitea.com/gitea/docs/pulls/553 Fixes: https://github.com/go-gitea/gitea/issues/38990 Fixes: https://github.com/go-gitea/gitea/issues/39382 Fixes: https://github.com/go-gitea/gitea/issues/32364 Fixes: https://github.com/go-gitea/gitea/issues/36077 Fixes: https://github.com/go-gitea/gitea/issues/23277 Fixes: https://github.com/go-gitea/gitea/issues/29020 Co-authored-by: Claude (Opus 5) <noreply@anthropic.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
82 lines
3.0 KiB
Go
82 lines
3.0 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"gitea.dev/actionslib/pkg/expreval"
|
|
actions_model "gitea.dev/models/actions"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/modules/actions/jobparser"
|
|
)
|
|
|
|
// CancelRun cancels a run's cancellable jobs and returns the run's post-cancellation state.
|
|
// A runner that supports it gets to run its post-cancel cleanup before the job reaches its final status.
|
|
func CancelRun(ctx context.Context, run *actions_model.ActionRun, jobs []*actions_model.ActionRunJob) (*actions_model.ActionRun, error) {
|
|
return cancelRun(ctx, run, jobs, false)
|
|
}
|
|
|
|
// ForceCancelRun cancels a run like CancelRun, but does not wait for the runners to acknowledge it:
|
|
// the jobs are marked cancelled at once and whatever a runner reports for them afterwards is discarded.
|
|
func ForceCancelRun(ctx context.Context, run *actions_model.ActionRun, jobs []*actions_model.ActionRunJob) (*actions_model.ActionRun, error) {
|
|
return cancelRun(ctx, run, jobs, true)
|
|
}
|
|
|
|
func cancelRun(ctx context.Context, run *actions_model.ActionRun, jobs []*actions_model.ActionRunJob, force bool) (*actions_model.ActionRun, error) {
|
|
var updatedJobs []*actions_model.ActionRunJob
|
|
if err := db.WithTx(ctx, func(ctx context.Context) (err error) {
|
|
updatedJobs, err = actions_model.CancelJobs(ctx, cancellableJobs(run, jobs, force), force)
|
|
if err != nil {
|
|
return fmt.Errorf("CancelJobs: %w", err)
|
|
}
|
|
if len(updatedJobs) > 0 {
|
|
return nil // a job update already refreshed the run
|
|
}
|
|
return actions_model.SettleRunAfterCancel(ctx, run)
|
|
}); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// updatedJobs, not jobs: cancelOneJob re-reads the cancelled rows, the input ones still carry their pre-cancel status
|
|
CreateCommitStatusForRunJobs(ctx, run, updatedJobs...)
|
|
EmitJobsIfReadyByJobs(updatedJobs)
|
|
NotifyWorkflowJobsStatusUpdate(ctx, updatedJobs...)
|
|
|
|
reloaded, err := actions_model.GetRunByRepoAndID(ctx, run.RepoID, run.ID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("GetRunByRepoAndID: %w", err)
|
|
}
|
|
if len(updatedJobs) > 0 || reloaded.Status != run.Status {
|
|
NotifyWorkflowRunStatusUpdate(ctx, reloaded)
|
|
}
|
|
return reloaded, nil
|
|
}
|
|
|
|
func cancellableJobs(run *actions_model.ActionRun, jobs []*actions_model.ActionRunJob, force bool) []*actions_model.ActionRunJob {
|
|
if force || (run.Started.IsZero() && !run.Status.In(actions_model.StatusRunning, actions_model.StatusCancelling)) {
|
|
return jobs
|
|
}
|
|
toCancel := make([]*actions_model.ActionRunJob, 0, len(jobs))
|
|
for _, job := range jobs {
|
|
if !runsAfterCancellation(job) {
|
|
toCancel = append(toCancel, job)
|
|
}
|
|
}
|
|
return toCancel
|
|
}
|
|
|
|
func runsAfterCancellation(job *actions_model.ActionRunJob) bool {
|
|
if job.Status.IsDone() {
|
|
return false
|
|
}
|
|
parsed, err := job.ParseJob()
|
|
if err != nil || parsed.If.Value == "" {
|
|
return false
|
|
}
|
|
condition := jobparser.IfExpression(parsed.If.Value)
|
|
return expreval.CallsFunction(condition, "always") && !expreval.CallsFunction(condition, "cancelled")
|
|
}
|