mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-22 04:33:42 +09:00
cdf786ce92
`git commit --message=` passes the merge message as a single argument, which Linux caps at 128 KiB and Windows at 32 KiB for the whole command line. Long messages failed with `argument list too long` and the merge box toast showed the raw HTML 500 page. Pass the message via `--file=-` on stdin instead, and answer fetch-action requests with JSON on server errors so the toast shows the error text. Limits merge commit messages to 512KB which could be extended or made configurable later. Fixes: https://github.com/go-gitea/gitea/issues/39261 Fixes: https://github.com/go-gitea/gitea/issues/30276 Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
53 lines
1.3 KiB
Go
53 lines
1.3 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package context
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"testing"
|
|
|
|
"gitea.dev/modules/setting"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
setting.IsInTesting = true
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestRedirect(t *testing.T) {
|
|
req, _ := http.NewRequest(http.MethodGet, "/", nil)
|
|
|
|
cases := []struct {
|
|
url string
|
|
keep bool
|
|
}{
|
|
{"http://test", false},
|
|
{"https://test", false},
|
|
{"//test", false},
|
|
{"/://test", true},
|
|
{"/test", true},
|
|
}
|
|
for _, c := range cases {
|
|
resp := httptest.NewRecorder()
|
|
b := NewBaseContextForTest(t, resp, req)
|
|
resp.Header().Add("Set-Cookie", (&http.Cookie{Name: setting.SessionConfig.CookieName, Value: "dummy"}).String())
|
|
b.Redirect(c.url)
|
|
has := resp.Header().Get("Set-Cookie") == "i_like_gitea=dummy"
|
|
assert.Equal(t, c.keep, has, "url = %q", c.url)
|
|
}
|
|
|
|
req, _ = http.NewRequest(http.MethodGet, "/", nil)
|
|
resp := httptest.NewRecorder()
|
|
req.Header.Add("X-Gitea-Fetch-Action", "1")
|
|
b := NewBaseContextForTest(t, resp, req)
|
|
b.Redirect("/other")
|
|
assert.Contains(t, resp.Header().Get("Content-Type"), "application/json")
|
|
assert.JSONEq(t, `{"redirect":"/other"}`, resp.Body.String())
|
|
assert.Equal(t, http.StatusOK, resp.Code)
|
|
}
|