Eyüp Can Akman and GitHub
a49c893842
fix(pull): sign the commit when updating a branch by merge ( #38441 )
...
Updating a branch by merge produced an unsigned commit even when merges
are configured to be signed. Update by rebase was unaffected.
`Update()` builds a fake reverse PR to switch head and base, and it has
no `Index`, so `pr.GetGitHeadRefName()` resolves `refs/pull/0/head`.
Since #36186 `SignMerge` looks that ref up in the base repository
instead of the temporary merge repo. That lookup fails. The caller
dropped the error, so `sign` stayed false.
Sync fork goes through the same fake-PR path.
Pass both sides of the merge to `SignMerge` as refs and evaluate them in
the temp repo, where `base` and `tracking` always exist.
Tests cover a signed and an unsigned update by merge.
Fixes #38066
2026-07-16 21:38:39 +00:00
..
2026-07-16 23:10:43 +02:00
2026-07-14 18:24:18 +00:00
2026-05-26 15:49:31 -07:00
2026-07-03 20:07:37 +02:00
2026-07-15 17:30:01 +00:00
2026-06-17 16:06:51 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-07 07:08:05 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2025-03-31 01:53:48 -04:00
2026-06-13 12:02:02 +08:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-10 19:30:43 +02:00
2026-05-26 15:49:31 -07:00
2026-07-12 17:14:09 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-07 14:40:12 +08:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-16 21:38:39 +00:00
2026-05-26 15:49:31 -07:00
2026-06-09 06:12:09 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-06-28 09:31:35 +00:00
2026-06-11 17:33:21 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-04 15:02:17 +02:00
2026-07-04 15:02:17 +02:00
2026-07-15 17:30:01 +00:00
2026-06-13 04:43:25 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00
2022-11-27 18:20:29 +00:00
2026-07-15 17:30:01 +00:00
2026-05-26 15:49:31 -07:00
2026-05-26 15:49:31 -07:00
2026-07-15 17:30:01 +00:00
2026-07-15 17:30:01 +00:00