mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-10 05:24:18 +09:00
ad6107ab88
Follow-up to https://github.com/go-gitea/gitea/pull/37571. "Participating and mentions" deleted the watch row, so choosing it dropped you out of the watcher count. It is a watch like the others, so it now keeps a row and simply subscribes to no events. The dashboard feed ignored the per-event options, so a "Custom: issues" watcher still got pull request activity there. It now gates on the same options as mail and notifications. That also closes a gap where pull request reviews bypassed the permission check. Also, address https://github.com/go-gitea/gitea/pull/37571#discussion_r3740487363 and reword a UI text for clarity. --------- Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
178 lines
7.4 KiB
Go
178 lines
7.4 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package activities_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
activities_model "gitea.dev/models/activities"
|
|
"gitea.dev/models/db"
|
|
issues_model "gitea.dev/models/issues"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCreateOrUpdateIssueNotifications(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
|
|
_, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), issue.ID, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
|
|
// User 9 is inactive, thus notifications for user 1 and 4 are created
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 1, IssueID: issue.ID})
|
|
assert.Equal(t, activities_model.NotificationStatusUnread, notf.Status)
|
|
unittest.CheckConsistencyFor(t, &issues_model.Issue{ID: issue.ID})
|
|
|
|
notf = unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 4, IssueID: issue.ID})
|
|
assert.Equal(t, activities_model.NotificationStatusUnread, notf.Status)
|
|
}
|
|
|
|
func TestCreateOrUpdateIssueNotificationsForAssigneeAndReviewer(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// user 13 neither watches repo 1 nor participates in PR 3
|
|
assert.NoError(t, db.Insert(t.Context(), &issues_model.IssueAssignees{AssigneeID: 13, IssueID: 3}))
|
|
_, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), 3, 0, 1, 0)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 13, IssueID: 3})
|
|
|
|
// user 1 is a requested reviewer of PR 12 and does not participate in it
|
|
_, err = activities_model.CreateOrUpdateIssueNotifications(t.Context(), 12, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 1, IssueID: 12})
|
|
}
|
|
|
|
func TestCreateOrUpdateIssueNotificationsIgnored(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// user 4 watches repo 1 and would be notified about issue 1
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
assert.NoError(t, repo_model.WatchIgnoreRepo(t.Context(), user, repo))
|
|
|
|
notified, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), 1, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
assert.NotContains(t, notified, user.ID)
|
|
|
|
// muting outranks a direct receiver too
|
|
notified, err = activities_model.CreateOrUpdateIssueNotifications(t.Context(), 1, 0, 2, user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, notified)
|
|
}
|
|
|
|
func TestNotificationsForUser(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notfs, err := db.Find[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusRead,
|
|
activities_model.NotificationStatusUnread,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
if assert.Len(t, notfs, 3) {
|
|
assert.EqualValues(t, 5, notfs[0].ID)
|
|
assert.Equal(t, user.ID, notfs[0].UserID)
|
|
assert.EqualValues(t, 4, notfs[1].ID)
|
|
assert.Equal(t, user.ID, notfs[1].UserID)
|
|
assert.EqualValues(t, 2, notfs[2].ID)
|
|
assert.Equal(t, user.ID, notfs[2].UserID)
|
|
}
|
|
}
|
|
|
|
func TestNotification_GetRepo(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{RepoID: 1})
|
|
repo, err := notf.GetRepo(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, repo, notf.Repository)
|
|
assert.Equal(t, notf.RepoID, repo.ID)
|
|
}
|
|
|
|
func TestNotification_GetIssue(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{RepoID: 1})
|
|
issue, err := notf.GetIssue(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, issue, notf.Issue)
|
|
assert.Equal(t, notf.IssueID, issue.ID)
|
|
}
|
|
|
|
func TestGetNotificationCount(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
cnt, err := db.Count[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusRead,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 0, cnt)
|
|
|
|
cnt, err = db.Count[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusUnread,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1, cnt)
|
|
}
|
|
|
|
func TestSetNotificationStatus(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notf := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusRead})
|
|
_, err := activities_model.SetNotificationStatus(t.Context(), notf.ID, user, activities_model.NotificationStatusPinned)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notf.ID, Status: activities_model.NotificationStatusPinned})
|
|
|
|
_, err = activities_model.SetNotificationStatus(t.Context(), 1, user, activities_model.NotificationStatusRead)
|
|
assert.Error(t, err)
|
|
_, err = activities_model.SetNotificationStatus(t.Context(), unittest.NonexistentID, user, activities_model.NotificationStatusRead)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestUpdateNotificationStatuses(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notfUnread := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusUnread})
|
|
notfRead := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusRead})
|
|
notfPinned := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusPinned})
|
|
_, err := activities_model.UpdateNotificationStatuses(t.Context(), user, activities_model.NotificationStatusUnread, activities_model.NotificationStatusRead)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfUnread.ID, Status: activities_model.NotificationStatusRead})
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfRead.ID, Status: activities_model.NotificationStatusRead})
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfPinned.ID, Status: activities_model.NotificationStatusPinned})
|
|
}
|
|
|
|
func TestSetIssueReadBy(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
assert.NoError(t, db.WithTx(t.Context(), func(ctx context.Context) error {
|
|
_, err := activities_model.SetIssueReadBy(ctx, issue.ID, user.ID)
|
|
return err
|
|
}))
|
|
|
|
nt, err := activities_model.GetIssueNotification(t.Context(), user.ID, issue.ID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, activities_model.NotificationStatusRead, nt.Status)
|
|
}
|