mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-22 02:53:56 +09:00
Partial backport of https://github.com/go-gitea/gitea/pull/39690 with only its public-only token checks, without the refactor. 1. Admin, org owner and repo or org creation APIs reject public-only tokens. 1. Profile and org pages hide private repos and limited owners from public-only tokens. 1. Heatmap API, OIDC userinfo and OCI blob mounts respect public-only tokens. Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: bircni <bircni@icloud.com>
134 lines
5.0 KiB
Go
134 lines
5.0 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// RSS is a struct to unmarshal RSS feeds test only
|
|
type RSS struct {
|
|
Channel struct {
|
|
Title string `xml:"title"`
|
|
Link string `xml:"link"`
|
|
Description string `xml:"description"`
|
|
PubDate string `xml:"pubDate"`
|
|
Items []struct {
|
|
Title string `xml:"title"`
|
|
Link string `xml:"link"`
|
|
Description string `xml:"description"`
|
|
PubDate string `xml:"pubDate"`
|
|
} `xml:"item"`
|
|
} `xml:"channel"`
|
|
}
|
|
|
|
func TestFeedUser(t *testing.T) {
|
|
t.Run("User", func(t *testing.T) {
|
|
t.Run("Atom", func(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
req := NewRequest(t, "GET", "/user2.atom")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
data := resp.Body.String()
|
|
assert.Contains(t, data, `<feed xmlns="http://www.w3.org/2005/Atom"`)
|
|
})
|
|
|
|
t.Run("RSS", func(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
req := NewRequest(t, "GET", "/user2.rss")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
data := resp.Body.String()
|
|
assert.Contains(t, data, `<rss version="2.0"`)
|
|
|
|
var rss RSS
|
|
err := xml.Unmarshal(resp.Body.Bytes(), &rss)
|
|
assert.NoError(t, err)
|
|
assert.Contains(t, rss.Channel.Link, "/user2")
|
|
assert.NotEmpty(t, rss.Channel.PubDate)
|
|
})
|
|
})
|
|
}
|
|
|
|
// TestFeedUserPublicOnlyToken ensures a public-only API token cannot surface a user's
|
|
// private activity through their profile feed, even when authenticated as the owner.
|
|
func TestFeedUserPublicOnlyToken(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// user2 has activity on the private repo user2/repo2
|
|
const privateMarker = "user2/repo2"
|
|
|
|
// a normal read:user token authenticated as the owner sees private activity
|
|
fullToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser)
|
|
reqFull := NewRequest(t, "GET", "/user2.rss")
|
|
reqFull.SetBasicAuth("user2", fullToken)
|
|
respFull := MakeRequest(t, reqFull, http.StatusOK)
|
|
assert.Contains(t, respFull.Body.String(), privateMarker)
|
|
|
|
// a public-only token must not surface the private activity
|
|
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
|
reqPublicOnly := NewRequest(t, "GET", "/user2.rss")
|
|
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
|
respPublicOnly := MakeRequest(t, reqPublicOnly, http.StatusOK)
|
|
assert.NotContains(t, respPublicOnly.Body.String(), privateMarker)
|
|
}
|
|
|
|
// TestProfileActivityPublicOnlyToken ensures the HTML profile activity tab does not
|
|
// surface a user's private activity to a public-only API token, mirroring the RSS/Atom
|
|
// guard. The /{username} route is AllowBasic, so a public-only PAT used as the Basic
|
|
// password must still be downgraded even for the feed owner.
|
|
func TestProfileActivityPublicOnlyToken(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// user2 has activity on the private repo user2/repo2
|
|
const privateMarker = "user2/repo2"
|
|
|
|
// a normal read:user token authenticated as the owner sees private activity
|
|
fullToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser)
|
|
reqFull := NewRequest(t, "GET", "/user2?tab=activity")
|
|
reqFull.SetBasicAuth("user2", fullToken)
|
|
respFull := MakeRequest(t, reqFull, http.StatusOK)
|
|
assert.Contains(t, respFull.Body.String(), privateMarker)
|
|
|
|
// a public-only token must not surface the private activity
|
|
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
|
reqPublicOnly := NewRequest(t, "GET", "/user2?tab=activity")
|
|
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
|
respPublicOnly := MakeRequest(t, reqPublicOnly, http.StatusOK)
|
|
assert.NotContains(t, respPublicOnly.Body.String(), privateMarker)
|
|
}
|
|
|
|
func TestProfileReposAndLimitedOwnersPublicOnlyToken(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
fullToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser)
|
|
publicOnlyToken := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
|
for link, privateRepoLink := range map[string]string{
|
|
"/user2?tab=repositories&q=repo2": `"/user2/repo2"`,
|
|
"/user2?tab=stars": `"/user2/repo2"`,
|
|
"/org3": `"/org3/repo3"`,
|
|
} {
|
|
reqFull := NewRequest(t, "GET", link)
|
|
reqFull.SetBasicAuth("user2", fullToken)
|
|
assert.Contains(t, MakeRequest(t, reqFull, http.StatusOK).Body.String(), privateRepoLink, link)
|
|
reqPublicOnly := NewRequest(t, "GET", link)
|
|
reqPublicOnly.SetBasicAuth("user2", publicOnlyToken)
|
|
assert.NotContains(t, MakeRequest(t, reqPublicOnly, http.StatusOK).Body.String(), privateRepoLink, link)
|
|
}
|
|
|
|
for _, limitedLink := range []string{"/user33", "/user33.rss", "/limited_org"} {
|
|
assertBasicAuthStatus(t, limitedLink, fullToken, http.StatusOK)
|
|
assertBasicAuthStatus(t, limitedLink, publicOnlyToken, http.StatusNotFound)
|
|
}
|
|
}
|