3 people e3a43af379 fix(user): allow unblocking users promoted to admin (#39192) (#39402) ...

Backport #39192 by @loveulvu

Fixes #39189.

`IsUserBlockedBy` intentionally treats admin users as not blocked, but
`CanUnblockUser` was also using it to determine whether a blocking
relationship exists. If a previously blocked user is later promoted to
admin, the existing `user_blocking` record remains but can no longer be
removed.

This change separates those two concerns by adding `HasBlocking` for
checking the persisted blocking relationship. `CanUnblockUser` uses that
relationship check while `IsUserBlockedBy` keeps its existing admin-user
behavior.

A regression test verifies that an admin is still not considered blocked
while an existing blocking relationship can still be unblocked.

Tests:
- `go test ./models/user ./services/user -count=1`

Co-authored-by: Even <412401474@qq.com>

2026-09-23 20:26:48 +02:00

..

actions

fix(actions): let a rerun of selected jobs read the previous attempt's artifacts (#38857) (#38901)

2026-08-13 13:31:42 +00:00

activities

perf: extend action c_u index to include created_unix for faster dashboard feeds (#38076)

2026-06-17 23:37:55 +03:00

admin

refactor: Use db.Get[] instead of db.GetEngine(ctx).Get(bean) to avoid zero value fetching wrong database record (#37977)

2026-06-27 10:24:02 -07:00

asymkey

fix: various security fixes (#38406) (#38426)

2026-07-12 17:41:58 +00:00

auth

chore: Pre-register a builtin OAuth2 application for the official Gitea mobile app (#38880) (#38922)

2026-08-14 15:17:59 +02:00

avatars

refactor: Use db.Get[] instead of db.GetEngine(ctx).Get(bean) to avoid zero value fetching wrong database record (#37977)

2026-06-27 10:24:02 -07:00

db

feat(org): add team visibility so org members can discover teams (#37680)

2026-06-14 19:07:25 +00:00

dbfs

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

fixtures

Improve testing init, clean up webhook tests (#37412)

2026-04-25 18:55:18 +00:00

git

fix: branch protection user list (#38570) (#38584)

2026-07-22 21:36:12 +02:00

gituser

fix(ui): too many participants shown in commit avatar stacks (#38689) (#38700)

2026-07-29 21:39:09 +02:00

issues

fix(api): hide limited users from restricted viewers (#39004) (#39039)

2026-08-22 10:55:16 +00:00

migrations

feat(actions): support owner-level and global scoped workflows (#38154)

2026-06-28 09:31:35 +00:00

organization

fix(packages): restrict/limited/token-scope access (#39041, #39043, #39044, #39047, #39046) (#39058)

2026-08-28 00:34:49 +08:00

packages

fix(packages): restrict/limited/token-scope access (#39041, #39043, #39044, #39047, #39046) (#39058)

2026-08-28 00:34:49 +08:00

perm

fix(actions): enforce fork pull request trust boundaries (#39005) (#39018)

2026-08-21 14:25:59 +00:00

project

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

pull

refactor: Use db.Get[] instead of db.GetEngine(ctx).Get(bean) to avoid zero value fetching wrong database record (#37977)

2026-06-27 10:24:02 -07:00

renderhelper

fix: markup link (#38764) (#38765)

2026-08-03 15:04:52 +00:00

repo

fix(api): hide limited users from restricted viewers (#39004) (#39039)

2026-08-22 10:55:16 +00:00

secret

feat(actions)!: improve support for reusable workflows (#37478)

2026-05-30 08:31:14 +02:00

shared/types

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

system

refactor: Use db.Get[] instead of db.GetEngine(ctx).Get(bean) to avoid zero value fetching wrong database record (#37977)

2026-06-27 10:24:02 -07:00

unit

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

unittest

fix(auth): do not auto-reactivate disabled users on OAuth2 callback (#38009)

2026-06-06 22:07:47 +00:00

user

fix(user): allow unblocking users promoted to admin (#39192) (#39402)

2026-09-23 20:26:48 +02:00

webhook

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

main_test.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

repo_test.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

repo.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00