mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-25 14:13:40 +09:00
Updates actionslib to https://gitea.com/gitea/actionslib/releases/tag/v1.2.1, moves workflow parsing into it and aligns behaviour with GitHub. 1. `uses:` supports `self:` (Gitea-only feature) and `$/` paths. 1. `strategy`, `matrix`, `max-parallel` and `fail-fast` accept expressions, including over `needs`. A job whose `name`, `runs-on` or `continue-on-error` reads `needs` is resolved once they finish. 1. A job `if:` may only read `github`, `needs`, `vars` and `inputs` and is decided before the matrix, as on github.com. 1. Matrix `fail-fast` cancels the other combinations, and `always()` jobs keep running when a run is cancelled. 1. Invalid workflow files, including a malformed `on:` and unknown or cyclic `needs`, show up on push as failed runs with the error. 1. A job whose `if:` or `concurrency:` fails to evaluate is skipped or failed with the error, instead of staying blocked. 1. Reusable workflows: a missing and an unreadable repository fail alike, public callers cannot use private workflows, nested jobs cannot exceed the caller's token permissions. 1. Runner labels match case-insensitively, and `runs-on` accepts an array from an expression. Runner PR: https://gitea.com/gitea/runner/pulls/1247 Docs PR: https://gitea.com/gitea/docs/pulls/553 Fixes: https://github.com/go-gitea/gitea/issues/38990 Fixes: https://github.com/go-gitea/gitea/issues/39382 Fixes: https://github.com/go-gitea/gitea/issues/32364 Fixes: https://github.com/go-gitea/gitea/issues/36077 Fixes: https://github.com/go-gitea/gitea/issues/23277 Fixes: https://github.com/go-gitea/gitea/issues/29020 Co-authored-by: Claude (Opus 5) <noreply@anthropic.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
172 lines
6.3 KiB
Go
172 lines
6.3 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
actions_model "gitea.dev/models/actions"
|
|
actions_module "gitea.dev/modules/actions"
|
|
"gitea.dev/modules/actions/jobparser"
|
|
"gitea.dev/modules/json"
|
|
"gitea.dev/modules/log"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/modules/util"
|
|
)
|
|
|
|
// dispatchInputsForJob types a top-level job's `inputs.*` from EventPayload, empty for other events.
|
|
func dispatchInputsForJob(run *actions_model.ActionRun, job *actions_model.ActionRunJob) (map[string]any, error) {
|
|
if run.Event != "workflow_dispatch" {
|
|
return map[string]any{}, nil
|
|
}
|
|
var payload api.WorkflowDispatchPayload
|
|
if err := json.Unmarshal([]byte(run.EventPayload), &payload); err != nil {
|
|
return nil, err
|
|
}
|
|
if payload.Inputs == nil {
|
|
payload.Inputs = map[string]any{} // nil reads as "unresolved" in EvaluateRunConcurrencyFillModel
|
|
}
|
|
swf, _, err := jobparser.ParseRawSingleWorkflow(job.WorkflowPayload)
|
|
if err != nil {
|
|
return nil, util.NewInvalidArgumentErrorf("parse job %d workflow payload: %v", job.ID, err)
|
|
}
|
|
dispatch := swf.WorkflowDispatchConfig()
|
|
if dispatch == nil { // without it the values would silently stay untyped
|
|
return nil, util.NewInvalidArgumentErrorf("job %d payload declares no workflow_dispatch", job.ID)
|
|
}
|
|
coerceDispatchInputTypes(dispatch, payload.Inputs)
|
|
return payload.Inputs, nil
|
|
}
|
|
|
|
// dispatchInputsForRunJobs answers for the whole run, off any top-level job's workflow header.
|
|
func dispatchInputsForRunJobs(run *actions_model.ActionRun, jobs []*actions_model.ActionRunJob) (map[string]any, error) {
|
|
for _, job := range jobs {
|
|
if job.ParentJobID == 0 {
|
|
return dispatchInputsForJob(run, job)
|
|
}
|
|
}
|
|
return nil, fmt.Errorf("run %d: no top-level job to read the workflow_dispatch declaration from", run.ID)
|
|
}
|
|
|
|
// getInputsForJob returns the `inputs.*` top-level expression context for a job's evaluation.
|
|
// - For top-level jobs, it falls back to the run's dispatch inputs (empty for non-dispatch events)
|
|
// - For reusable workflow children (and nested callers), this is the direct parent caller's CallPayload.Inputs
|
|
func getInputsForJob(ctx context.Context, run *actions_model.ActionRun, job *actions_model.ActionRunJob) (map[string]any, error) {
|
|
if job.ParentJobID == 0 {
|
|
return dispatchInputsForJob(run, job)
|
|
}
|
|
|
|
caller, err := actions_model.GetRunJobByRunAndID(ctx, run.ID, job.ParentJobID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("load caller job %d: %w", job.ParentJobID, err)
|
|
}
|
|
if caller.CallPayload == "" {
|
|
// should not happen - a child job cannot reach this point if its caller's CallPayload hasn't been evaluated
|
|
return map[string]any{}, nil
|
|
}
|
|
var p api.WorkflowCallPayload
|
|
if err := json.Unmarshal([]byte(caller.CallPayload), &p); err != nil {
|
|
return nil, util.NewInvalidArgumentErrorf("decode caller %d payload: %v", caller.ID, err)
|
|
}
|
|
if p.Inputs == nil {
|
|
return map[string]any{}, nil
|
|
}
|
|
return p.Inputs, nil
|
|
}
|
|
|
|
// pullRequestTargetBaseSHA returns the base branch commit of a pull_request_target run, and whether the run is one.
|
|
func pullRequestTargetBaseSHA(run *actions_model.ActionRun) (string, bool) {
|
|
if run.TriggerEvent != actions_module.GithubEventPullRequestTarget {
|
|
return "", false
|
|
}
|
|
payload, err := run.GetPullRequestEventPayload()
|
|
if err != nil {
|
|
log.Error("run %d: get pull request event payload: %v", run.ID, err)
|
|
return "", false
|
|
}
|
|
if payload.PullRequest == nil || payload.PullRequest.Base == nil || payload.PullRequest.Base.Sha == "" {
|
|
return "", false
|
|
}
|
|
return payload.PullRequest.Base.Sha, true
|
|
}
|
|
|
|
// evaluateJobIf evaluates a job's `if:`
|
|
func evaluateJobIf(ctx context.Context, run *actions_model.ActionRun, attempt *actions_model.ActionRunAttempt, job *actions_model.ActionRunJob, vars map[string]string, allNeedsSucceed bool) (bool, error) {
|
|
parsedJob, err := job.ParseJob()
|
|
if err != nil {
|
|
return false, upsertJobErrorSummary(ctx, job, "if", err)
|
|
}
|
|
// Empty `if:` reduces to implicit `success()` - true iff every need finished as Success.
|
|
if len(parsedJob.If.Value) == 0 {
|
|
return allNeedsSucceed, nil
|
|
}
|
|
jobResults, err := findJobNeedsAndFillJobResults(ctx, job)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
inputs, err := getInputsForJob(ctx, run, job)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
// GenerateGiteaContext dereferences the run's repo and trigger user, so load them here instead of
|
|
// relying on whatever the caller happened to load before.
|
|
if err := run.LoadRepo(ctx); err != nil {
|
|
return false, err
|
|
}
|
|
if err := run.LoadTriggerUser(ctx); err != nil {
|
|
return false, err
|
|
}
|
|
gitCtx := GenerateGiteaContext(ctx, run, attempt, job)
|
|
gitCtx["job"] = "" // github.com decides a job's `if:` before the job exists
|
|
shouldStart, err := jobparser.EvaluateJobIfExpression(job.JobID, parsedJob, gitCtx, jobResults, vars, inputs)
|
|
if err != nil {
|
|
return false, upsertJobErrorSummary(ctx, job, "if", err)
|
|
}
|
|
return shouldStart, nil
|
|
}
|
|
|
|
func upsertJobErrorSummary(ctx context.Context, job *actions_model.ActionRunJob, key string, err error) error {
|
|
content := fmt.Sprintf("Error when evaluating `%s` for job `%s`.\n\n```\n%v\n```\n", key, job.JobID, err)
|
|
return actions_model.UpsertActionRunJobSummary(ctx, job.RepoID, job.RunID, job.RunAttemptID, job.ID, 0, actions_model.JobSummaryContentTypeMarkdown, []byte(content))
|
|
}
|
|
|
|
func findJobNeedsAndFillJobResults(ctx context.Context, job *actions_model.ActionRunJob) (map[string]*jobparser.JobResult, error) {
|
|
taskNeeds, jobsByID, err := FindTaskNeeds(ctx, job)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("find task needs: %w", err)
|
|
}
|
|
jobResults := make(map[string]*jobparser.JobResult, len(taskNeeds)+1)
|
|
for jobID, taskNeed := range taskNeeds {
|
|
jobResults[jobID] = &jobparser.JobResult{
|
|
Result: taskNeed.Result.String(),
|
|
Outputs: taskNeed.Outputs,
|
|
}
|
|
}
|
|
jobResults[job.JobID] = &jobparser.JobResult{
|
|
Needs: job.Needs,
|
|
}
|
|
if len(job.Needs) == 0 {
|
|
return jobResults, nil
|
|
}
|
|
|
|
queue := append([]string(nil), job.Needs...)
|
|
for len(queue) > 0 {
|
|
jobID := queue[0]
|
|
queue = queue[1:]
|
|
if len(jobsByID[jobID]) == 0 {
|
|
continue
|
|
}
|
|
if jobResults[jobID] == nil {
|
|
jobResults[jobID] = &jobparser.JobResult{Result: actions_model.AggregateJobStatus(jobsByID[jobID]).String()}
|
|
}
|
|
if jobResults[jobID].Needs != nil {
|
|
continue
|
|
}
|
|
jobResults[jobID].Needs = jobsByID[jobID][0].Needs
|
|
queue = append(queue, jobResults[jobID].Needs...)
|
|
}
|
|
return jobResults, nil
|
|
}
|