src: Always return a value from non void function elide() (#760)

elide() needs to always return std:string.

We cover all cases because our switch contains all current possibilities
for ElideMode.

But the compiler will still warn/error on this, depending on system
configuration.

I would like to add a `return "";` or `return str;` or add a `default:`
case to the switch to silence this compiler complaint.

Regards https://github.com/CoatiSoftware/Sourcetrail/issues/758
This commit is contained in:
Michael Vetter
2019-12-16 15:53:57 +01:00
committed by Eberhard Graether
parent a89097a556
commit 25bb613124
@@ -580,6 +580,8 @@ std::string elide(const std::string& str, ElideMode mode, size_t size)
case ELIDE_RIGHT:
return str.substr(0, size - 3) + "...";
}
return "";
}
std::wstring elide(const std::wstring& str, ElideMode mode, size_t size)
@@ -599,6 +601,8 @@ std::wstring elide(const std::wstring& str, ElideMode mode, size_t size)
case ELIDE_RIGHT:
return str.substr(0, size - 3) + L"...";
}
return "";
}
std::wstring convertWhiteSpacesToSingleSpaces(const std::wstring& str)