data: fixed parsing problems

* fixed calleeDecl pointer not checked for CallExpr
* fixed CommentHandler not checking if valid file in FileRegister
This commit is contained in:
Eberhard Graether
2015-11-10 10:25:47 +01:00
parent 5ef9ef9e7d
commit 3351e4aad7
4 changed files with 22 additions and 12 deletions
+1 -1
View File
@@ -8,7 +8,7 @@
ASTAction::ASTAction(ParserClient* client, FileRegister* fileRegister)
: m_client(client)
, m_fileRegister(fileRegister)
, m_commentHandler(client)
, m_commentHandler(client, fileRegister)
{
}
+1 -1
View File
@@ -45,7 +45,7 @@ void ASTBodyVisitor::VisitCallExpr(clang::CallExpr* expr)
{
clang::Decl* calleeDecl = expr->getCalleeDecl();
if (clang::isa<clang::CXXMethodDecl>(calleeDecl))
if (calleeDecl && clang::isa<clang::CXXMethodDecl>(calleeDecl))
{
clang::CXXRecordDecl* recordDecl = clang::dyn_cast<clang::CXXMethodDecl>(calleeDecl)->getParent();
ignore = recordDecl->isLambda();
+17 -9
View File
@@ -1,8 +1,12 @@
#include "data/parser/cxx/CommentHandler.h"
#include "data/parser/ParserClient.h"
CommentHandler::CommentHandler(ParserClient* client)
#include "utility/file/FileManager.h"
#include "utility/file/FileRegister.h"
CommentHandler::CommentHandler(ParserClient* client, FileRegister* fileRegister)
: m_client(client)
, m_fileRegister(fileRegister)
{
}
@@ -15,14 +19,18 @@ bool CommentHandler::HandleComment(clang::Preprocessor& preprocessor, clang::Sou
clang::SourceManager& sourceManager = preprocessor.getSourceManager();
const clang::PresumedLoc& presumedBegin = sourceManager.getPresumedLoc(sourceRange.getBegin(), false);
const clang::PresumedLoc& presumedEnd = sourceManager.getPresumedLoc(sourceRange.getEnd(), false);
m_client->onCommentParsed(ParseLocation(
presumedBegin.getFilename(),
presumedBegin.getLine(),
presumedBegin.getColumn(),
presumedEnd.getLine(),
presumedEnd.getColumn()
));
FilePath filePath = FilePath(presumedBegin.getFilename());
if (m_fileRegister->getFileManager()->hasFilePath(filePath) && !m_fileRegister->fileIsParsed(filePath))
{
m_client->onCommentParsed(ParseLocation(
presumedBegin.getFilename(),
presumedBegin.getLine(),
presumedBegin.getColumn(),
presumedEnd.getLine(),
presumedEnd.getColumn()
));
}
return false;
}
+3 -1
View File
@@ -3,19 +3,21 @@
#include "clang/Lex/Preprocessor.h"
class FileRegister;
class ParserClient;
class CommentHandler
: public clang::CommentHandler
{
public:
CommentHandler(ParserClient* client);
CommentHandler(ParserClient* client, FileRegister* fileRegister);
virtual ~CommentHandler();
virtual bool HandleComment(clang::Preprocessor& preprocessor, clang::SourceRange sourceRange);
private:
ParserClient* m_client;
FileRegister* m_fileRegister;
};
#endif // COMMENT_HANDLER_H