ynkmr/Sourcetrail
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

build: Fixed macOS bundling issues

Browse Source 
* Fixed Info.plist file missing values and deprecated keys
* Compress with 'ditto' instead of 'zip' for correct app notarization
This commit is contained in:
Eberhard Graether
2020-03-31 14:04:36 +02:00
parent 5617672ee6
commit 3aa7a85574
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
setup/macOS/bundle_info.plist.in
+2 -6
View File
@@ -5,9 +5,9 @@
<key>CFBundleDisplayName</key>
<string>Sourcetrail</string>
<key>CFBundleDevelopmentRegion</key>
<string>English</string>
<string>en</string>
<key>CFBundleExecutable</key>
<string>@MACOSX_BINARY_NAME@</string>
<string>@MACOS_BINARY_NAME@</string>
<key>CFBundleIdentifier</key>
<string>com.sourcetrail</string>
<key>CFBundleInfoDictionaryVersion</key>
@@ -16,16 +16,12 @@
<string>Sourcetrail</string>
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>@VERSION_STRING@</string>
<key>CFBundleShortVersionString</key>
<string>@VERSION_STRING@</string>
<key>CSResourcesFileMapped</key>
<true/>
<key>LSRequiresCarbon</key>
<true/>
<key>NSHumanReadableCopyright</key>
<string></string>
<key>NSHighResolutionCapable</key>
setup/macOS/bundle_install.sh.in
+1 -1
View File
@@ -248,7 +248,7 @@ while true; do
[Yy]* )
echo -e $INFO "Notarize app.";
zip ${BUNDLE_PATH}.zip ${BUNDLE_PATH};
ditto -c -k --keepParent ${BUNDLE_PATH} ${BUNDLE_PATH}.zip;
xcrun altool --notarize-app --primary-bundle-id "com.sourcetrail" --username "egraether@coati.io"
--password "@keychain:sourcetrail_notarization" --file ${BUNDLE_PATH}.zip;
# xcrun altool --notarization-history 0 -u "egraether@coati.io" -p "@keychain:sourcetrail_notarization";