565957503c
Backport #39531 by @CalvinTjoaquinn ## What `BatchChecker.CheckPath` uses `time.After` inside its read loop. This replaces it with a `time.Timer` that is stopped once the attribute arrives. ## Why ```go for i := 0; i < c.attributesNum; i++ { select { case <-time.After(5 * time.Second): // there is no "hang" problem now. This code is just used to catch other potential problems. return nil, reportTimeout() case attr, ok := <-c.stdOut.ReadAttribute(): ``` `time.After` has no way to be cancelled, so the timer it allocates stays in the runtime timer heap for the full five seconds whichever case the `select` picks. On the normal path the attribute arrives immediately and the timer is abandoned while still pending. The multiplier is what makes it worth changing rather than leaving as noise. The loop runs `len(LinguistAttributes)` times, which is six, and `CheckPath` is called once per file: ```go // modules/git/languagestats/language_stats_get.go:95, in the loop over repository files attrs, err := checker.CheckPath(f.Name()) // services/gitdiff/gitdiff.go:1408, in the loop over diff files attrs, err := checker.CheckPath(diffFile.Name) ``` So a language-stats pass over a repository of N files holds up to 6N pending five-second timers, and a large diff does the same per file. By the comment's own account that timeout path does not fire in practice, so every one of those timers is allocated and held for nothing. ## The change `time.NewTimer` plus `Stop` on the paths that win, which keeps the behaviour identical: each iteration still gets its own five-second budget, and the timer is released as soon as the attribute or the context arrives rather than five seconds later. If you would rather have a single budget for the whole read, one timer hoisted above the loop with `defer timeout.Stop()` is simpler and stricter, since six attributes from an already running `git check-attr` should arrive together. That changes the semantics from per-attribute to per-call, so I left it alone and am happy to switch if you prefer it. ## Verification ``` go build ./modules/git/... go vet ./modules/git/attribute/ go test -count=1 ./modules/git/attribute/ # 11 tests, 0 failures golangci-lint run ./modules/git/attribute/... gofmt -l modules/git/attribute/ # no output ``` The package's own `CheckPath` tests cover the success path, the closed-stdout path and the context-cancelled path, which are the three `select` arms touched here. Found with a small AST pass over the tree looking for `time.After` inside loop bodies. `staticcheck`'s SA1015 covers `time.Tick` and says nothing about this shape, so no linter in the current set reports it. Of the nine other hits in the tree the rest look deliberate or harmless, and `modules/queue/workergroup.go` already guards against exactly this by only creating a debounce timer when none is pending, so I only changed this one. <sub>Disclosure per the AI Contribution Policy: I used an AI tool to help find this and to draft the description. The counts above are `len(LinguistAttributes)` and the two call sites cited, so they can be checked directly.</sub> Signed-off-by: Calvin Tjoaquinn <calvintjoa23@gmail.com> Co-authored-by: Calvin Tjoaquinn <66313400+CalvinTjoaquinn@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Gitea
Purpose
The goal of Gitea is to make the easiest, fastest, and most painless way of setting up a self-hosted all-in-one software development service, including Git hosting, code management, code review, issue tracking, project kanban, wiki, team collaboration, package registry and CI/CD which can reuse GitHub Actions.
As Gitea is written in Go, it works across all the platforms and architectures that are supported by Go, including Linux, macOS, FreeBSD/OpenBSD and Windows on x86, amd64, ARM, RISC-V 64 and PowerPC architectures.
For online demonstrations, you can visit demo.gitea.com.
For accessing free Gitea service (with a limited number of repositories), you can visit gitea.com.
To quickly deploy your own dedicated Gitea instance on Gitea Cloud, you can start a free trial at cloud.gitea.com, or use container (docker/podman/etc) to deploy on your own server with the official image.
Documentation
You can find comprehensive documentation on our official documentation website.
It includes installation, administration, usage, development, contributing guides, and more to help you get started and explore all features effectively.
If you have any suggestions or would like to contribute to it, you can visit the documentation repository
Building
See docs/build-setup.md for prerequisites and docs/development.md for setting up a local development environment, linting, and testing.
If you'd like to build from source or make a distribution package, see docs/build-source.md for more information.
After building, you can run ./gitea web to start the server, or ./gitea help to see all available commands.
Contributing
Expected workflow is: Fork -> Patch -> Push -> Pull Request
Note
- YOU MUST READ THE CONTRIBUTORS GUIDE BEFORE STARTING TO WORK ON A PULL REQUEST.
- New to the codebase? The development guide walks through setting up a local environment and building from source.
- If you have found a vulnerability in the project, please write privately to security@gitea.io. Thanks!
Translating
Translations are done through Crowdin. If you want to translate to a new language, ask one of the managers in the Crowdin project to add a new language there.
You can also just create an issue for adding a language or ask on Discord on the #translation channel. If you need context or find some translation issues, you can leave a comment on the string or ask on Discord.
Get more information from the translation section of our contributing guide.
Official and Third-Party Projects
We provide an official go-sdk, a CLI tool called tea and an action runner for Gitea Action.
We maintain a list of Gitea-related projects at gitea/awesome-gitea, where you can discover more third-party projects, including SDKs, plugins, themes, and more.
Communication
If you have questions that are not covered by the documentation, you can get in contact with us on our Discord server or create a post in the discourse forum.
Authors
Backers
Thank you to all our backers! 🙏 [Become a backer]
Sponsors
Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]
FAQ
How do you pronounce Gitea?
Gitea is pronounced /ɡɪ’ti:/ as in "gi-tea" with a hard g.
How do I configure Gitea?
For dynamic config options, you can change it on your admin panel's configuration section.
For static config options, you can edit your app.ini file and restart the instance.
See app.example.ini or configuration documentation for more details.
Where can I find the security patches?
In the release log or the change log, search for the keyword SECURITY to find the security patches.
(more FAQs are listed in FAQ documentation)
License
This project is licensed under the MIT License. See the LICENSE file for the full license text.
Further information
Looking for an overview of the interface? Check it out the screenshots!
Login/Register Page
User Dashboard
User Profile
Explore
Repository
Repository Issue
Repository Pull Requests
Repository Actions
Repository Activity
Organization
