mirror of
https://github.com/go-gitea/gitea.git
synced 2026-09-25 14:13:40 +09:00
Updates actionslib to https://gitea.com/gitea/actionslib/releases/tag/v1.2.1, moves workflow parsing into it and aligns behaviour with GitHub. 1. `uses:` supports `self:` (Gitea-only feature) and `$/` paths. 1. `strategy`, `matrix`, `max-parallel` and `fail-fast` accept expressions, including over `needs`. A job whose `name`, `runs-on` or `continue-on-error` reads `needs` is resolved once they finish. 1. A job `if:` may only read `github`, `needs`, `vars` and `inputs` and is decided before the matrix, as on github.com. 1. Matrix `fail-fast` cancels the other combinations, and `always()` jobs keep running when a run is cancelled. 1. Invalid workflow files, including a malformed `on:` and unknown or cyclic `needs`, show up on push as failed runs with the error. 1. A job whose `if:` or `concurrency:` fails to evaluate is skipped or failed with the error, instead of staying blocked. 1. Reusable workflows: a missing and an unreadable repository fail alike, public callers cannot use private workflows, nested jobs cannot exceed the caller's token permissions. 1. Runner labels match case-insensitively, and `runs-on` accepts an array from an expression. Runner PR: https://gitea.com/gitea/runner/pulls/1247 Docs PR: https://gitea.com/gitea/docs/pulls/553 Fixes: https://github.com/go-gitea/gitea/issues/38990 Fixes: https://github.com/go-gitea/gitea/issues/39382 Fixes: https://github.com/go-gitea/gitea/issues/32364 Fixes: https://github.com/go-gitea/gitea/issues/36077 Fixes: https://github.com/go-gitea/gitea/issues/23277 Fixes: https://github.com/go-gitea/gitea/issues/29020 Co-authored-by: Claude (Opus 5) <noreply@anthropic.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
72 lines
3.0 KiB
Go
72 lines
3.0 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"gitea.dev/actionslib/pkg/model"
|
|
actions_model "gitea.dev/models/actions"
|
|
"gitea.dev/modules/log"
|
|
)
|
|
|
|
// parseMaxParallel returns strategy.max-parallel for a job, 0 meaning unlimited.
|
|
func parseMaxParallel(jobID, maxParallelString string) int {
|
|
limit, err := model.Strategy{MaxParallelString: maxParallelString}.MaxParallel()
|
|
if err != nil && !strings.Contains(maxParallelString, "${{") { // a deferred matrix placeholder's expression is evaluated at expansion
|
|
log.Warn("job %s: %v, treating as unlimited", jobID, err)
|
|
}
|
|
return min(limit, actions_model.MaxJobNumPerRun)
|
|
}
|
|
|
|
// maxParallelSlots counts the jobs holding a max-parallel slot. Slots are scoped by ParentJobID as
|
|
// well as JobID so the same job name in two reusable workflow calls does not cross-link, matching
|
|
// how jobStatusResolver scopes needs.
|
|
type maxParallelSlots map[maxParallelKey]int
|
|
|
|
type maxParallelKey struct {
|
|
parentJobID int64
|
|
jobID string
|
|
}
|
|
|
|
// hold seeds a job's slot from a status it already holds, bypassing the limit check.
|
|
// The status is passed separately because the job emitter tracks statuses outside the job model.
|
|
func (s maxParallelSlots) hold(job *actions_model.ActionRunJob, status actions_model.Status) {
|
|
if job.MaxParallel <= 0 {
|
|
return // an unlimited job's count is never read by take, don't accumulate it
|
|
}
|
|
// A Cancelling job still owns its runner, so it keeps its slot until cleanup finishes.
|
|
// An expanded reusable caller is underway even while its children aggregate it back to Blocked, so it holds a slot too.
|
|
if status.In(actions_model.StatusRunning, actions_model.StatusWaiting, actions_model.StatusCancelling) ||
|
|
(job.IsReusableCaller && job.IsExpanded && !status.IsDone()) {
|
|
s[maxParallelKey{job.ParentJobID, job.JobID}]++
|
|
}
|
|
}
|
|
|
|
// available reports whether a slot is free without reserving it.
|
|
// Peek it before running the concurrency check: DO NOT cancel the group's other pending jobs if no available slots.
|
|
func (s maxParallelSlots) available(job *actions_model.ActionRunJob) bool {
|
|
return job.MaxParallel <= 0 || s[maxParallelKey{job.ParentJobID, job.JobID}] < job.MaxParallel
|
|
}
|
|
|
|
// take reserves a slot and reports whether one was free. A job without a limit always succeeds.
|
|
func (s maxParallelSlots) take(job *actions_model.ActionRunJob) bool {
|
|
if !s.available(job) {
|
|
return false
|
|
}
|
|
if job.MaxParallel > 0 {
|
|
s[maxParallelKey{job.ParentJobID, job.JobID}]++
|
|
}
|
|
return true
|
|
}
|
|
|
|
// applyMaxParallel demotes a ready job to Blocked when its slots are full, leaving the job emitter to
|
|
// promote it once one frees. Call it after concurrency evaluation so a concurrency-blocked job does
|
|
// not consume a slot, and before the insert so a held-back reusable caller is not expanded.
|
|
func applyMaxParallel(job *actions_model.ActionRunJob, slots maxParallelSlots) {
|
|
if job.Status == actions_model.StatusWaiting && !slots.take(job) {
|
|
job.Status = actions_model.StatusBlocked
|
|
}
|
|
}
|